Re: [PATCHES] contrib mode - pgenv

2003-09-22 Thread Mike Mascari
Tom Lane wrote: > Peter Eisentraut <[EMAIL PROTECTED]> writes: > >>We've rejected session variables many times before because they duplicate >>temporary tables. I don't see anything new added by this proposal. > > I should think there would be a notable performance advantage, since > one need n

Re: [PATCHES] contrib mode - pgenv

2003-09-22 Thread Mike Mascari
Peter Eisentraut wrote: > Tom Lane writes: > > >>I should think there would be a notable performance advantage, since >>one need not create a temp table (which in our current implementation is >>just as expensive as creating a permanent table); not to mention >>dropping the temp table later, vac

Re: [PATCHES] contrib mode - pgenv

2003-09-22 Thread Peter Eisentraut
Tom Lane writes: > I should think there would be a notable performance advantage, since > one need not create a temp table (which in our current implementation is > just as expensive as creating a permanent table); not to mention > dropping the temp table later, vacuuming up the resulting dead row

[PATCHES] bug in clusterdb script

2003-09-22 Thread washingtonirving
Hi There's a bug in the clusterdb script where it looks like the arguments to the psql command are being passed in the wrong order, so it fails when you run it on a database that is not on localhost. Here's the output from the command: 133 anands-Computer:bin/scripts> clusterdb -h wooster -U rr gr

Re: [PATCHES] fix log_min_duration_statement logic error

2003-09-22 Thread Andrew Dunstan
Tom Lane wrote: Neil Conway <[EMAIL PROTECTED]> writes: I also don't particularly like the format of the log message (for one thing, the "duration_statement" prefix in the log message shouldn't include an underscore, it's not a variable or anything -- and the case can be made that if we printed

Re: [PATCHES] fix log_min_duration_statement logic error

2003-09-22 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > I also don't particularly like the format of the log message (for one > thing, the "duration_statement" prefix in the log message shouldn't > include an underscore, it's not a variable or anything -- and the case > can be made that if we printed the duratio

[PATCHES] fix log_min_duration_statement logic error

2003-09-22 Thread Neil Conway
This patch fixes an obvious bug in the "should I print the duration of this query?" logic in postgres.c I also don't particularly like the format of the log message (for one thing, the "duration_statement" prefix in the log message shouldn't include an underscore, it's not a variable or anything -