Re: [PATCHES] minor cleanup in plpgsql.sgml

2003-11-25 Thread Peter Eisentraut
Tom Lane writes: Robert Treat [EMAIL PROTECTED] writes: ! SELECT INTO users_rec * FROM users WHERE user_id=3; --- 986,993 ! SELECT * FROM users WHERE user_id=3 INTO users_rec; Why do you want to change the example to disagree with the advice given just above? : At

Re: [PATCHES] minor cleanup in plpgsql.sgml

2003-11-25 Thread Tom Lane
Peter Eisentraut [EMAIL PROTECTED] writes: Well, that position is a strange choice. The standard syntax of SELECT INTO in embedded SQL is SELECT a, b, c INTO :x, :y, :z FROM ... This should probably be consistent. Well, I'm not wedded to the current recommendation, but we'll never be able to

Re: [PATCHES] minor cleanup in plpgsql.sgml

2003-11-25 Thread Robert Treat
Sorry Neil. I thought I recalled you submitting a similar patch, but must have missed it in the archives and didn't see the change reflected in cvs so assmeme'd that your change was in a different place.. :-( Robert Treat On Tue, 2003-11-25 at 14:04, Neil Conway wrote: Robert Treat [EMAIL

Re: [PATCHES] minor cleanup in plpgsql.sgml

2003-11-25 Thread Christopher Kings-Lynne
Ummm - surely the original was correct? Chris Robert Treat wrote: Marcos Truchado [EMAIL PROTECTED] reported this on -docs yesterday. Robert Treat Index: plpgsql.sgml

Re: [PATCHES] Bug in fd.c (FreeFile)

2003-11-25 Thread Claudio Natoli
Nope. My bad. My head has an off by one error. Drop the first part of the patch, but the second part could be retained. Very minor. Off to hide in shame, Claudio -Original Message- From: Claudio Natoli [mailto:[EMAIL PROTECTED] Sent: Wednesday, 26 November 2003 12:34 PM To: [EMAIL

Re: [PATCHES] minor cleanup in plpgsql.sgml

2003-11-25 Thread Robert Treat
The reported correction was removing the superfluous full_name varchar (which Neil Conway also reported a few days back). When i was rewriting the function, I subconsciously switched the SELECT INTO statement to the (IMHO) more legible syntax, though nothing was wrong with the previous

[PATCHES] make installcheck on non-default ports

2003-11-25 Thread Joe Conway
I was trying to set up my dev box for multiple simultaneous Postgres installs (7.3 stable, 7.4 stable, cvs head) and discovered that `make installcheck` did not honor the default port assigned at configure time. I view this as a bug. The attached resolves the issue for all three versions. Any

Re: [PATCHES] make installcheck on non-default ports

2003-11-25 Thread Tom Lane
Joe Conway [EMAIL PROTECTED] writes: I was trying to set up my dev box for multiple simultaneous Postgres installs (7.3 stable, 7.4 stable, cvs head) and discovered that `make installcheck` did not honor the default port assigned at configure time. I view this as a bug. I think there is

Re: [PATCHES] (Modified) Patch request for PostgreSQL 7.4 for HP-UX

2003-11-25 Thread Peter Eisentraut
ViSolve Open Source Team writes: 1. s_lock.h: modified with inline tas code for the HP-C compiler What is this line all about? +#if defined(__HP_aCC) || defined(__HP_cc) There are no other compilers supported, so this seems redundant. 2. genbki.sh: a one-line change that fixes a string