Claudio Natoli [EMAIL PROTECTED] writes:
This has required some reworking of the existing code base, particularly to
BackendFork (which now actually does the fork()). As such, I've been
anticipating that this will be the most controversial of the fork/exec
patches, so critique away :-)
You
I said:
We should either find a way to make the fork/exec path more like the
existing code, or bite the bullet and change them both.
It occurs to me that you probably need some concrete suggestions about
what to do. Here's one.
There are really three separate sections in this code: the
Manfred Spraul [EMAIL PROTECTED] writes:
Intel recommends to add a special pause instruction into spinlock busy
loops. It's necessary for hyperthreading - without it, the cpu can't
figure out that a logical thread does no useful work and incorrectly
awards lots of execution resources to
Tom Lane wrote:
Manfred Spraul [EMAIL PROTECTED] writes:
Intel recommends to add a special pause instruction into spinlock busy
loops. It's necessary for hyperthreading - without it, the cpu can't
figure out that a logical thread does no useful work and incorrectly
awards lots of execution
Manfred Spraul [EMAIL PROTECTED] writes:
Tom Lane wrote:
Don't you have to put it in a specific place in the loop to make that
work? If not, why not?
Rep;nop is just a short delay - that's all.
That view seems to me to be directly contradicted by this statement:
The PAUSE instruction
Thanks for your comments Tom.
Tom Lane writes:
Claudio Natoli [EMAIL PROTECTED] writes:
This has required some reworking of the existing code base, particularly
to
BackendFork (which now actually does the fork()). As such, I've been
anticipating that this will be the most controversial
Claudio Natoli [EMAIL PROTECTED] writes:
Ok. So, in conclusion we are in agreement on at least one thing: the current
patch sucks.
Good, I'm glad we see eye to eye on that ;-)
Here's the critical difference in our thinking:
ISTM that we'll have to go to a lot of work to get the
Peter Eisentraut [EMAIL PROTECTED] writes:
Christopher Kings-Lynne writes:
Now you've lost me - how is a user-inputted object name translatable?
Not all languages use ... as quote symbols, but if you make them part of
some string that comes from the backend, it becomes prohibitively hard to