Andrew Dunstan [EMAIL PROTECTED] writes:
Submitted for review.
Okay, some random comments:
! char *ListenAddresses = localhost;
I think you made this mistake in the log_line_prefix patch too. The
contents of a GUC string var should always be either NULL or a pointer
to a malloc'd
Andrew Dunstan [EMAIL PROTECTED] writes:
This patch attempts to implement the idea, with safety in case the
packet is not immediately available.
Seems like you ought to be testing for failure returns from send() and
recv(). Also, what of EINTR from select()?
regards,
Newest version of patch applied. Thanks.
Handles views and sequences.
---
Euler Taveira de Oliveira wrote:
Hi,
I just noticed that \dp outputs Table to indicate relations (tables, sequences and
views) instead of
This is the one applied.
---
Euler Taveira de Oliveira wrote:
Hi Bruce,
Sounds good. Do you want your original patch applied?
Sorry for the delay, i just redo the patch and change some documentation. Please
I could not get this patch to compile. I am getting a failure because
BSD/OS doesn't have pthread_rwlock_wrlock(). I am concerned other
platforms might not have it either.
The compile failure is:
gcc -O2 -fno-strict-aliasing -Wall -Wmissing-prototypes -Wmissing-declarations -O1
-Wall
I have increased the str_time() static variable length to 128. Thanks.
---
Korea PostgreSQL Users' Group wrote:
On multibyte language locale environment of win32, size of %Z of localtime()
function is bigger more then
Karel, do you plan to use pstrndup for some purpose? I assume so.
---
Karel Zak wrote:
Hi guys,
we have pstrdup(char *string) and this tiny patch adds
pstrndup(char *sting, Size len).
By the way, I a
Bruce Momjian [EMAIL PROTECTED] writes:
Karel, do you plan to use pstrndup for some purpose? I assume so.
I am not familiar with strndup. If the spec is like strncpy, I would
vote against including it ... strncpy is so broken that we had to invent
our own variant ...
Jim Seymour wrote:
Bruce Momjian [EMAIL PROTECTED] wrote:
[snip]
OK, patch attached and applied. It adds configure tests for the 5-arg
version of getpwuid_r() and properly falls back to the Posix draft
version you have on Solaris. Seems Solaris 9 also still has the draft
version.
Larry Rosenman wrote:
-- Start of PGP signed section.
[moved to -patches because of the patch]
--On Friday, March 19, 2004 08:01:53 -0500 Bruce Momjian
[EMAIL PROTECTED] wrote:
Larry Rosenman wrote:
I thought that once you include libpthread in libpq, that you don't
have to
Bruce Momjian wrote:
I could not get this patch to compile. I am getting a failure because
BSD/OS doesn't have pthread_rwlock_wrlock(). I am concerned other
platforms might not have it either.
I feared that. I'll switch to pthread_mutex_lock()+_unlock().
pthread_rwlock_wrlock()+_unlock was
On Sun, Mar 21, 2004 at 11:45:18PM -0500, Tom Lane wrote:
Bruce Momjian [EMAIL PROTECTED] writes:
Karel, do you plan to use pstrndup for some purpose? I assume so.
I thinkPostgreSQL should supports basicoperation with
allocation/strings if it's open for users' C
12 matches
Mail list logo
