Re: [PATCHES] Compiling libpq with VisualC

2004-06-03 Thread Andreas Pflug
Bruce Momjian wrote: fe-connect.c: - pg_config_paths.h isn't available. SYSCONFDIR is already defined so fe-connect.c doesn't need to include that. patch appended This shouldn't be needed anymore. Where is SYSCONFDIR coming from? Is it from some Win32 include file? It should only be

[PATCHES] Stylistic changes in bufmgr.c

2004-06-03 Thread Manfred Koizar
Basically replaces (*a).b with a-b as it is everywhere else in Postgres. Servus Manfred diff -Ncr ../base/src/backend/storage/page/bufpage.c src/backend/storage/page/bufpage.c *** ../base/src/backend/storage/page/bufpage.c Sat Nov 29 20:51:57 2003 --- src/backend/storage/page/bufpage.c Wed Jun

[PATCHES] vacuum.c refactoring

2004-06-03 Thread Manfred Koizar
. rename variables . cur_buffer - dst_buffer . ToPage - dst_page . cur_page - dst_vacpage . move variable declarations into block where variable is used . various Asserts instead of elog(ERROR, ...) . extract functionality from repair_frag() into new routines .

Re: [PATCHES] [HACKERS] Configuration patch

2004-06-03 Thread Tom Lane
Bruce Momjian [EMAIL PROTECTED] writes: This patch incorporates a number of changes suggested by the group. The purpose of this patch is to move postgresql to a position where all configuration options are specified in one place. The postgresql.conf file could completely document a postgresql

Re: [PATCHES] fix oid casting inconsistency

2004-06-03 Thread Alvaro Herrera
On Mon, Feb 16, 2004 at 10:00:49PM -0500, Neil Conway wrote: This patch removes the quotes from oid, to make this error message consistent with the error messages for rejected input to most other types. While I suppose it's possible that some applications might be examining this error

Re: [PATCHES] [HACKERS] Configuration patch

2004-06-03 Thread pgsql
Bruce Momjian [EMAIL PROTECTED] writes: This patch incorporates a number of changes suggested by the group. The purpose of this patch is to move postgresql to a position where all configuration options are specified in one place. The postgresql.conf file could completely document a

Re: [PATCHES] Add error-checking to timestamp_recv

2004-06-03 Thread Tom Lane
I said: I'll make a note to do something with this issue after the TZ patch is in. I've applied a patch to take care of this problem. regards, tom lane ---(end of broadcast)--- TIP 5: Have you checked our extensive FAQ?

Re: [PATCHES] [HACKERS] Configuration patch

2004-06-03 Thread Tom Lane
[EMAIL PROTECTED] writes: AFAICS this patch breaks standalone backends, since the smarts involved in dealing with the new flavors of directory layouts were not taught to postgres.c. Hmm, I guess its time to get a CVS version of PG. This was originally done in 7.3 and migrated to 7.4. 7.5 is

Re: [PATCHES] [HACKERS] Configuration patch

2004-06-03 Thread pgsql
[EMAIL PROTECTED] writes: AFAICS this patch breaks standalone backends, since the smarts involved in dealing with the new flavors of directory layouts were not taught to postgres.c. Hmm, I guess its time to get a CVS version of PG. This was originally done in 7.3 and migrated to 7.4. 7.5

Re: [PATCHES] Doing psql's lexing with flex

2004-06-03 Thread Andrew Dunstan
Tom Lane wrote: I got interested enough in the psql-with-flex problem to go off and solve it. Attached is a working patch, which I'm now debating whether to apply. Comments solicited... The patch removes about 200 lines of very spaghetti-ish code in mainloop.c. However, it adds an 875-line

Re: [PATCHES] Add error-checking to timestamp_recv

2004-06-03 Thread Stephen Frost
* Tom Lane ([EMAIL PROTECTED]) wrote: I said: I'll make a note to do something with this issue after the TZ patch is in. I've applied a patch to take care of this problem. Great, thanks, much appriciated. I'll test once 7.5 goes beta. Stephen signature.asc Description: Digital

Re: [PATCHES] [HACKERS] Configuration patch

2004-06-03 Thread Bruce Momjian
[EMAIL PROTECTED] wrote: I wanted to create a generic facility for smarter configuration. Being able to create functions and pass parameters should allow smaller more focused configuration parsing. I don't believe include is a representative of a class; it seems a specialized

Re: [PATCHES] [HACKERS] Configuration patch

2004-06-03 Thread Tom Lane
Bruce Momjian [EMAIL PROTECTED] writes: One interesting idea would be for SET include to work like this: SET include '/var/run/xx' Notice there is no equals here. This would allow users to create files with various settings and enable them all with one SET command. However, this does

Re: [PATCHES] [HACKERS] Configuration patch

2004-06-03 Thread Andrew Dunstan
Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: In summary, I think we need to treat include specially in postgresql.conf (no equals) and remove it as an actual GUC parameter and just have it do includes immediately. (This will probably require special-casing it in the guc-file

Re: [PATCHES] NO WAIT ...

2004-06-03 Thread Tom Lane
Bruce Momjian [EMAIL PROTECTED] writes: Tom Lane wrote: Why? You can do a SELECT FOR UPDATE first and then you know that you have the row lock. There's no need for any special handling of UPDATE or DELETE. I don't see the applicability to VACUUM, either. Why bother when you can do it

Re: [PATCHES] small fix in FAQ

2004-06-03 Thread Bruce Momjian
Euler Taveira de Oliveira wrote: Hi, This is a small fix in FAQ. It just clean up some old comments and change an old -not-working piece of code. Please apply it in HEAD and 7.4 branch. Thanks. Patch applied to HEAD. We don't normally backpatch stuff like this to 7.4.X. -- Bruce

Re: [PATCHES] [HACKERS] pg_dump --comment?

2004-06-03 Thread Bruce Momjian
Jon Jensen wrote: On Fri, 28 May 2004, Christopher Kings-Lynne wrote: I've encountered a situation where I'd like to store some information about the database when I do a pg_dump. For instance, the timestamp of the dump. And some other information that I pull from the database.

Re: [PATCHES] [HACKERS] pg_dump --comment?

2004-06-03 Thread Tom Lane
Bruce Momjian [EMAIL PROTECTED] writes: The following patch adds start/stop times for pg_dump and pg_dumpall What happens in a pg_dump -Fc / pg_restore scenario? regards, tom lane ---(end of broadcast)--- TIP 1: subscribe