[PATCHES] Include tablespace information in psql \d footers

2004-06-24 Thread Gavin Sherry
Attached. There is no other way at the moment to get the tablespace name of an object in psql. We get information for tables, index, sequences and toast tables. We should probably do this for schemas too... GavinIndex: src/bin/psql/common.h

[PATCHES] pg_dump --clean w/ = 7.2 server

2004-06-24 Thread Kris Jurka
When running pg_dump --clean against a server that doesn't have schemas the namespace is blank and ends up producing a dump full off things like: DROP TABLE .tab; The attached patch only includes a schema if one exists. There are numerous comments about the DROPs needing to be fully qualified

Re: [PATCHES] pg_dump --clean w/ = 7.2 server

2004-06-24 Thread Christopher Kings-Lynne
When running pg_dump --clean against a server that doesn't have schemas the namespace is blank and ends up producing a dump full off things like: DROP TABLE .tab; Since the person is dumping using 7.5 pg_dump, presumably they will be restoring to 7.5, and it should be: DROP TABLE public.tab;

Re: [PATCHES] pg_dump --clean w/ = 7.2 server

2004-06-24 Thread Tom Lane
Christopher Kings-Lynne [EMAIL PROTECTED] writes: When running pg_dump --clean against a server that doesn't have schemas the namespace is blank and ends up producing a dump full off things like: DROP TABLE .tab; Since the person is dumping using 7.5 pg_dump, presumably they will be

Re: [PATCHES] pg_ctl service integration for WIN32

2004-06-24 Thread Tom Lane
Magnus Hagander [EMAIL PROTECTED] writes: Amended patch attached. Claudio Been testing this, and found a couple of small issues. Attached is a patch that fixes these. (Note - Claudios patch is included in this one, since it hasn't been applied yet..) Applied, but where's the documentation

Re: [PATCHES] Compiling libpq with VisualC

2004-06-24 Thread Tom Lane
Andreas Pflug [EMAIL PROTECTED] writes: elog.h is included in postgres.h, which is included in many src/port/*.c. Many of them are pretty straight, not requiring any backend specific stuff, so the attached patch will change postgres.h to c.h for most of them. Applied. I did the sys/time.h

Re: [PATCHES] initdb initial password from file

2004-06-24 Thread Tom Lane
Magnus Hagander [EMAIL PROTECTED] writes: Attached is a patch that adds the option --pwfile=3Dfilename to initdb. Applied with minor editorialization (printing the numeric errno isn't my idea of friendly...) regards, tom lane ---(end of

Re: [PATCHES] Cancel/Kill backend functions -- docs

2004-06-24 Thread Tom Lane
Magnus Hagander [EMAIL PROTECTED] writes: Here's at least some documentation about these. Applied. regards, tom lane ---(end of broadcast)--- TIP 7: don't forget to increase your free space map settings

Re: [PATCHES] nested xacts and phantom Xids

2004-06-24 Thread Simon Riggs
On Wed, 2004-06-23 at 13:57, Bruce Momjian wrote: I am sorry to have given Alvaro another idea that didn't work. No way! Keep having the ideas, please. I've done some more digging in dead time on all of this and I think we're on the right course in general by implementing all of this. ...well

Re: [PATCHES] stderr win32 admin check

2004-06-24 Thread Tom Lane
Magnus Hagander [EMAIL PROTECTED] writes: Attached is the updated version of this patch, which now includes proper testing for win32 service running. This is tested and verified with Claudios service wrapper pg_ctl patch (including the parts I added and sent in a short while ago). Applied.

Re: [PATCHES] pg_dump --clean w/ = 7.2 server

2004-06-24 Thread Kris Jurka
On Thu, 24 Jun 2004, Tom Lane wrote: Christopher Kings-Lynne [EMAIL PROTECTED] writes: When running pg_dump --clean against a server that doesn't have schemas the namespace is blank and ends up producing a dump full off things like: DROP TABLE .tab; Since the person is dumping

Re: [PATCHES] pg_dump --clean w/ = 7.2 server

2004-06-24 Thread Tom Lane
Kris Jurka [EMAIL PROTECTED] writes: Possibly the most correct solution is to assign the name public to the dummy schema that pg_dump creates internally when talking to a pre-7.3 server. I was considering that they might want to restore the dump into another schema and that would be easier

[PATCHES] Add argument name to CREATE FUNCTION documentation

2004-06-24 Thread Dennis Bjorklund
It's not much text, but someone who speaks english might want to look at it. If it's okay I can commit. -- /Dennis Björklund Index: doc/src/sgml/ref/create_function.sgml === RCS file:

Re: [PATCHES] nested xacts and phantom Xids

2004-06-24 Thread Alvaro Herrera
On Sun, Jun 20, 2004 at 08:49:22PM -0400, Tom Lane wrote: Regarding GUC, a WIP report: Given patches for inval.c and guc.c, I would say that the patch is functionally close enough to done that we could commit to including it in 7.5 --- the other stuff could be wrapped up post-feature-freeze.

Re: [PATCHES] Add argument name to CREATE FUNCTION documentation

2004-06-24 Thread Tom Lane
Dennis Bjorklund [EMAIL PROTECTED] writes: It's not much text, but someone who speaks english might want to look at it. Two trivial comments: 1. We usually leave spaces around brackets in syntax definitions, so I'd go for ... [ argname ] ... not ... [argname] ... Also, check that the

Re: [PATCHES] Add argument name to CREATE FUNCTION documentation

2004-06-24 Thread Dennis Bjorklund
On Thu, 24 Jun 2004, Tom Lane wrote: 1. We usually leave spaces around brackets in syntax definitions, so I'd go for ... [ argname ] ... not ... [argname] ... I saw both in that very rule (later there is an [EXTERNAL]) so I guessed that one use what looks best at different places. But

Re: [PATCHES] Add argument name to CREATE FUNCTION documentation

2004-06-24 Thread Tom Lane
Dennis Bjorklund [EMAIL PROTECTED] writes: On Thu, 24 Jun 2004, Tom Lane wrote: 1. We usually leave spaces around brackets in syntax definitions, so I'd go for ... [ argname ] ... not ... [argname] ... I saw both in that very rule (later there is an [EXTERNAL]) so I guessed that one use