Re: [PATCHES] plperl support for older perl versions

2004-07-04 Thread Christopher Kings-Lynne
Hmmm, It doesn't apply cleanly for me... Chris Andrew Dunstan wrote: Would people with older versions of perl ( 5.6 I think ) please try the attached patch against what is now on cvs for plperl, and let me know if it compiles, links and runs? (Thanks to Abhijit Menon-Sen for pointing me in the

Re: [PATCHES] [HACKERS] Compile failure in plperl

2004-07-04 Thread Andrew Dunstan
The problem is your old version of perl. Please see if the attached patch fixes it (The one I sent in previously didn't apply cleanly - this one should). thanks andrew Bruce Momjian wrote: I am getting a CVS HEAD compile failure in plperl: gmake[4]: Leaving directory

[PATCHES] plperl spi_exec_query patch

2004-07-04 Thread Andrew Dunstan
The following patch applies a change I inadvertantly left out of the previous patch, and makes spi_exec_query work correctly in the case of a select query. Test shows: CREATE TABLE test ( i int, v varchar ); CREATE TABLE INSERT INTO test (i, v) VALUES (1,'first line'); INSERT

Re: [PATCHES] [HACKERS] Compile failure in plperl

2004-07-04 Thread Bruce Momjian
Andrew Dunstan wrote: The problem is your old version of perl. Please see if the attached patch fixes it (The one I sent in previously didn't apply cleanly - this one should). With your patch I now get this failure: gmake[4]: Leaving directory

Re: [PATCHES] [HACKERS] Compile failure in plperl

2004-07-04 Thread Bruce Momjian
Andrew Dunstan wrote: That is *intensely* annoying. What on earth are these function bodies doing in a .h file anyway? (Remember, I just used the standard utility to generate the file). Anyway, here is a version with all that stuff cut out - I don't believe we need any of it. Does this

Re: [PATCHES] [HACKERS] Compile failure in plperl

2004-07-04 Thread Andrew Dunstan
Ok. It's impossible for me to fix this by remote control - I need access to some box with one of these old versions of perl so I can come up with a clean solution. Or did you revert the change that put #include ppport.h in SPI.xs? cheers andrew Bruce Momjian wrote: Andrew Dunstan wrote: That

Re: [PATCHES] [HACKERS] Compile failure in plperl

2004-07-04 Thread Bruce Momjian
Andrew has developed the following patch which allows Perl 5.05 to compile plperl. I have applied the patch because it is causing compile failures for testers. --- Andrew Dunstan wrote: Ok. It's impossible for me to fix