[PATCHES] pg_regress --temp-keep

2004-10-15 Thread Reini Urban
add boolean option --temp-keep to pg_regress to keep the existing tmp_check installation, instead of overwriting it with a fresh make install. Useful to test minor modifications in the current tmp_check installation. -- Reini Urban http://xarch.tu-graz.ac.at/home/rurban/ ***

Re: [PATCHES] pg_regress --temp-keep

2004-10-15 Thread Bruce Momjian
Uh, why would someone use this option? --- Reini Urban wrote: add boolean option --temp-keep to pg_regress to keep the existing tmp_check installation, instead of overwriting it with a fresh make install. Useful to

Re: [PATCHES] Cosmetic changes

2004-10-15 Thread Bruce Momjian
It seems Peter has already applied many of the cleanups you suggested. If you have more, would you download the snapshot and send in a new patch? Thanks. --- Euler Taveira de Oliveira wrote: Hi, This small patch correct

Re: [PATCHES] [PATCH] 5 plperl patches

2004-10-15 Thread Bruce Momjian
Patch applied. Thanks. --- Abhijit Menon-Sen wrote: I have attached 5 patches (split up for ease of review) to plperl.c. 1. Two minor cleanups: - We don't need to call hv_exists+hv_fetch; we should just check

Re: [PATCHES] pg_regress --temp-keep

2004-10-15 Thread Tom Lane
Reini Urban [EMAIL PROTECTED] writes: add boolean option --temp-keep to pg_regress to keep the existing tmp_check installation, instead of overwriting it with a fresh make install. Useful to test minor modifications in the current tmp_check installation. This doesn't seem like a

Re: [PATCHES] pg_regress --temp-keep

2004-10-15 Thread Reini Urban
Bruce Momjian schrieb: Uh, why would someone use this option? after fixing a minor issue, not to wait for a full de-install / install and test database loss. minor issues can be regression tests updates, or updated single binaries.

Re: [PATCHES] pg_regress --temp-keep

2004-10-15 Thread Bruce Momjian
Reini Urban wrote: Bruce Momjian schrieb: Uh, why would someone use this option? after fixing a minor issue, not to wait for a full de-install / install and test database loss. minor issues can be regression tests updates, or updated single binaries. Seems to be of too limited a usage.

Re: [PATCHES] pg_regress --temp-keep

2004-10-15 Thread Tom Lane
Reini Urban [EMAIL PROTECTED] writes: Bruce Momjian schrieb: Uh, why would someone use this option? after fixing a minor issue, not to wait for a full de-install / install and test database loss. minor issues can be regression tests updates, or updated single binaries. Personally I find

Re: [PATCHES] Slightly better testing for pg_ctl(1)'s -w...

2004-10-15 Thread Bruce Momjian
Patch applied. Thanks. I simplified your test and made the error message a #define that is now used consistently in all places. Patch attached. --- Sean Chittenden wrote: pg_ctl(1)'s -w option works well if the default

Re: [PATCHES] libpq.dll on win32

2004-10-15 Thread Bruce Momjian
Patch applied. Thanks. I fixed a few merge conflicts. --- Magnus Hagander wrote: *** src/interfaces/libpq/fe-secure.c 28 Sep 2004 00:06:02 -1.54 --- src/interfaces/libpq/fe-secure.c 11 Oct 2004 19:50:22

Re: [PATCHES] [CYGWIN] postgresql 8.0 with cygwin - success

2004-10-15 Thread Bruce Momjian
I did things a little differently. I #undef WIN32 after including windows.h on Cygwin and kept the defines the same except for the use of START. This makes things more consistent. Applied. --- Reini Urban wrote: Marek

Re: [PATCHES] [HACKERS] plperl Safe restrictions

2004-10-15 Thread Andrew Dunstan
David Helgason wrote: On 14. okt 2004, at 21:09, Andrew Dunstan wrote: It has just been brought to my attention that we are being very restrictive about what we allow to be done in trusted plperl. Basically we allow the :default and :base_math set of operations (run perldoc Opcode or see