Re: [PATCHES] Example of function returning SETOF RECORD

2004-10-22 Thread Tom Lane
David Fetter <[EMAIL PROTECTED]> writes: >> Here's a patch that adds an example of using SETOF RECORD with the >> needed grammar. I'm having a bit of a problem with this, because it is a plpgsql example inserted into a section that is solely about SQL-language functions. Can you adapt it to be an

Re: [PATCHES] initdb NLS on win32

2004-10-22 Thread Tom Lane
"Magnus Hagander" <[EMAIL PROTECTED]> writes: > This patch is required for initdb to work on win32 with NLS enabled. > Without it we get a segfault when trying to determine the current > locale, since we can't get it using LC_MESSAGES. Applied. regards, tom lane -

Re: [PATCHES] tsearch build on win32

2004-10-22 Thread Tom Lane
"Magnus Hagander" <[EMAIL PROTECTED]> writes: > This patch fixes the tsearch build problems reported by Andrew Dunstan. Applied. regards, tom lane ---(end of broadcast)--- TIP 2: you can get off all lists at once with the un

Re: [PATCHES] [HACKERS] ARC Memory Usage analysis

2004-10-22 Thread Simon Riggs
On Fri, 2004-10-22 at 21:45, Tom Lane wrote: > Jan Wieck <[EMAIL PROTECTED]> writes: > > What do you think about my other theory to make C actually 2x effective > > cache size and NOT to keep T1 in shared buffers but to assume T1 lives > > in the OS buffer cache? > > What will you do when initia

Re: [PATCHES] [HACKERS] ARC Memory Usage analysis

2004-10-22 Thread Jan Wieck
On 10/22/2004 4:21 PM, Simon Riggs wrote: On Fri, 2004-10-22 at 20:35, Jan Wieck wrote: On 10/22/2004 2:50 PM, Simon Riggs wrote: > > My proposal is to alter the code to allow an array of memory linked > lists. The actual list would be [0] - other additional lists would be > created dynamically a

Re: [PATCHES] [HACKERS] ARC Memory Usage analysis

2004-10-22 Thread Tom Lane
Jan Wieck <[EMAIL PROTECTED]> writes: > What do you think about my other theory to make C actually 2x effective > cache size and NOT to keep T1 in shared buffers but to assume T1 lives > in the OS buffer cache? What will you do when initially fetching a page? It's not supposed to go directly in

Re: [PATCHES] tsearch build on win32

2004-10-22 Thread Andrew Dunstan
Magnus Hagander wrote: This patch fixes the tsearch build problems reported by Andrew Dunstan. ... + ifneq (,$(findstring timezone,$(subdir))) + override CPPFLAGS+= -DBUILDING_DLL + endif That's all it took extra? Wow - easy when you know how! ;-) Thanks, Magnus. cheers andrew ---

[PATCHES] tsearch build on win32

2004-10-22 Thread Magnus Hagander
This patch fixes the tsearch build problems reported by Andrew Dunstan. I have confirmed that stop words work as expected now, so the fix that broke this part also works. If possible, please apply before beta-4. //Magnus tsearch_win32build.patch Description: tsearch_win32build.patch

Re: [PATCHES] [HACKERS] ARC Memory Usage analysis

2004-10-22 Thread Simon Riggs
On Fri, 2004-10-22 at 20:35, Jan Wieck wrote: > On 10/22/2004 2:50 PM, Simon Riggs wrote: > > > > > My proposal is to alter the code to allow an array of memory linked > > lists. The actual list would be [0] - other additional lists would be > > created dynamically as required i.e. not using IFD

[PATCHES] initdb NLS on win32

2004-10-22 Thread Magnus Hagander
This patch is required for initdb to work on win32 with NLS enabled. Without it we get a segfault when trying to determine the current locale, since we can't get it using LC_MESSAGES. If possible, please apply before beta-4. //Magnus <> initdb.win32nls.patch Description: initdb.win32nls.pat

Re: [PATCHES] [HACKERS] ARC Memory Usage analysis

2004-10-22 Thread Jan Wieck
On 10/22/2004 2:50 PM, Simon Riggs wrote: I've been using the ARC debug options to analyse memory usage on the PostgreSQL 8.0 server. This is a precursor to more complex performance analysis work on the OSDL test suite. I've simplified some of the ARC reporting into a single log line, which is encl

[PATCHES] ARC Memory Usage analysis

2004-10-22 Thread Simon Riggs
I've been using the ARC debug options to analyse memory usage on the PostgreSQL 8.0 server. This is a precursor to more complex performance analysis work on the OSDL test suite. I've simplified some of the ARC reporting into a single log line, which is enclosed here as a patch on freelist.c. This

Re: [PATCHES] code cleanup in dynahash.c

2004-10-22 Thread Neil Conway
Neil Conway wrote: This patch makes a minor code cleanup in dynahash.c: a function declared to return 'bool' only ever returned "true", so I changed it to return "void". Applied to HEAD. -Neil ---(end of broadcast)--- TIP 9: the planner will ignore yo

Re: [PATCHES] hash_create(): check return code

2004-10-22 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > On Fri, 2004-10-22 at 16:13, Tom Lane wrote: >> There are no places where hash_create is called before elog() is >> functional. > Well, it's invoked from the statistics collector, which avoids doing > elog(ERROR) for some reason. With all due respect to J

Re: [PATCHES] hash_create(): check return code

2004-10-22 Thread Neil Conway
On Fri, 2004-10-22 at 16:13, Tom Lane wrote: > There are no places where hash_create is called before elog() is > functional. Well, it's invoked from the statistics collector, which avoids doing elog(ERROR) for some reason. But my guess is that it should be workable to get elog(ERROR) / elog(FATAL