Re: [PATCHES] win32 cleanup

2004-11-17 Thread Neil Conway
On Sun, 2004-11-07 at 17:50 -0500, Andrew Dunstan wrote: The attached patch adds a few prototypes and does a typecast, thus removing some harmless but annoying compile warnings on Win32. Applied. -Neil ---(end of broadcast)--- TIP 8: explain

Re: [PATCHES] Win32 signals sockets

2004-11-17 Thread Magnus Hagander
This patch *replaces* the previous one. Contains the exact same changes, except it *also* contains the move of the backend parameter file to shared memory on win32. Committed with some small editorializing. Possibly the weight of my concern about further dividing the Unix and

Re: [PATCHES] Win32 signals sockets

2004-11-17 Thread Tom Lane
Magnus Hagander [EMAIL PROTECTED] writes: What's the recommended way to compile in Unix with exec_backend? I don't think we have a recommended way (or need one really). Personally I add #define EXEC_BACKEND to pg_config.h after configuring. Just to make sure I'm following you completely - you

Re: [PATCHES] Win32 signals sockets

2004-11-17 Thread Magnus Hagander
What's the recommended way to compile in Unix with exec_backend? I don't think we have a recommended way (or need one really). Personally I add #define EXEC_BACKEND to pg_config.h after configuring. Right. That's what I've been doing. Just need to be more careful checking the result of

Re: [PATCHES] pg_autovacuum vacuum cost variables patch v2

2004-11-17 Thread Tom Lane
Matthew T. O'Connor [EMAIL PROTECTED] writes: Ok, here is an updated version of the patch I submitted last night. This patch now sets the appropriate vacuum cost variables for both vacuum commands and analyze commands. In addition I have added the new vacuum cost options to the win32

Re: [PATCHES] contrib/tsearch2 missing LIBS

2004-11-17 Thread Tom Lane
Reini Urban [EMAIL PROTECTED] writes: my solution: --- postgresql-8.0.0beta4/src/Makefile.shlib.orig 2004-10-16 04:26:43.0 +0100 +++ postgresql-8.0.0beta4/src/Makefile.shlib 2004-10-27 13:21:19.184875000 +0100 @@ -219,7 +219,7 @@ ifeq ($(PORTNAME), cygwin) shlib

Re: [PATCHES] pgxs patch for win32 (v2)

2004-11-17 Thread Tom Lane
Fabien COELHO [EMAIL PROTECTED] writes: please find attached a very small patch which: - install win32 headers on make install - install libpostgres.a library under win32 by default (MAKE_DLL=true) - fix CPPFLAGS under win32 to look for these added header under PGXS Applied.

Re: [PATCHES] [HACKERS] cygwin build failure

2004-11-17 Thread Tom Lane
Reini Urban [EMAIL PROTECTED] writes: I'm just testing a new build from CVS with atttached patch. Patch applied. src/interfaces/ecpg/preproc: the .y and *.l files need to be touched and the generated .c/.h recompiled. They are outdated, at least on CVS. They don't exist in CVS.

Re: [PATCHES] [HACKERS] pg_arch.c call to sleep()

2004-11-17 Thread Tom Lane
Andrew Dunstan [EMAIL PROTECTED] writes: I take this as confirmation that calling pg_usleep is the Right Thing (tm). Here's the patch. Applied. regards, tom lane ---(end of broadcast)--- TIP 6: Have you searched our list

Re: [PATCHES] Small patch for regression tests

2004-11-17 Thread Tom Lane
Magnus Hagander [EMAIL PROTECTED] writes: Small patch for the regression tests: 1) Forcibly exports LANG=en. Just unsetting the languages won't work on win32, because it doesn't default to english (see lots of previous discussions when it was about the backend inheritance) Applied, but only

Re: [PATCHES] [HACKERS] pg_resetxlog options

2004-11-17 Thread Andrew Dunstan
Tom Lane wrote: Andrew Dunstan [EMAIL PROTECTED] writes: Why does pg_resetxlog seem top be the only one of our programs that has no long form options (or at least the only one that calls getopt rather than getopt_long)? Should we make it consistent with everything else? I think just

Re: [PATCHES] [HACKERS] pg_resetxlog options

2004-11-17 Thread Tom Lane
Andrew Dunstan [EMAIL PROTECTED] writes: Some other time maybe. Meanwhile, this patch ought to make it compile more cleanly on Windows - not sure why I get errors there but not Linux. The Single Unix Spec says that getopt() is supposed to be defined by unistd.h, but I guess reading the spec

Re: [PATCHES] [HACKERS] pg_resetxlog options

2004-11-17 Thread Peter Eisentraut
Andrew Dunstan wrote: Some other time maybe. Meanwhile, this patch ought to make it compile more cleanly on Windows - not sure why I get errors there but not Linux. Because getopt() is normally declared in unistd.h, not getopt.h (Windows being an exception?). -- Peter Eisentraut