[PATCHES] was: BUG #1466: syslogger issues

2005-02-21 Thread Andreas Pflug
Magnus Hagander wrote: There is special code in the send_message_to_server_log function to make sure it's written directly to the file. If the logger is complaining, it's quite possibly because it's unable to write to its file. Now that you mention it, doesn't this code go into infinite

Re: [PATCHES] Patch for disaster recovery

2005-02-21 Thread Richard Huxton
Bruce Momjian wrote: Tom Lane wrote: I think the only real effect of this patch will be to confuse people who are reading the source code. tqual.c is already complicated and fragile enough --- it doesn't need conditionally compiled features that we can't even explain the use of. I need a note

Re: [PATCHES] WIP: write flat files at startup, enforce XID wrap limit

2005-02-21 Thread Bruce Momjian
Tom Lane wrote: Comments? I personally think that this is too large a patch to risk committing into the 8.0 branch, but I suppose it depends on your level of concern about the XID wrap hazard. (The patch does appear to apply cleanly to the 8.0 branch, but I've not tested it there.) I'd

Re: [PATCHES] WIP: write flat files at startup, enforce XID wrap limit

2005-02-21 Thread Bruce Momjian
Tom Lane wrote: format of the pg_pwd and pg_group flat files: group membership has to be recorded in terms of user sysids not user names, so that we can avoid doing SysCache lookups in write_group_file. That's a This also expands the problems of reusing user ids for deleted users, but I agree

Re: [PATCHES] Change to -f in examples with input files

2005-02-21 Thread Bruce Momjian
David Fetter wrote: Please find enclosed a patch, per Dennis BjC3B6rklund, that uses -f for input files rather than . This makes error messages, c. more expressive. Uh, how is it more expressive? The only difference I see is the line numbers. Is that it? -- Bruce Momjian

Re: [PATCHES] Change to -f in examples with input files

2005-02-21 Thread David Fetter
On Mon, Feb 21, 2005 at 02:18:31PM -0500, Bruce Momjian wrote: David Fetter wrote: Please find enclosed a patch, per Dennis BjC3B6rklund, that uses -f for input files rather than . This makes error messages, c. more expressive. Uh, how is it more expressive? The only difference I

Re: [PATCHES] BUG #1466: syslogger issues

2005-02-21 Thread Magnus Hagander
There is special code in the send_message_to_server_log function to make sure it's written directly to the file. If the logger is complaining, it's quite possibly because it's unable to write to its file. Now that you mention it, doesn't this code go into infinite recursion if

Re: [PATCHES] Patch for disaster recovery

2005-02-21 Thread Simon Riggs
On Sun, 2005-02-20 at 13:08 -0500, Bruce Momjian wrote: Bruno Wolff III wrote: On Sun, Feb 20, 2005 at 09:43:11 -0500, Bruce Momjian pgman@candle.pha.pa.us wrote: We regularly have people on IRC who delete data and then want to recover it. That is (one of) the purpose(s) of

Re: [PATCHES] CSV multiline final fix

2005-02-21 Thread Andrew Dunstan
Andrew Dunstan wrote: Bruce Momjian said: Shame we had to duplicate CopyReadLine() in a sense. If you can find a clean way to merge them please do - I'll be very grateful. My head started to spin when I tried. In general I dislike having more than 2 or 2 levels of logic in a given piece

Re: [PATCHES] CSV multiline final fix

2005-02-21 Thread Bruce Momjian
Wow, that is significantly different. Thanks. Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches It will be applied as soon as one of the PostgreSQL committers reviews and approves it.