Re: [PATCHES] Display Pg buffer cache (WIP)

2005-03-06 Thread Neil Conway
Tom Lane wrote: It'd be possible to dispense with the per-buffer spinlocks so long as you look only at the tag (and perhaps the TAG_VALID flag bit). The tags can't be changing while you hold the BufMappingLock. That's what I had thought at first, but this comment in buf_internals.h dissuaded

Re: [PATCHES] Display Pg buffer cache (WIP)

2005-03-06 Thread Neil Conway
Only two things to add: you forgot to add `cachedump.o' to the list of OBJS in the utils/adt Makefile. Mark Kirkwood wrote: +typedef struct +{ + uint32 bufferid; + Oid relfilenode; + Oid reltablespace; + Oid

[PATCHES] Implementation of SQLCODE and SQLERRM variables for PL/pgSQL

2005-03-06 Thread Pavel Stehule
Hello This is my second patch, than please will be tolerant :-). For one my project I miss information about exception when I use EXCEPTION WITH OTHERS THEN. I found two Oracle's varaibles SQLCODE and SQLERRM which carry this information. With patch you can: -- -- Test of built variables

Re: [PATCHES] Cleaning up unreferenced table files

2005-03-06 Thread Tom Lane
Heikki Linnakangas [EMAIL PROTECTED] writes: On Sat, 5 Mar 2005, Tom Lane wrote: xlog.c is a fairly random place to put that functionality. Didn't it strike any warning bells for you when you had to add so many new #includes? I'm not entirely sure where this should go, but not there. Yeah

Re: [PATCHES] [HACKERS] Implementation of SQLCODE and SQLERRM variables for

2005-03-06 Thread Pavel Stehule
I think we discussed this last year and decided that it would be a bad idea to use those names because Oracle's use of them is not exactly compatible with our error codes and messages. SQLCODE in particular is not compatible at all --- it's an integer in Oracle, isn't it? There is more

Re: [PATCHES] Display Pg buffer cache (WIP)

2005-03-06 Thread Mark Kirkwood
Neil Conway wrote: Tom Lane wrote: It'd be possible to dispense with the per-buffer spinlocks so long as you look only at the tag (and perhaps the TAG_VALID flag bit). The tags can't be changing while you hold the BufMappingLock. That's what I had thought at first, but this comment in

Re: [PATCHES] Harmless space allocation typo

2005-03-06 Thread Neil Conway
Heikki Linnakangas wrote: Here's a tiny fix for a harmless typo in catalog.c Applied, thanks. -Neil ---(end of broadcast)--- TIP 5: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faq

Re: [PATCHES] Faster install-sh in C

2005-03-06 Thread Alvaro Herrera
On Fri, Mar 04, 2005 at 11:20:07AM +0100, Peter Eisentraut wrote: Am Freitag, 4. März 2005 01:11 schrieb Neil Conway: Alvaro Herrera wrote: I wrote an install program in C. It's supposed to replace the config/install-sh script, limited to the functionality we need, i.e. what is in