Re: [PATCHES] Minor Comment updates
Simon Riggs wrote: These are the only two files in /executor that have old QUEL comments in to describe their behaviour, AFAICS. Applied with some minor cleanups. Thanks for the patch. -Neil ---(end of broadcast)--- TIP 6: Have you searched our list archives? http://archives.postgresql.org
[PATCHES] trivial whitespace correction in es.po
Please apply the following patch to correct a small mistake in a translation file. cvs diff: Diffing src/bin/psql/po Index: src/bin/psql/po/es.po === RCS file: /home/alvherre/cvs/pgsql/src/bin/psql/po/es.po,v retrieving revision 1.7 diff -c -r1.7 es.po *** src/bin/psql/po/es.po 17 Jan 2005 14:55:34 - 1.7 --- src/bin/psql/po/es.po 24 Apr 2005 18:42:31 - *** *** 809,815 #, c-format msgid \\dp [PATTERN] list table, view, and sequence access privileges\n msgstr ! \\dp [PATRÓN]listar privilegios de acceso a tablas, vistas y secuencias\n #: help.c:228 #, c-format --- 809,815 #, c-format msgid \\dp [PATTERN] list table, view, and sequence access privileges\n msgstr ! \\dp [PATRÓN]listar privilegios de acceso a tablas, vistas y secuencias\n #: help.c:228 #, c-format -- Alvaro Herrera (alvherre[a]dcc.uchile.cl) La espina, desde que nace, ya pincha (Proverbio africano) ---(end of broadcast)--- TIP 7: don't forget to increase your free space map settings
Re: [PATCHES] revise a comment in CreateCheckPoint()
Tom Lane [EMAIL PROTECTED] writes I thought your version was even more so :-(. I've applied the attached patch instead. That's too bad :-( but the happy part is that it is fixed now. Regards, Qingqing ---(end of broadcast)--- TIP 8: explain analyze is your friend
Re: [PATCHES] Cleaning up unreferenced table files
Tom Lane wrote: Heikki Linnakangas [EMAIL PROTECTED] writes: On Sat, 5 Mar 2005, Tom Lane wrote: xlog.c is a fairly random place to put that functionality. Didn't it strike any warning bells for you when you had to add so many new #includes? I'm not entirely sure where this should go, but not there. Yeah actually it did, but I forgot about it along the way. How about putting it in a file of its own in backend/catalog? There's some code that also deals with the data directories. Or straight into backend/storage. Actually, you could make some case for putting it in utils/init/ beside flatfiles.c, which has got much the same sort of issues to deal with. I think though that we ought to first consider the question of whether we *want* this functionality. On reflection I'm fairly nervous about the idea of actually deleting anything during startup --- seems like a good recipe for turning small failures into large failures. But if we're not going to delete anything then it's questionable whether we need to code it like this at all. It'd certainly be easier and safer to examine these tables after the system is up and running normally. Let's discuss this. The patch as submitted checks for unreferenced files on bootup and reports them in the log file, but does not delete them. That seems like the proper behavior. I think we delete from pgsql_tmp on bootup, but we _know_ those aren't referenced. What other user interface would trigger this if we did it after startup? Wouldn't we have to lock pg_class against VACUUM while we scan the file system, and are we sure we do things in pg_class or the file system first consistently? It seems much more prone to error doing it while the system is running. I guess I am happy with just reporting during startup like the patch does now. -- Bruce Momjian| http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup.| Newtown Square, Pennsylvania 19073 ---(end of broadcast)--- TIP 8: explain analyze is your friend
