This patch improves the win32 CHECK_FOR_INTERRUPTS() performance by
testing if any unblocked signals are queued before check
pgwin32_signal_event. This avoids an unnecessary system call.
Regards,
Qingqing
---
Index: backend/port/win32/signal.c
===
On Thu, 2005-20-10 at 20:03 -0400, Tom Lane wrote:
> If we were going to change it, I'd favor current_timestamp over
> either Postgres-ism.
Committed.
-Neil
---(end of broadcast)---
TIP 9: In versions below 8.0, the planner will ignore your desir
On Thu, Oct 20, 2005 at 08:03:13PM -0400, Tom Lane wrote:
> David Fetter <[EMAIL PROTECTED]> writes:
> > Please find enclosed a patch that fixes the trigger example in plpgsql
> > (emp_stamp).
>
> Uh ... that example is not broken.
>
> If we were going to change it, I'd favor current_timestamp ov
David Fetter <[EMAIL PROTECTED]> writes:
> Please find enclosed a patch that fixes the trigger example in plpgsql
> (emp_stamp).
Uh ... that example is not broken.
If we were going to change it, I'd favor current_timestamp over
either Postgres-ism.
regards, tom lane
Folks,
Please find enclosed a patch that fixes the trigger example in plpgsql
(emp_stamp).
Cheers,
D
--
David Fetter [EMAIL PROTECTED] http://fetter.org/
phone: +1 510 893 6100 mobile: +1 415 235 3778
Remember to vote!
Index: doc/src/sgml/plpgsql.sgml
=
On Thu, Oct 20, 2005 at 12:30:27PM -0400, Tom Lane wrote:
> "Matthew T. O'Connor" writes:
> > Tom Lane wrote:
> >> Surely this is completely broken? AFAICT you are testing the result
> >> from a VACUUM or ANALYZE command, which is not going to return any
> >> tuples.
>
> > Upon further inspectio
IBM has addressed the socket address storage issue as of AIX 5.3
maintenance level 5300-03; the following patch adds documentation to
FAQ_AIX...
[EMAIL PROTECTED]:OXRS/sources/pgsql-HEAD/doc> cvs diff -u FAQ_AIX
Thursday 12:22:5
Tom Lane wrote:
daveg <[EMAIL PROTECTED]> writes:
Below is a patch for this that should apply against any 8.0.x. The change
verifies that the catalog query returned some rows before accessing the row
data.
Surely this is completely broken? AFAICT you are testing the result
from a V
"Matthew T. O'Connor" writes:
> Tom Lane wrote:
>> Surely this is completely broken? AFAICT you are testing the result
>> from a VACUUM or ANALYZE command, which is not going to return any
>> tuples.
> Upon further inspection, I think you are right. I would think that
> instead of checking the
Tom Lane wrote:
daveg <[EMAIL PROTECTED]> writes:
Below is a patch for this that should apply against any 8.0.x. The change
verifies that the catalog query returned some rows before accessing the row
data.
Surely this is completely broken? AFAICT you are testing the result
from a VACU
daveg <[EMAIL PROTECTED]> writes:
> Below is a patch for this that should apply against any 8.0.x. The change
> verifies that the catalog query returned some rows before accessing the row
> data.
Surely this is completely broken? AFAICT you are testing the result
from a VACUUM or ANALYZE command,
Small nit: please observe postgres community conventions regarding
a) indentation (BSD style, tabsize 4) and
b) diff type (context, not unidiff)
The patch itself looks ok to me.
cheers
andrew
daveg wrote:
Apologies if this is old news, but pg_autovacuum in 8.0.x has the bad habit
of SEGVin
Looks reasonable to me. All the patch does is make sure that the result
set is valid. Probably a check I should have done from the beginning,
or pg _autovacuum should be locking tables to make sure they aren't
dropped, but that sounds too intrusive, this is probably better.
Matt
daveg wro
Volkan YAZICI <[EMAIL PROTECTED]> writes:
> This is the 4th time sending this patch. Hope this one succeeds.
Applied along with some further fixes --- it's best not to use palloc
at all in this code, since that just encourages errors like this one.
regards, tom lane
-
Apologies if this is old news, but pg_autovacuum in 8.0.x has the bad habit
of SEGVing and exiting when a table gets dropped out from under it. This
creates problems if you rely on pg_autovacuum for the bulk of your vacuuming
as it forgets it's statistics when it is restarted and so will skip some
This is the 4th time sending this patch. Hope this one succeeds.
Index: md5.c
===
RCS file: /projects/cvsroot/pgsql/src/backend/libpq/md5.c,v
retrieving revision 1.30
diff -u -r1.30 md5.c
--- md5.c 17 Oct 2005 16:24:19 -
16 matches
Mail list logo