Re: [PATCHES] return can contains any row or record functions

2005-11-09 Thread Pavel Stehule
- we can't use estate->rsi for the RETURN case, at least as presently implemented, because that is not always filled-out -- the example I gave before shows how because we don't check for a compatible TupleDesc when estate->rsi is NULL, we end up returning a value that is incompatible with the fu

Re: [PATCHES] return can contains any row or record functions

2005-11-09 Thread Neil Conway
On Tue, 2005-08-11 at 08:55 +0100, Pavel Stehule wrote: > Sorry for my ugly english. Sorry, I didn't understand your reply. The problem is this: - we need to find the TupleDesc of the function's expected return type for tuple-returning functions - we can't use estate->rsi for the RETURN case, a

Re: [PATCHES] Trivial permission problem with external-projects.sgml / and a typo in postgresql.conf.sample

2005-11-09 Thread Tom Lane
Devrim GUNDUZ <[EMAIL PROTECTED]> writes: > - - The external-projects.sgml file has +x permissions unlike the other > files. Could you please fix it so that RPM checks won't compile? A "find" turned up several other files that have +x and should not. I removed +x permissions from all of these: c

Re: [PATCHES] Front-end libpq library : Extending PQconnectdb functionnalities to PQsetdbLogin

2005-11-09 Thread Tom Lane
[EMAIL PROTECTED] writes: > This patch to fe-connect.c is intended > to make it possible to set options like sslmode > or connect_timeout with the PQsetdbLogin() function. This seems spectacularly ugly :-(. Why don't you lobby ECPG to provide a more modern connection API, instead?

[PATCHES] Trivial permission problem with external-projects.sgml / and a typo in postgresql.conf.sample

2005-11-09 Thread Devrim GUNDUZ
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, - - The external-projects.sgml file has +x permissions unlike the other files. Could you please fix it so that RPM checks won't compile? - - ... and the attached patch fixes a trivial typo in postgresql.conf.sample. Regards, - -- Devrim GU

[PATCHES] Front-end libpq library : Extending PQconnectdb functionnalities to PQsetdbLogin

2005-11-09 Thread waldem
PQsetdbLogin() in fe-connect.c in libpq - PQsetdbLogin OPTIONS EXTENSION PATCH - This patch to fe-connect.c is intended to make it possible to set options like sslmode or connect_timeout with the PQsetdbLogin() function. This is needed as many popular interfaces or routines (i.e. ECPG

Re: [PATCHES] Improve the comparison of NUMERIC data

2005-11-09 Thread Tom Lane
Atsushi Ogawa <[EMAIL PROTECTED]> writes: > 2005/11/9, Tom Lane <[EMAIL PROTECTED]>: >> Rather than trying to share code, it'd likely be better to make a >> separate routine that can directly compare two values in the packed >> (on-disk) representation, and modify the externally-callable entry >> p

Re: [PATCHES] Improve the comparison of NUMERIC data

2005-11-09 Thread Atsushi Ogawa
2005/11/9, Tom Lane <[EMAIL PROTECTED]>: > Atsushi Ogawa <[EMAIL PROTECTED]> writes: > > An attached patch enables the comparison of Numeric values without > > executing conversion to NumericVar. > > Rather than trying to share code, it'd likely be better to make a > separate routine that can direc