Re: [PATCHES] TupleDesc refcounting

2006-01-16 Thread Neil Conway
On Sun, 2006-01-15 at 12:08 -0500, Tom Lane wrote: > My inclination at this point is to forget the whole thing and just patch > the callers of lookup_rowtype_tupdesc that need to copy the tupdesc. Actually, I think I finally understand how to implement this patch sanely. I had thought that the lif

Re: [PATCHES] patch to create system view that lists cursors

2006-01-16 Thread Neil Conway
On Sun, 2006-01-15 at 17:57 -0500, Neil Conway wrote: > I think the view should include the portals created by DECLARE CURSOR > and "Bind" protocol messages, but should not include the unnamed portal > or any other portals that are created internally as part of the > implementation of other command

Re: [PATCHES] Index padding optimization

2006-01-16 Thread ITAGAKI Takahiro
Tom Lane <[EMAIL PROTECTED]> wrote: > This seems extremely invasive for a relatively small gain :-( > The example you cite of an int4 index on a MAXALIGN-8 machine is > by far the best case, and in many cases there wouldn't be anything > bought by the extra complexity. I also think that it has sm

[PATCHES] ISBN-13 support

2006-01-16 Thread Benjamin Wragg
Hi,   I have been searching for information on postgresql support of the new isbn-13 standard. I have used the isbn_issn extension in the contrib directory but I don't believe that it supports the new isbn-13 standard. I'm not a C programmer so can't work on the isbn_issn extension myself, b

Re: [PATCHES] [HACKERS] message for constraint

2006-01-16 Thread Alvaro Herrera
Jaime Casanova wrote: > On 1/16/06, Bruce Momjian wrote: > what about lower the context part of the messages for plpgsql > functions? that seems debug info for me... just an idea ;) > > pruebas=# select prueba(); > ERROR: new row for relation "foo" violates check constraint "foo_fld_check" > CO

Re: [PATCHES] [HACKERS] message for constraint

2006-01-16 Thread Tom Lane
Jaime Casanova <[EMAIL PROTECTED]> writes: > ok... maybe notice? log? i suppose that the ERROR line is error level > so the idea is lowering the context so i can put > client_min_messages='error' and see just what the user can > understand... If you don't want to show the context field, build you

Re: [PATCHES] [HACKERS] message for constraint

2006-01-16 Thread Jaime Casanova
On 1/16/06, Alvaro Herrera <[EMAIL PROTECTED]> wrote: > Jaime Casanova wrote: > > On 1/16/06, Bruce Momjian wrote: > > > what about lower the context part of the messages for plpgsql > > functions? that seems debug info for me... just an idea ;) > > > > pruebas=# select prueba(); > > ERROR: new r

Re: [PATCHES] [HACKERS] message for constraint

2006-01-16 Thread Jaime Casanova
On 1/16/06, Bruce Momjian wrote: > > I have added the following documentation addition to suggest this usage > for constraint names. > > --- > > --- 293,304 > CONSTRAINT class="PARAMETER">constraint_name > >

Re: [PATCHES] [HACKERS] message for constraint

2006-01-16 Thread Bruce Momjian
I have added the following documentation addition to suggest this usage for constraint names. --- Jaime Casanova wrote: > On 1/14/06, Peter Eisentraut <[EMAIL PROTECTED]> wrote: > > Jaime Casanova wrote: > > > From time to t

Re: [PATCHES] New pg_dump options: exclude tables/schemas, multiple all, wildcards

2006-01-16 Thread Alvaro Herrera
Greg Sabino Mullane wrote: > Attached is a patch to hopefully make pg_dump a lot more useful. > I started out by making it simply able to avoid dumping a single > table, but, inspired by David Fetter's patch last November, also > added in support for multiple items and limited wildcard matching.