Re: [PATCHES] [BUGS] BUG #2221: Bad delimiters allowed in COPY ...

2006-01-30 Thread Andrew Dunstan
David Fetter wrote: + /* Disallow BADCHARS characters */ + if (strcspn(cstate-delim, BADCHARS) != 1) + ereport(ERROR, + (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), +errmsg(COPY delimiter cannot be \%#02x\, +

Re: [PATCHES] Patch for ALTER TABLE / TYPE

2006-01-30 Thread Tom Lane
NAKANO Yoshihisa [EMAIL PROTECTED] writes: Tom Lane wrote: After looking at the test case a bit, I have an alternate approach: constraints on the column will have DEPENDENCY_AUTO type, while constraints using the column will have DEPENDENCY_NORMAL type. O.K. It seems nicer than my solution.

Re: [PATCHES] [BUGS] BUG #2221: Bad delimiters allowed in COPY ...

2006-01-30 Thread David Fetter
On Mon, Jan 30, 2006 at 08:21:34AM -0500, Andrew Dunstan wrote: David Fetter wrote: +/* Disallow BADCHARS characters */ +if (strcspn(cstate-delim, BADCHARS) != 1) +ereport(ERROR, +(errcode(ERRCODE_FEATURE_NOT_SUPPORTED), +

Re: [PATCHES] BTree vacuum before page splitting

2006-01-30 Thread Junji TERAMOTO
Tom Lane wrote: I think this is quite likely to break things :-(. What sort of conditions have you tested it under? (If this were safe, we'd not have invented the LP_DELETE flag to begin with, but just have deleted known-dead items immediately.) I apologize for my insufficient