[PATCHES] BUG #2246: Only call pg_fe_getauthname if none given

2006-02-15 Thread Stephen Frost
* Tom Lane ([EMAIL PROTECTED]) wrote: Right offhand I like the idea of pushing it into connectOptions2 --- can you experiment with that? Seems like there is no reason to call Kerberos if the user supplies the name to connect as. Patch attached. After looking through the code around this I

Re: [PATCHES] BUG #2246: Only call pg_fe_getauthname if none given

2006-02-15 Thread Tom Lane
Stephen Frost [EMAIL PROTECTED] writes: * Tom Lane ([EMAIL PROTECTED]) wrote: Right offhand I like the idea of pushing it into connectOptions2 --- can you experiment with that? Seems like there is no reason to call Kerberos if the user supplies the name to connect as. Patch attached. After

Re: [PATCHES] BUG #2246: Only call pg_fe_getauthname if none given

2006-02-15 Thread Stephen Frost
* Tom Lane ([EMAIL PROTECTED]) wrote: This is probably not a good idea --- changing the API behavior in pursuit of saving a few cycles is just going to get people mad at us. Fair enough. I think we'd have to refactor the code so that PQsetdbLogin gets a PQconninfoOption array, overrides

Re: [PATCHES] patch fixing the old RETURN NEXT bug

2006-02-15 Thread Sergey E. Koposov
On Sun, 12 Feb 2006, Tom Lane wrote: Sergey E. Koposov [EMAIL PROTECTED] writes: The problem with that is in fact in pl_exec.c in function compatible_tupdesc(), which do not check for the deleted attributes. Is that really the only problem? Tom, Are there any problems with that patch to

Re: [PATCHES] patch fixing the old RETURN NEXT bug

2006-02-15 Thread Tom Lane
Sergey E. Koposov [EMAIL PROTECTED] writes: Are there any problems with that patch to not be applied ? Hasn't been reviewed yet ... see nearby discussions about shortage of patch reviewers ... (Sorry if I'm hurrying) At the moment it's not unusual for nontrivial patches to sit around for a

[PATCHES] constant too large in port/gettimeofday

2006-02-15 Thread Kris Jurka
This patch fixes this warning. gettimeofday.c:35: warning: integer constant is too large for long type Kris Jurka Index: src/port/gettimeofday.c === RCS file: /projects/cvsroot/pgsql/src/port/gettimeofday.c,v retrieving

Re: [PATCHES] [HACKERS] Patch Submission Guidelines

2006-02-15 Thread Robert Treat
On Tuesday 14 February 2006 20:42, Robert Treat wrote: On Tuesday 14 February 2006 16:00, Martijn van Oosterhout wrote: I would like to suggest that we increase substantially the FAQ entries relating to patch submission. By we, I actually mean please could the committers sit down and

Re: [PATCHES] [HACKERS] Patch Submission Guidelines

2006-02-15 Thread Tom Lane
Robert Treat [EMAIL PROTECTED] writes: As stated, the following patch adds a list of patch submission guidelines based on Simon Riggs suggestions to the developers FAQ. A couple minor comments ... ! liEnsure that your patch is generated against the most recent version !