Re: [PATCHES] WIP: further sorting speedup

2006-02-20 Thread Michael Glaesemann
On Feb 21, 2006, at 14:24 , Tom Lane wrote: Michael Glaesemann <[EMAIL PROTECTED]> writes: Most of this is way above my head, but I'm trying to follow along: Right, it's whatever is the sort key for this particular sort. Thanks, Tom. I think I may actually be starting to understand this

Re: [PATCHES] WIP: further sorting speedup

2006-02-20 Thread Tom Lane
Michael Glaesemann <[EMAIL PROTECTED]> writes: > Most of this is way above my head, but I'm trying to follow along: > when you say first key and full key, are these related to relation > keys (e.g., primary key) or attributes that are used in sorting > (regardless of whether they're a key or

Re: [PATCHES] WIP: further sorting speedup

2006-02-20 Thread Michael Glaesemann
On Feb 21, 2006, at 3:45 , Simon Riggs wrote: On Sun, 2006-02-19 at 21:40 -0500, Tom Lane wrote: After applying Simon's recent sort patch, I was doing some profiling and noticed that sorting spends an unreasonably large fraction of its time extracting datums from tuples (heap_getattr or in

Re: [PATCHES] win codepages 1253, 1254, 1255, 1257 and cleanup

2006-02-20 Thread Kris Jurka
On Sat, 18 Feb 2006, Peter Eisentraut wrote: Kris Jurka wrote: The attached patch adds support for windows codepages 1253, 1254, 1255, and 1257 and cleans up a bunch of the support utilities. I've applied this patch but left out the changes to the Japanese encoding maps, as you suggested.

Re: [PATCHES] [PATCH] WIP: Create shell-types explicitly

2006-02-20 Thread Tom Lane
Martijn van Oosterhout writes: > On Mon, Feb 20, 2006 at 10:13:39AM -0500, Tom Lane wrote: >> Martijn van Oosterhout writes: >>> The first line creates public.text, but the drop tries to delete >>> pg_catalog.text. >> >> This is not particularly specific to (or relevant to) shell types. > So thi

Re: [PATCHES] [PATCH] WIP: Create shell-types explicitly

2006-02-20 Thread Martijn van Oosterhout
On Mon, Feb 20, 2006 at 10:13:39AM -0500, Tom Lane wrote: > Martijn van Oosterhout writes: > > The first line creates public.text, but the drop tries to delete > > pg_catalog.text. > > This is not particularly specific to (or relevant to) shell types. So this is not a show stopper and not someth

Re: [PATCHES] plpython: fix memory leak

2006-02-20 Thread Neil Conway
On Sun, 2006-02-19 at 20:34 -0500, Neil Conway wrote: > Attached is a patch that fixes three Python reference leaks in > PLy_traceback(): the objects returned by PyErr_Fetch() are owned by the > caller, so their reference count should be decremented. Applied to HEAD and back branches. I also notic

Re: [PATCHES] WIP: further sorting speedup

2006-02-20 Thread Simon Riggs
On Sun, 2006-02-19 at 21:40 -0500, Tom Lane wrote: > After applying Simon's recent sort patch, I was doing some profiling and > noticed that sorting spends an unreasonably large fraction of its time > extracting datums from tuples (heap_getattr or index_getattr). The > attached patch does somethin

Re: [PATCHES] pgcrypto: fix memory leak in openssl.c

2006-02-20 Thread Marko Kreen
On 2/20/06, Tom Lane <[EMAIL PROTECTED]> wrote: > "Marko Kreen" <[EMAIL PROTECTED]> writes: > > On 2/18/06, Marko Kreen <[EMAIL PROTECTED]> wrote: > >> pgcrypto crypt()/md5 and hmac() leak memory when compiled against > >> OpenSSL as openssl.c digest ->reset will do two DigestInit calls > >> agains

Re: [PATCHES] [PATCH] WIP: Create shell-types explicitly

2006-02-20 Thread Tom Lane
Martijn van Oosterhout writes: > The first line creates public.text, but the drop tries to delete > pg_catalog.text. This is not particularly specific to (or relevant to) shell types. regards, tom lane ---(end of broadcast)

Re: [PATCHES] pgcrypto: fix memory leak in openssl.c

2006-02-20 Thread Tom Lane
"Marko Kreen" <[EMAIL PROTECTED]> writes: > On 2/18/06, Marko Kreen <[EMAIL PROTECTED]> wrote: >> pgcrypto crypt()/md5 and hmac() leak memory when compiled against >> OpenSSL as openssl.c digest ->reset will do two DigestInit calls >> against a context. This happened to work with OpenSSL 0.9.6 >>

Re: [PATCHES] pgcrypto: fix memory leak in openssl.c

2006-02-20 Thread Marko Kreen
On 2/18/06, Marko Kreen <[EMAIL PROTECTED]> wrote: > pgcrypto crypt()/md5 and hmac() leak memory when compiled against > OpenSSL as openssl.c digest ->reset will do two DigestInit calls > against a context. This happened to work with OpenSSL 0.9.6 > but not with 0.9.7+. Ugh, seems I read the old

[PATCHES] [PATCH] WIP: Create shell-types explicitly

2006-02-20 Thread Martijn van Oosterhout
[Please CC any replies, thanks] Persuant to the recent discussion, here is a patch to allow users to create shell types by using the symtax: CREATE TYPE foo; It was actually much easier than I thought given that normal type creation creates a shell type just before creating the real type. This m