Re: [PATCHES] Have psql display names and OUT/INOUT in \df output
On Sat, Jul 15, 2006 at 04:42:50PM -0700, David Fetter wrote:
> Folks,
>
> This patch makes psql's \df display functions with the names of
> parameters and OUT/INOUT if appropriate. Should there be a
> regression test for this? A doc patch?
As this doesn't change any documented behavior, it doesn't look like
there is space for a doc patch.
Anyhow, please find enclosed the context-style diff. Sorry about the
mix-up earlier :)
Cheers,
D
--
David Fetter <[EMAIL PROTECTED]> http://fetter.org/
phone: +1 415 235 3778AIM: dfetter666
Skype: davidfetter
Remember to vote!
Index: src/bin/psql/describe.c
===
RCS file: /projects/cvsroot/pgsql/src/bin/psql/describe.c,v
retrieving revision 1.140
diff -c -r1.140 describe.c
*** src/bin/psql/describe.c 14 Jun 2006 16:49:02 - 1.140
--- src/bin/psql/describe.c 16 Jul 2006 06:10:10 -
***
*** 170,177
"SELECT n.nspname as \"%s\",\n"
" p.proname as \"%s\",\n"
" CASE WHEN p.proretset THEN 'setof
' ELSE '' END ||\n"
! " pg_catalog.format_type(p.prorettype, NULL)
as \"%s\",\n"
! "
pg_catalog.oidvectortypes(p.proargtypes) as \"%s\"",
_("Schema"), _("Name"), _("Result
data type"),
_("Argument data types"));
--- 170,198
"SELECT n.nspname as \"%s\",\n"
" p.proname as \"%s\",\n"
" CASE WHEN p.proretset THEN 'setof
' ELSE '' END ||\n"
! "
pg_catalog.format_type(p.prorettype, NULL) as \"%s\",\n"
! " CASE WHEN proallargtypes IS NOT
NULL THEN\n"
! "array_to_string(ARRAY(\n"
! " SELECT\n"
! "CASE\n"
! " WHEN p.proargmodes[s.i] =
'i' THEN ''\n"
! " WHEN p.proargmodes[s.i] =
'o' THEN ' OUT '\n"
! " WHEN p.proargmodes[s.i] =
'b' THEN ' INOUT '\n"
! "END ||\n"
! "COALESCE(p.proargnames[s.i]
|| ' ','') ||\n"
! "
format_type(p.proallargtypes[s.i],-1)\n"
! " FROM\n"
! "
generate_series(1,array_upper(p.proallargtypes,1)) AS s(i)\n"
! "), ',')\n"
! " ELSE\n"
! "array_to_string(ARRAY(\n"
! " SELECT\n"
! "
COALESCE(p.proargnames[s.i+1] || ' ', '') ||\n"
! "
format_type(p.proargtypes[s.i],-1)\n"
! " FROM\n"
! "
generate_series(0,array_upper(p.proargtypes,1)) AS s(i)\n"
! "), ',')\n"
! " END AS \"%s\"",
_("Schema"), _("Name"), _("Result
data type"),
_("Argument data types"));
---(end of broadcast)---
TIP 1: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to [EMAIL PROTECTED] so that your
message can get through to the mailing list cleanly
Re: [PATCHES] PostmasterHandl_patch of win32
From: "Tom Lane" "Hiroshi Saito" <[EMAIL PROTECTED]> writes: Probably, this application will be required. This seems very messy. The correct fix is just to put back the #include line, no? @@ -18,6 +18,7 @@ #include #include "miscadmin.h" +#include "postmaster/postmaster.h" #include "storage/pmsignal.h" #include "storage/shmem.h" Ahh.., include by which you were committed is very good. Thanks.! Regards, Hiroshi Saito ---(end of broadcast)--- TIP 4: Have you searched our list archives? http://archives.postgresql.org
Re: [PATCHES] PostmasterHandl_patch of win32
"Hiroshi Saito" <[EMAIL PROTECTED]> writes: > Probably, this application will be required. This seems very messy. The correct fix is just to put back the #include line, no? regards, tom lane ---(end of broadcast)--- TIP 2: Don't 'kill -9' the postmaster
Re: [PATCHES] Have psql display names and OUT/INOUT in \df output
David Fetter wrote: Folks, This patch makes psql's \df display functions with the names of parameters and OUT/INOUT if appropriate. Should there be a regression test for this? A doc patch? Regression tests are for server functionality, generally. Possibly docs should be patched. cheers andrew ---(end of broadcast)--- TIP 1: if posting/reading through Usenet, please send an appropriate subscribe-nomail command to [EMAIL PROTECTED] so that your message can get through to the mailing list cleanly
[PATCHES] PostmasterHandl_patch of win32
Hi Bruce-san. Uga..., include is removed and it is out of order. pmsignal.c: In function `PostmasterIsAlive': pmsignal.c:121: error: `PostmasterHandle' undeclared (first use in this function) pmsignal.c:121: error: (Each undeclared identifier is reported only once pmsignal.c:121: error: for each function it appears in.) make[4]: *** [pmsignal.o] Error 1 make[3]: *** [ipc-recursive] Error 2 make[2]: *** [storage-recursive] Error 2 make[1]: *** [all] Error 2 make: *** [all] Error 2 Probably, this application will be required. P.S) In addition, there are some problems. It is corrected soon. Regards, Hiroshi Saito PostmasterHandl_patch Description: Binary data ---(end of broadcast)--- TIP 5: don't forget to increase your free space map settings
[PATCHES] Have psql display names and OUT/INOUT in \df output
Folks, This patch makes psql's \df display functions with the names of parameters and OUT/INOUT if appropriate. Should there be a regression test for this? A doc patch? Cheers, D -- David Fetter <[EMAIL PROTECTED]> http://fetter.org/ phone: +1 415 235 3778AIM: dfetter666 Skype: davidfetter Remember to vote! Index: src/bin/psql/describe.c === RCS file: /projects/cvsroot/pgsql/src/bin/psql/describe.c,v retrieving revision 1.140 diff -r1.140 describe.c 173,174c173,195 < " pg_catalog.format_type(p.prorettype, NULL) as \"%s\",\n" < " pg_catalog.oidvectortypes(p.proargtypes) as \"%s\"", --- > " > pg_catalog.format_type(p.prorettype, NULL) as \"%s\",\n" > " CASE WHEN proallargtypes IS NOT > NULL THEN\n" > "array_to_string(ARRAY(\n" > " SELECT\n" > "CASE\n" > " WHEN p.proargmodes[s.i] = > 'i' THEN ''\n" > " WHEN p.proargmodes[s.i] = > 'o' THEN ' OUT '\n" > " WHEN p.proargmodes[s.i] = > 'b' THEN ' INOUT '\n" > "END ||\n" > "COALESCE(p.proargnames[s.i] > || ' ','') ||\n" > " > format_type(p.proallargtypes[s.i],-1)\n" > " FROM\n" > " > generate_series(1,array_upper(p.proallargtypes,1)) AS s(i)\n" > "), ',')\n" > " ELSE\n" > "array_to_string(ARRAY(\n" > " SELECT\n" > " > COALESCE(p.proargnames[s.i+1] || ' ', '') ||\n" > " > format_type(p.proargtypes[s.i],-1)\n" > " FROM\n" > " > generate_series(0,array_upper(p.proargtypes,1)) AS s(i)\n" > "), ',')\n" > " END AS \"%s\"", ---(end of broadcast)--- TIP 1: if posting/reading through Usenet, please send an appropriate subscribe-nomail command to [EMAIL PROTECTED] so that your message can get through to the mailing list cleanly
