Re: [PATCHES] [HACKERS] Interval aggregate regression failure (expected seems

2006-08-29 Thread Michael Glaesemann
I think I've got it. I plan to update the regression tests this evening, but I wanted to post what I believe is a solution. select '41 mon'::interval / 10; ?column? --- 4 mons 3 days (1 row) select '41 mon 360:00'::interval / 10 as pos , '-41 mon -360:00'::interval / 10 as

Re: [HACKERS] [PATCHES] log_statement output for protocol

2006-08-29 Thread Guillaume Smet
Bruce, I made a few tests here and the backend terminates with a SIG11 when a parameter has the NULL value (it was logged as (null) before). I suspect the new code broke something (perhaps it's due to the escaping). -- Guillaume ---(end of

Re: [HACKERS] [PATCHES] log_statement output for protocol

2006-08-29 Thread Guillaume Smet
On 8/29/06, Bruce Momjian [EMAIL PROTECTED] wrote: DETAIL: prepare: SELECT $1; bind: $1 = 'a''b' I attached a trivial patch to add a dash between the prepare part and the bind part. People usually don't finish their queries with a semi colon so it's more readable with a separator.

Re: [PATCHES] [HACKERS] Performance testing of COPY (SELECT)

2006-08-29 Thread Zoltan Boszormenyi
Bruce Momjian írta: Tom Lane wrote: Alvaro Herrera [EMAIL PROTECTED] writes: Zoltan Boszormenyi wrote: My v8 had the syntax support for COPY (SELECT ...) (col1, col2, ...) TO and it was actually working. In your v9 you rewrote the syntax parsing so that feature was lost

Re: [PATCHES] [HACKERS] Interval aggregate regression failure

2006-08-29 Thread Bruce Momjian
Michael Glaesemann wrote: On Aug 29, 2006, at 15:38 , Michael Glaesemann wrote: I think I've got it. I plan to update the regression tests this evening, but I wanted to post what I believe is a solution. I've cleaned up the patch a bit in terms of whitespace, comments, and parens.

Re: [PATCHES] [HACKERS] Interval aggregate regression failure (expected seems

2006-08-29 Thread Michael Glaesemann
On Aug 30, 2006, at 1:13 , Bruce Momjian wrote: Uh, I came up with a cleaner one, I think. I didn't test --enable-integer-datetimes yet. Cool. It's indeed much cleaner. Thanks, Bruce. I'm about to head to bed, but I'll look at it more closely tomorrow. I also noticed that my regression

Re: [PATCHES] Updatable views

2006-08-29 Thread Alvaro Herrera
Bernd Helmle wrote: --On Donnerstag, August 24, 2006 22:25:46 +0200 Bernd Helmle [EMAIL PROTECTED] wrote: --On Montag, August 21, 2006 02:07:41 -0400 Alvaro Herrera [EMAIL PROTECTED] wrote: If someone wants to look at the current updatable view patch, please look at this current

[PATCHES] Changes to epgc test

2006-08-29 Thread Chris Browne
I'm not at all sure that these are the right changes to apply; it somewhat appears to me as though ecpg is supposed to be able to cope with the omissions. In any case, CVS HEAD is breaking on AIX 5.3 with GCC 4.1.1, and these are the places where it's breaking. Index: test1.pgc.in

Re: [HACKERS] [PATCHES] log_statement output for protocol

2006-08-29 Thread Bruce Momjian
Guillaume Smet wrote: On 8/29/06, Bruce Momjian [EMAIL PROTECTED] wrote: DETAIL: prepare: SELECT $1; bind: $1 = 'a''b' I attached a trivial patch to add a dash between the prepare part and the bind part. People usually don't finish their queries with a semi colon so it's more

Re: [PATCHES] [HACKERS] Interval aggregate regression failure

2006-08-29 Thread Bruce Momjian
Michael Glaesemann wrote: On Aug 30, 2006, at 1:13 , Bruce Momjian wrote: Uh, I came up with a cleaner one, I think. I didn't test --enable-integer-datetimes yet. Cool. It's indeed much cleaner. Thanks, Bruce. I'm about to head to bed, but I'll look at it more closely tomorrow.

Re: [PATCHES] updated patch for selecting large results sets in psql using cursors

2006-08-29 Thread Tom Lane
[EMAIL PROTECTED] writes: here comes the latest version (version 7) of the patch to handle large result sets with psql. As previously discussed, a cursor is used for SELECT queries when \set FETCH_COUNT some_value 0 Applied with revisions ... I didn't like the fact that the code was

Re: [PATCHES] [HACKERS] Interval aggregate regression failure (expected seems

2006-08-29 Thread Michael Glaesemann
On Aug 30, 2006, at 7:12 , Bruce Momjian wrote: Here are the results using my newest patch: test= select interval '41 mon 12 days 360:00' / 10 as quotient_a , interval '41 mon -12 days -360:00' / 10 as quotient_b , interval '-41 mon 12 days 360:00' / 10 as

Re: [PATCHES] [HACKERS] Interval aggregate regression failure

2006-08-29 Thread Bruce Momjian
Michael Glaesemann wrote: On Aug 30, 2006, at 7:12 , Bruce Momjian wrote: Here are the results using my newest patch: test= select interval '41 mon 12 days 360:00' / 10 as quotient_a , interval '41 mon -12 days -360:00' / 10 as quotient_b , interval '-41 mon 12

Re: [PATCHES] Interval month, week - day

2006-08-29 Thread Bruce Momjian
The masks don't need changing. Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches It will be applied as soon as one of the PostgreSQL committers reviews and approves it.

Re: [PATCHES] [HACKERS] Interval aggregate regression failure (expected seems

2006-08-29 Thread Michael Glaesemann
On Aug 30, 2006, at 12:50 , Bruce Momjian wrote: Here is a test program. What does it show for you? The output for me is: 4.100 2.989 3.000 Here's what I get. Just to make sure I'm doing this right, I'm including how I

Re: [PATCHES] [HACKERS] Performance testing of COPY (SELECT) TO

2006-08-29 Thread Böszörményi Zoltán
Hi, as per your suggestion, the COPY view TO support was cut and a hint was added. Please, review. Best regards, Zoltán Böszörményi pgsql-copyselect-12.patch.gz Description: GNU Zip compressed data ---(end of broadcast)--- TIP 5: don't forget to