Magnus, is this the right fix?
Well, actually msdn states:
Return Value
If successful, _setmode returns the previous translation mode. A return
value of -1 indicates an error
So, shouldn't we be testing for -1 instead of 0 ?
The thing is probably academic, since _setmode is only supposed
Having recently tried to build 7.4, and 8.0 branches on Itanium2 with ICC
http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=dugongdt=2006-09-29%2015:59:09
http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=dugongdt=2006-09-29%2015:59:43
I encountered the same error as people before:
Zeugswetter Andreas DCP SD [EMAIL PROTECTED] writes:
If successful, _setmode returns the previous translation mode. A return
value of -1 indicates an error
So, shouldn't we be testing for -1 instead of 0 ?
I think the usual convention is to test for 0, unless there are other
negative return
Sergey E. Koposov [EMAIL PROTECTED] writes:
Having recently tried to build 7.4, and 8.0 branches on Itanium2 with ICC
7.4 is not going to work with ICC anyway without considerably more
extensive changes (eg, configure hacking). It might make sense to
apply this patch to 8.0 but I can't get all
On Tue, 3 Oct 2006, Tom Lane wrote:
Sergey E. Koposov [EMAIL PROTECTED] writes:
Having recently tried to build 7.4, and 8.0 branches on Itanium2 with ICC
7.4 is not going to work with ICC anyway without considerably more
extensive changes (eg, configure hacking). It might make sense to
The code around errcode is definitly messy. In CVS now, it actually
renames *our* errcode() function to __msvc_errcode, and exports this
from postgres.exe. This is definitly very borken.
The check for _MSC_VER 1400 won't come true until Microsoft releases
the next verison of Visual Studio -
Two fixes:
1) Make vcbuild actually build the pgevent dll.
2) Change the pgevent DLL file so it doens't specify ordinal for the
functions. You're not supposed to do that. You're actually supposed to
declare them as PRIVATE as well, but mingw doesn't support that. VC++
will throw a warning and not
Patch applied. Thanks.
---
ITAGAKI Takahiro wrote:
The attached patch changes units of the some default values in
postgresql.conf.
- shared_buffers = 32000kB = 32MB
- temp_buffers = 8000kB = 8MB
- wal_buffers = 8
Patch applied. Thanks.
---
Euler Taveira de Oliveira wrote:
Hi,
Attached is a patch to make some sentences consistent with similar ones.
--
Euler Taveira de Oliveira
http://www.timbira.com/
[ Attachment,
Andrew Dunstan wrote:
Martijn van Oosterhout wrote:
Just a minor thing. In yesno_prompt(), the value is resp is allocated
memory that is never freed.
File: src/bin/scripts/common.c
Line: 218
Not terribly important though, it's not used in critical utilities, but
it's used often.
I agree that this code is both wrong and unreadable
(although in
practice the _setmode will probably never fail, which
is why our
attention hasn't been drawn to it). Is someone going
to submit a
patch? I'm hesitant to change the code myself since
I'm not in a
Magnus Hagander [EMAIL PROTECTED] writes:
Attached patch adds a version check for bison when running the vc++
build.
Shouldn't it be looking for 2.1 as well?
regards, tom lane
---(end of broadcast)---
TIP 6: explain
Magnus Hagander [EMAIL PROTECTED] writes:
The code around errcode is definitly messy. In CVS now, it actually
renames *our* errcode() function to __msvc_errcode, and exports this
from postgres.exe. This is definitly very borken.
Would it be possible to move the whole crtdefs.h block into
Attached patch adds a version check for bison when running the vc++
build.
Shouldn't it be looking for 2.1 as well?
2.1 is the broken one. It seemd it was fixed in 2.2, but 2.2 isn't
realeased for win32 from what I cna tell.
//Magnus
---(end of
The code around errcode is definitly messy. In CVS now, it actually
renames *our* errcode() function to __msvc_errcode, and
exports this
from postgres.exe. This is definitly very borken.
Would it be possible to move the whole crtdefs.h block into win32.h?
This would cause it to be
Magnus Hagander [EMAIL PROTECTED] writes:
Would it be possible to move the whole crtdefs.h block into win32.h?
Nope, it needs to go before stdio.h and friends, unfortunatly.
OK, patch committed as-is then. The whole thing still looks awfully
icky though, particularly the way pg_config_os.h is
Magnus Hagander [EMAIL PROTECTED] writes:
Attached patch adds a version check for bison when running the vc++
build.
Shouldn't it be looking for 2.1 as well?
2.1 is the broken one.
Exactly. So we should reject it.
It seemd it was fixed in 2.2, but 2.2 isn't
realeased for win32 from
Applied.
---
Bruce Momjian wrote:
Bruce Momjian wrote:
Magnus Hagander wrote:
Now, I still twist my head around the lines:
if ((fd = _open_osfhandle((long) h, fileFlags O_APPEND)) 0
||
(fileFlags
Patch applied. Thanks.
---
David Fetter wrote:
On Thu, Sep 28, 2006 at 11:16:56PM +0200, Martijn van Oosterhout wrote:
On Thu, Sep 28, 2006 at 05:11:43PM -0400, Tom Lane wrote:
David Fetter [EMAIL PROTECTED] writes:
Patch applied. Thanks.
---
Magnus Hagander wrote:
Two fixes:
1) Make vcbuild actually build the pgevent dll.
2) Change the pgevent DLL file so it doens't specify ordinal for the
functions. You're not supposed to do
On Tue, 3 Oct 2006, Tom Lane wrote:
Sergey E. Koposov [EMAIL PROTECTED] writes:
Having recently tried to build 7.4, and 8.0 branches on Itanium2 with ICC
7.4 is not going to work with ICC anyway without considerably more
extensive changes (eg, configure hacking). It might make sense to
Charles Duffy [EMAIL PROTECTED] writes:
The patch puts a CHECK_FOR_INTERRUPTS in qsort_comparetup.
Just to close out this thread: this is now done for 8.2, per discussion
here:
http://archives.postgresql.org/pgsql-hackers/2006-10/msg00144.php
regards, tom lane
22 matches
Mail list logo
