Re: [PATCHES] enable logging of start time/cookie for all backend processes

2007-08-02 Thread Andrew Dunstan
Alvaro Herrera wrote: Andrew Dunstan wrote: The attached patch makes a very small but useful change to the behaviour of log_line_prefix, by enabling the start time (%s) and cookie (%c) logging to occur for all backends rather than just for session processes (i.e. backends started for a

Re: [PATCHES] HOT patch - version 11

2007-08-02 Thread Pavan Deolasee
On 8/2/07, Pavan Deolasee [EMAIL PROTECTED] wrote: On 8/2/07, Heikki Linnakangas [EMAIL PROTECTED] wrote: Maybe a nicer solution would be to have another version of ConditionalLockBuffer with three different return values: didn't get lock, got exclusive lock, or got cleanup lock.

Re: [PATCHES] HOT patch - version 11

2007-08-02 Thread Pavan Deolasee
On 8/2/07, Heikki Linnakangas [EMAIL PROTECTED] wrote: Pavan Deolasee wrote: Please see the attached version 11 of HOT patch Thanks! One wrinkle in the patch is how the ResultRelInfo-struct is passed to heap_update, and on to heap_check_idxupdate, to check any indexed columns have

Re: [PATCHES] HOT patch - version 11

2007-08-02 Thread Simon Riggs
On Wed, 2007-08-01 at 21:09 +0100, Heikki Linnakangas wrote: In heap_page_prune_defrag, it would be better to do the test for BufferIsLockedForCleanup right after acquiring the lock. The longer the delay between those steps, the bigger the chances that someone pins the page and starts to wait

Re: [PATCHES] Memory leak in tuplestore_end()

2007-08-02 Thread Neil Conway
On Wed, 2007-08-01 at 16:49 -0700, Neil Conway wrote: Attached is a patch which fixes a memory leak in tuplestore_end(). Applied to HEAD, and to back branches as far back as 7.4. -Neil ---(end of broadcast)--- TIP 3: Have you checked our

Re: [PATCHES] use binary mode on syslog pipe on windows to avoid upsetting chunking protocol

2007-08-02 Thread Andrew Dunstan
Andrew Dunstan wrote: This small patch makes the syslog pipe use binary mode on Windows This is now committed and ported back to 8.0. cheers andrew ---(end of broadcast)--- TIP 6: explain analyze is your friend

Re: [PATCHES] enable logging of start time/cookie for all backend processes

2007-08-02 Thread Andrew Dunstan
Andrew Dunstan wrote: Alvaro Herrera wrote: Andrew Dunstan wrote: The attached patch makes a very small but useful change to the behaviour of log_line_prefix, by enabling the start time (%s) and cookie (%c) logging to occur for all backends rather than just for session processes (i.e.