Re: [PATCHES] [HACKERS] buildenv.pl/buildenv.bat

2007-12-14 Thread Andrew Dunstan
Magnus Hagander wrote: On Fri, Dec 14, 2007 at 03:39:14PM +, Dave Page wrote: Andrew Dunstan wrote: Writing and calling a temp .bat file might be yucky - having to keep two environment files is a lot more yucky, IMNSHO, and we shouldn't make people do it. +1 Ok, I g

Re: [PATCHES] [HACKERS] buildenv.pl/buildenv.bat

2007-12-14 Thread Magnus Hagander
On Fri, Dec 14, 2007 at 03:39:14PM +, Dave Page wrote: > Andrew Dunstan wrote: > > Writing and calling a temp .bat file might be yucky - having to keep two > > environment files is a lot more yucky, IMNSHO, and we shouldn't make > > people do it. > > +1 Ok, I guess I'm outvoted ;-) I don't ca

Re: [PATCHES] [HACKERS] buildenv.pl/buildenv.bat

2007-12-14 Thread Dave Page
Andrew Dunstan wrote: > Writing and calling a temp .bat file might be yucky - having to keep two > environment files is a lot more yucky, IMNSHO, and we shouldn't make > people do it. +1 /D ---(end of broadcast)--- TIP 9: In versions below 8.0, the

Re: [PATCHES] buildenv.pl/buildenv.bat

2007-12-14 Thread Andrew Dunstan
Magnus Hagander wrote: Well, I honestly think we can live with it for one cycle. As soon as 8.4 opens I'll get to work converting these .bat files to pure one line wrappers. Ok. We obviously don't agree on what to do here, so let's open it up for somebody else to comment on

Re: [PATCHES] [HACKERS] Is postgres.gif missing in cvs?

2007-12-14 Thread Bruce Momjian
Peter Eisentraut wrote: > Am Freitag, 14. Dezember 2007 schrieb Bruce Momjian: > > I have applied the attached patch to give a helpful message if you try > > to create postgres.ps or postgres.pdf. > > I have corrected this to use $(MAKE) instead of gmake, because the latter > might not be availab

Re: [PATCHES] [HACKERS] Is postgres.gif missing in cvs?

2007-12-14 Thread Bruce Momjian
Peter Eisentraut wrote: > Am Freitag, 14. Dezember 2007 schrieb Bruce Momjian: > > I have applied the attached patch to give a helpful message if you try > > to create postgres.ps or postgres.pdf. > > I have corrected this to use $(MAKE) instead of gmake, because the latter > might not be availab

Re: [PATCHES] [HACKERS] Is postgres.gif missing in cvs?

2007-12-14 Thread Peter Eisentraut
Am Freitag, 14. Dezember 2007 schrieb Bruce Momjian: > I have applied the attached patch to give a helpful message if you try > to create postgres.ps or postgres.pdf. I have corrected this to use $(MAKE) instead of gmake, because the latter might not be available. -- Peter Eisentraut http://dev

Re: [PATCHES] [HACKERS] Is postgres.gif missing in cvs?

2007-12-14 Thread Bruce Momjian
> You need to say "make postgres-US.pdf" or -A4. The .gif file is coming > from make's default rules. Perhaps we should provide a real target > matching postgres.pdf and error out with a helpful message as this isn't > the first time people have been bitten by that change. I have applied the att