applied the attached patch to 7.4 and HEAD branches. (The other
places Patrick identified are already fixed in 7.4.)
regards, tom lane
*** doc/src/sgml/pltcl.sgml.origSat Nov 29 14:51:37 2003
--- doc/src/sgml/pltcl.sgml Sat Jan 24 17:58:35 2004
this change is not only not large, there's no evidence that it'd
even be measurable.
regards, tom lane
---(end of broadcast)---
TIP 6: Have you searched our list archives?
http://archives.postgresql.org
the
rest of the tree and change iteration variables to ListCell*, removing
the casts in the macros when all is done. This is a lot more pleasant
way to proceed than a big bang changeover. (Removal of the FastList
code could also be done incrementally.)
regards, tom lane
Peter Eisentraut [EMAIL PROTECTED] writes:
Please don't put tabs in SGML files.
That's a new one on me. Why should we avoid tabs? The existing files
are certainly full of them.
regards, tom lane
---(end of broadcast
.
regards, tom lane
---(end of broadcast)---
TIP 6: Have you searched our list archives?
http://archives.postgresql.org
Bruce Momjian [EMAIL PROTECTED] writes:
Tom Lane wrote:
I'm not objecting to your doing it, exactly, just suggesting that there
are better things to spend your time on.
Of course, if it makes the code clearer, that is a win in itself.
Sure, but I can't see that there's any gain
be coded any
differently from the built-in ones.
regards, tom lane
---(end of broadcast)---
TIP 3: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to [EMAIL PROTECTED] so that your
not datatype alone.
regards, tom lane
---(end of broadcast)---
TIP 7: don't forget to increase your free space map settings
-terminated. But it does look like there's a missed speedup here.
(Tatsuo, do you agree?)
Thanks for the report!
regards, tom lane
---(end of broadcast)---
TIP 7: don't forget to increase your free space map settings
with
CLOBBER_FREED_MEMORY enabled, so the junk beyond the end of the string
won't match the other string.
Will commit the patch. Thanks.
regards, tom lane
---(end of broadcast)---
TIP 9: the planner will ignore your desire to choose
if there are any actual exploitable instances of
this in the backend, but the above unsafe coding practise is fairly
common.
It is? I thought I'd gone around and checked for that. If you see any
remaining cases then I'd say they are must-fix items.
regards, tom lane
extensive one with some cosmetic changes in HEAD.
You probably want to copy the 7.4 change to 7.3.
regards, tom lane
---(end of broadcast)---
TIP 2: you can get off all lists at once with the unregister command
(send
standard set-returning
function but I bet it will not be the last, so the shortness of the
subsection doesn't bother me.
regards, tom lane
---(end of broadcast)---
TIP 9: the planner will ignore your desire to choose an index scan
, tom lane
---(end of broadcast)---
TIP 9: the planner will ignore your desire to choose an index scan if your
joining column's datatypes do not match
cents: help on psql commands seems fine to me. Internal
doesn't seem very informative here --- it's not clear what internal
is in reference to, psql or the total Postgres system.
regards, tom lane
---(end of broadcast)---
TIP
Joe Conway [EMAIL PROTECTED] writes:
Tom Lane wrote:
Joe Conway [EMAIL PROTECTED] writes:
regression=# select * from pg_generate_sequence(8, 4);
ERROR: finish is less than start
Hm, would it be better just to return an empty set? Certainly I'd
expect pg_generate_sequence(1,0) to return
consider that an error.
OK to commit?
Don't forget to bump the catversion number.
regards, tom lane
---(end of broadcast)---
TIP 2: you can get off all lists at once with the unregister command
(send unregister
Joe Conway [EMAIL PROTECTED] writes:
Tom Lane wrote:
folklore has it that Mariner II was lost to exactly such a bug).
Ouch -- got the point.
BTW, I think I was beating you over the head with an urban legend.
Some idle googling revealed the true facts of the Mariner failure:
http
. If we want to be
bulletproof against that, then none of the proposals in this thread are
correct, and the correct patch is
+ LC_COLLATE=C
+ export LC_COLLATE
regards, tom lane
---(end of broadcast)---
TIP 7: don't forget
bytes of what memcmp is
comparing are the length, and so it'll fall out immediately anyway if
the lengths differ.
regards, tom lane
---(end of broadcast)---
TIP 6: Have you searched our list archives?
http
Stephan Szabo [EMAIL PROTECTED] writes:
On Mon, 2 Feb 2004, Tom Lane wrote:
This isn't a bug, and I see no reason to clutter the code just to shut
up valgrind.
Isn't memcpy on overlapping (even entirely overlapping) buffers undefined
behavior unless the count is 0?
The reason that the spec
this will shut valgrind up). I could live with that;
it seems a less intrusive fix than a special-case test that will hardly
ever trigger.
regards, tom lane
---(end of broadcast)---
TIP 5: Have you checked our extensive FAQ
. It is an error for step to be zero.
... and then carry on with the examples, which seem fine (although
the one showing the error for step=0 might be thought redundant
with the text).
regards, tom lane
---(end of broadcast)---
TIP
).
I don't really agree with cluttering our code with temporary workarounds
for a mingw bug.
regards, tom lane
---(end of broadcast)---
TIP 5: Have you checked our extensive FAQ?
http://www.postgresql.org/docs
that
psql is at the intersection of traditionally-case-sensitive Unix and
traditionally-not-case-sensitive SQL. It is not instantly obvious which
behavior should be expected.
I take no position on whether this is the best way to document it...
regards, tom lane
ways. There are a heck of a lot of SET variables --- would
we want an env var for each one? (Seen in this light, PGCLIENTENCODING
is a wart, but I suppose we have to keep it for backwards compatibility.)
regards, tom lane
---(end of broadcast
, tom lane
---(end of broadcast)---
TIP 6: Have you searched our list archives?
http://archives.postgresql.org
Thomas Hallgren [EMAIL PROTECTED] writes:
Sure, I'll provide some docs. Just wasn't aware that patchers did that.
Who did you think would do it?
regards, tom lane
---(end of broadcast)---
TIP 3: if posting/reading through
query strings that's gonna take awhile no matter how you do it.
But in any case, the argument for moving to flex is not about
performance, it is about making the code more understandable and more
certain to agree with the backend lexer.
regards, tom lane
Neil Conway [EMAIL PROTECTED] writes:
Tom Lane [EMAIL PROTECTED] writes:
I'm inclined to apply this but I can see where a person not comfortable
with flex might feel differently. Opinions?
Looks good to me. The psql cleanup is nice, and ISTM that much of the
flex code is comments or flex
dollar quoting
in the prompt, but that's pretty trivial). My intent with the given
patch was just to replicate existing functionality with flex.
regards, tom lane
---(end of broadcast)---
TIP 6: Have you searched our list
by reducing
the lock levels a user is allowed to define?
I will vote against the patch no matter what, but I agree that it would
be less dangerous if it were confined to only apply to a limited set of
lock types.
regards, tom lane
---(end of broadcast
or new behavior.
Um, maybe I'm confused about the context, but aren't we talking about C
function names here? No overloading is possible in C ...
regards, tom lane
---(end of broadcast)---
TIP 1: subscribe and unsubscribe
in a quoting state when you recognized the
\i command, and so you shouldn't be when you come out of the include
file.) We could argue about that if people want to reconsider it, but
it seems orthogonal to the dollar-quoting change to me.
regards, tom lane
regression tests (any
volunteers?)
I think plpgsql's lexer also needs to be taught about dollar-quoting.
regards, tom lane
---(end of broadcast)---
TIP 7: don't forget to increase your free space map settings
Andrew Dunstan [EMAIL PROTECTED] writes:
I think plpgsql's lexer also needs to be taught about dollar-quoting.
The attached patch appears to do the trick:
Applied. It needed a little more work to handle RAISE NOTICE
reasonably, but I took care of that.
regards, tom
cross-type operators. The correct way
to do this would be to look at the operator found by oper() and see
whether it's indexable.
regards, tom lane
---(end of broadcast)---
TIP 2: you can get off all lists at once
that needs some thought is
where the FK and referenced PK are domains on a common base type.
regards, tom lane
---(end of broadcast)---
TIP 4: Don't 'kill -9' the postmaster
is good.
regards, tom lane
---(end of broadcast)---
TIP 2: you can get off all lists at once with the unregister command
(send unregister YourEmailAddressHere to [EMAIL PROTECTED])
of PostgreSQL.)));
regards, tom lane
---(end of broadcast)---
TIP 7: don't forget to increase your free space map settings
grammatical structure that fits
into the local sentence.
I believe Neil was just copying the existing examples in our docs.
What's this link and how would you use it, exactly?
regards, tom lane
---(end of broadcast)---
TIP
=#
regards, tom lane
---(end of broadcast)---
TIP 6: Have you searched our list archives?
http://archives.postgresql.org
find that argument much more convincing than any of the others
...
Jan, what do you think? You invented this command's syntax IIRC.
regards, tom lane
---(end of broadcast)---
TIP 5: Have you checked our extensive FAQ
.
regards, tom lane
---(end of broadcast)---
TIP 9: the planner will ignore your desire to choose an index scan if your
joining column's datatypes do not match
completely fails to
explain that the problem is only one of speed and not functionality.
If you want it to be a WARNING then we gotta work on the text some more.
regards, tom lane
---(end of broadcast)---
TIP 7: don't forget
Bruce Momjian [EMAIL PROTECTED] writes:
Tom Lane wrote:
I'd suggest something along the lines of
NOTICE: foreign key constraint constrname will require a cross-type conversion
DETAIL: key columns fkcol and pkcol are of different types integer and double
precision
I suggested
and as to formatting the output readably.
regards, tom lane
---(end of broadcast)---
TIP 8: explain analyze is your friend
.
regards, tom lane
---(end of broadcast)---
TIP 8: explain analyze is your friend
the attached modification, which will recognize strict operators
and functions of any number of arguments.
regards, tom lane
*** src/backend/optimizer/path/indxpath.c.orig Wed Jan 7 17:02:48 2004
--- src/backend/optimizer/path/indxpath.c Sun Mar 7 00:13:27 2004
will entertain the thought of asking me for a
patch... ;)
I had quite the opposite motivation in mind in asking you to prototype
this ;-) ...
regards, tom lane
---(end of broadcast)---
TIP 5: Have you checked our extensive FAQ
James Tanis [EMAIL PROTECTED] writes:
In message [EMAIL PROTECTED], Tom Lane avows:
Uh, why is that a good idea?
As you will see, it takes a pretty contrived situation, but indeed I've got
one :-)
I have a software system which can use postgres if the user so wishes. We
have a wrapper
Bruce Momjian [EMAIL PROTECTED] writes:
Tom Lane wrote:
Uh, why is that a good idea?
Well, suppose you want all your users to use the same psqlrc file.
Instead of creating symlinks for every user, you can just set PSQLRC in
/etc/profile and everyone gets it.
... but people who want to make
noisy...
regards, tom lane
---(end of broadcast)---
TIP 5: Have you checked our extensive FAQ?
http://www.postgresql.org/docs/faqs/FAQ.html
the
code, rather than fix it to work properly. Any comments?
This works in 7.4 and older releases. Sounds to me like you broke it.
regards, tom lane
---(end of broadcast)---
TIP 9: the planner will ignore your desire
Dennis Bjorklund [EMAIL PROTECTED] writes:
By the way, this thing was discussed on irc and I just sent a mail on
-hackers about it, not knowing about this thread here.
Yeah, let's take the discussion to -hackers using your message as a
base.
regards, tom lane
of
integer constants?
regards, tom lane
---(end of broadcast)---
TIP 4: Don't 'kill -9' the postmaster
Fabien COELHO [EMAIL PROTECTED] writes:
Same comment as with version one, I don't know how to test the multi-byte
part.
It should be fairly easy to test if you use UNICODE client encoding;
anything outside the 7-bit-ASCII set will be 2 or more bytes.
regards, tom lane
Andrew Dunstan [EMAIL PROTECTED] writes:
Tom Lane wrote:
Has any of this discussion taken into account the fact that a
querystring may contain multiple commands?
What does the parser do if one of the statements has an error and the
others are OK?
The whole thing is rejected. This is just
they are used so often by
so many developers. I pared it down a little, and made sure it
exercised both promotion and crosstype-index-operator cases.
Overall though, a good effort. This was your first backend patch,
wasn't it? Nice job.
regards, tom lane
bin0.bin
.
regards, tom lane
---(end of broadcast)---
TIP 3: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to [EMAIL PROTECTED] so that your
message can get through to the mailing list cleanly
launched
on your system). Also I think we have at least one global config file
already for libpq, and its location is hard-wired.
regards, tom lane
---(end of broadcast)---
TIP 3: if posting/reading through Usenet, please send
ljb [EMAIL PROTECTED] writes:
This fixes a protocol violation and disconnect when 7.4.x libpq is talking
to a v2 protocol (=7.3.x) server.
Good catch. Patch applied.
thanks, tom lane
---(end of broadcast)---
TIP 8
test with greater precision choices; which personally I think is
quite useless. But we could imagine using the mechanism for other stuff.
regards, tom lane
---(end of broadcast)---
TIP 2: you can get off all lists at once
Bruce Momjian [EMAIL PROTECTED] writes:
Where are we on this? It seems like a win to me.
I thought it was a bad idea, although I no longer remember the details.
regards, tom lane
---(end of broadcast)---
TIP 4: Don't
in the hackers or patches archives,
nor on your to-apply pages, making it a bit difficult to re-investigate.
Where was it posted anyway?
regards, tom lane
---(end of broadcast)---
TIP 4: Don't 'kill -9' the postmaster
Bruce Momjian [EMAIL PROTECTED] writes:
Tom Lane wrote:
Where was it posted anyway?
Found it:
http://groups.google.com/groups?hl=enlr=ie=UTF-8selm=200312010450.hB14ovH16330%40candle.pha.pa.usrnum=8
Thanks. The original patch is much older than I thought --- I was
looking
or never.
No, I say that we shouldn't put in a kluge that gets it sort-of right in
a simple interface and makes it impossible for better interfaces to get
it really right. I think we can do better than that.
regards, tom lane
---(end of broadcast
?
regards, tom lane
---(end of broadcast)---
TIP 4: Don't 'kill -9' the postmaster
not bind to any socket focuses on the second. Can we cover both?
Please revise, and update the docs too.
regards, tom lane
---(end of broadcast)---
TIP 2: you can get off all lists at once with the unregister command
(send
, tom lane
---(end of broadcast)---
TIP 5: Have you checked our extensive FAQ?
http://www.postgresql.org/docs/faqs/FAQ.html
...
regards, tom lane
---(end of broadcast)---
TIP 3: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to [EMAIL PROTECTED] so that your
message can get through to the mailing list cleanly
. Patch as-applied is
attached.
I don't have any real convenient way to set up a situation where this
failure can actually occur. Anyone want to verify that the patch
acts as intended?
regards, tom lane
*** src/backend/postmaster/pgstat.c.origMon Mar 15 15:01:57 2004
big trouble for 8th-bit-set characters.
I went with no socket configured to listen on for the failure message,
but am not wedded to that either.
regards, tom lane
---(end of broadcast)---
TIP 1: subscribe and unsubscribe
?
regards, tom lane
---(end of broadcast)---
TIP 6: Have you searched our list archives?
http://archives.postgresql.org
description
of what that function was doing, for instance).
At this point I think we are done with the coding part of this project,
and it's time to get to work on the documentation ...
regards, tom lane
---(end of broadcast)---
TIP
Bruce Momjian [EMAIL PROTECTED] writes:
Tom Lane wrote:
How about no socket created for listening or some such?
Or no socket available for listening?
Created seems better since it's a verb, and focuses attention on the
probability that we tried and failed to make a socket. Available is
too
with this workaround, would it make sense to use a wrapper function?
I'm loath to invent pg_select() but it might be cleaner than this.
regards, tom lane
---(end of broadcast)---
TIP 7: don't forget to increase your free
Claudio Natoli [EMAIL PROTECTED] writes:
Tom Lane wrote:
Every #ifdef WIN32 I see reduces my opinion of the quality of work
being done for this port.
At risk of getting (further? :-) on your bad side, IMHO that is a specious
metric.
Well, it's surely not the only interesting metric, but I
errno here;
return foo;
}
The fewer places that have to know about this sort of thing, the better
off we will be.
regards, tom lane
---(end of broadcast)---
TIP 6: Have you searched our list archives
be changed. It can also be done.
Yes. I think we must have an all_subselect_ops or similar.
regards, tom lane
---(end of broadcast)---
TIP 7: don't forget to increase your free space map settings
Claudio Natoli [EMAIL PROTECTED] writes:
Hopeless, or cute, work-around?
It's possibly workable in the limited context of the postmaster, but
I've got doubts about doing it in libpq where we can't assume we know
what the surrounding application will do.
regards, tom lane
at all. Our APCs are server side
only, so it's not a problem there.
Oh really? What if the surrounding app uses APCs?
regards, tom lane
---(end of broadcast)---
TIP 5: Have you checked our extensive FAQ
.
regards, tom lane
---(end of broadcast)---
TIP 6: Have you searched our list archives?
http://archives.postgresql.org
?
regards, tom lane
---(end of broadcast)---
TIP 7: don't forget to increase your free space map settings
review
of this mare's-nest seems warranted.
This file is getting to be a poster child for the reasons not to use
#ifdefs :-(
regards, tom lane
---(end of broadcast)---
TIP 2: you can get off all lists at once
regression test suite.
The regression test suite does not cover can't-happen cases ...
regards, tom lane
---(end of broadcast)---
TIP 2: you can get off all lists at once with the unregister command
(send unregister
my mind, you've got to show me some
concrete results of hints that are more useful than \h command is.
regards, tom lane
---(end of broadcast)---
TIP 6: Have you searched our list archives?
http
away with it...
regards, tom lane
---(end of broadcast)---
TIP 2: you can get off all lists at once with the unregister command
(send unregister YourEmailAddressHere to [EMAIL PROTECTED])
whether bison's internal tables expose that set in any useful
fashion, but it surely seems worth a look.
regards, tom lane
PS: another reason for doing it that way is that I suspect your current
approach is a dead end anyhow. You've already hit one blocker problem
where you
.
regards, tom lane
---(end of broadcast)---
TIP 8: explain analyze is your friend
into it closely.
That could be a showstopper if true, but it's all speculation at this
point.
regards, tom lane
---(end of broadcast)---
TIP 8: explain analyze is your friend
with
the production backend, but it's an idea to consider...
regards, tom lane
---(end of broadcast)---
TIP 1: subscribe and unsubscribe commands go to [EMAIL PROTECTED]
these names
as keywords was the only practical solution.
regards, tom lane
---(end of broadcast)---
TIP 6: Have you searched our list archives?
http://archives.postgresql.org
. No?
regards, tom lane
---(end of broadcast)---
TIP 9: the planner will ignore your desire to choose an index scan if your
joining column's datatypes do not match
at once? I suppose that could easily wind up costing more than
the qsort though ...
regards, tom lane
---(end of broadcast)---
TIP 7: don't forget to increase your free space map settings
the very same *semantical* result with a
smaller automaton if you chose a different trade-off within the
lexer/parser/post filtering. I don't want to change the language.
You have not proven that you can have the same result.
regards, tom lane
are allowed to execute?
I'm not that thrilled with patches that propose basic changes in
behavior and have not been justified by any preceding discussion
on pghackers...
regards, tom lane
---(end of broadcast)---
TIP 9: the planner
, tom lane
---(end of broadcast)---
TIP 7: don't forget to increase your free space map settings
the patch cover that?
regards, tom lane
---(end of broadcast)---
TIP 1: subscribe and unsubscribe commands go to [EMAIL PROTECTED]
string with special
meaning for the first and second characters.
One point that I don't think was made before is that if we do any such
thing, we'll be forever foreclosing any chance of allowing
multi-character delimiters. ISTM that would not be forward-looking.
regards, tom
201 - 300 of 3477 matches
Mail list logo
