Re: [PATCHES] still alive?

2008-10-01 Thread Alvaro Herrera
, and still be fetchable via rsync to the archives server. -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your subscription: http

Re: [PATCHES] Solve a problem of LC_TIME of windows.

2008-09-24 Thread Alvaro Herrera
that? -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-patches

Re: [PATCHES] still alive?

2008-09-17 Thread Alvaro Herrera
to hold patches now? pgsql-hackers -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your subscription: http://www.postgresql.org

Re: [PATCHES] [HACKERS] Infrastructure changes for recovery

2008-09-12 Thread Alvaro Herrera
(%.1f%%); %d transaction log file(s) added, %d removed, %d recycled; write=%ld.%03d s, sync=%ld.%03d s, total=%ld.%03d s., ... ))) -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7

Re: [PATCHES] [HACKERS] Infrastructure changes for recovery

2008-09-12 Thread Alvaro Herrera
Simon Riggs wrote: On Fri, 2008-09-12 at 14:14 -0400, Alvaro Herrera wrote: Simon Riggs wrote: --- 5716,5725 CheckpointStats.ckpt_sync_end_t, sync_secs, sync_usecs

Re: [PATCHES] libpq events patch (with sgml docs)

2008-09-05 Thread Alvaro Herrera
, I'd prefer that the name is made mandatory.) Oh, BTW: don't post to pgsql-patches. It's deprecated. Use pgsql-hackers instead. -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. -- Sent via pgsql-patches mailing list

Re: [PATCHES] libpq events patch

2008-09-03 Thread Alvaro Herrera
. -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql

Re: [PATCHES] psql command setting

2008-08-29 Thread Alvaro Herrera
Simon Riggs wrote: At the very least we should document the two toggles that are already settable, with the attached patch. Applied. -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. -- Sent via pgsql-patches

Re: [PATCHES] [HACKERS] Hint Bits and Write I/O

2008-08-01 Thread Alvaro Herrera
get rid of the bogus changes Pavan identified. I'm just wondering if the change of usage_count from 16 to 8 bits was discussed and agreed? -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support -- Sent

Re: [PATCHES] Is autovacuum doing a wraparound-avoiding VACUUM?

2008-07-21 Thread Alvaro Herrera
, thanks. -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-patches

Re: [PATCHES] Is autovacuum doing a wraparound-avoiding VACUUM?

2008-07-17 Thread Alvaro Herrera
: , tab-at_wraparound ? (wraparound) : ); You're not proposing it for 8.3 right? -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support -- Sent via pgsql-patches mailing list (pgsql

Re: [PATCHES] Extending grant insert on tables to sequences

2008-07-08 Thread Alvaro Herrera
with the big list? -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your subscription: http://www.postgresql.org

Re: [PATCHES] [HACKERS] WITH RECURSIVE updated to CVS TIP

2008-07-08 Thread Alvaro Herrera
to clone via the following URL: http://git.postgresql.org/git/~davidfetter/postgresql/.git Is there some git repository I can pull from to make this a little less manual? In fact, I fail to see the point of you providing the repo if the upstream guys are apparently not using it ... -- Alvaro

Re: [PATCHES] GIN improvements

2008-07-07 Thread Alvaro Herrera
numbers too, right? Would it be too difficult to strip them out in that case? -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your

Re: [PATCHES] GIN improvements

2008-07-07 Thread Alvaro Herrera
. Single column index is binary compatible with current index :) Ah, neat! -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make

Re: [PATCHES] Fix pg_ctl restart bug

2008-06-26 Thread Alvaro Herrera
know the bug is there. Has the code changed a lot in that area? -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes

Re: [PATCHES] Fix pg_ctl restart bug

2008-06-26 Thread Alvaro Herrera
Bruce Momjian wrote: Alvaro Herrera wrote: Why do we need someone to complain? We know the bug is there. Has the code changed a lot in that area? Do we have the policy of backpatching every fix? I thought it was only the major bugs we fixed in back branches. If someone wants

Re: [PATCHES] [HACKERS] Hint Bits and Write I/O

2008-06-18 Thread Alvaro Herrera
block). -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref

Re: [PATCHES] Simplify formatting.c

2008-06-14 Thread Alvaro Herrera
, then to char, then to text to call texttowcs(). I didn't see a cleaner way to do this. Why not use wchar2char? It seems there's room for extra cleanup here. Also, the prototype of str_initcap in builtins.h looks out of place. -- Alvaro Herrerahttp

Re: [PATCHES] relscan.h split

2008-06-14 Thread Alvaro Herrera
. There are a few occurrences of this: /* must hold a buffer lock to call HeapTupleSatisfiesUpdate */ LockBuffer(scan-rs_cbuf, BUFFER_LOCK_SHARE); which of course need the definition. Maybe providing it is not a bad idea, because that kind of coding is used in the backend too. -- Alvaro

[PATCHES] relscan.h split

2008-06-12 Thread Alvaro Herrera
/access/relscan.h340 360 -20 So it doesn't have a tremendous impact, but it does have some. -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development

Re: [PATCHES] Tentative patch for making DROP put dependency info in DETAIL

2008-06-12 Thread Alvaro Herrera
of the Remove things behave the same way I don't think there's anything wrong with that in principle. However, does your patch actually work? The changes in expected/ is unexpected, I think. -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication

Re: [PATCHES] Tentative patch for making DROP put dependency info in DETAIL

2008-06-11 Thread Alvaro Herrera
currently include dependency.h. A possible response to that is to move ObjectAddress into postgres.h, but that seems a bit ugly too. Ugh. I thought about having a new header, but that seems overkill. -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL

Re: [PATCHES] Tentative patch for making DROP put dependency info in DETAIL

2008-06-10 Thread Alvaro Herrera
to the client (with the server log of course saying something different). So I gave up and left that behavior separate. Huh, annoying. Agreed with leaving that alone. -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development

Re: [PATCHES] SQL: table function support

2008-06-10 Thread Alvaro Herrera
Tom Lane escribió: Alvaro Herrera [EMAIL PROTECTED] writes: Tom Lane escribi�: (It's also worth asking where the import is coming from. Who implements the spec syntax anyway? DB2 maybe, but when was the last time we heard from anyone trying to migrate from DB2 to PG?) Sourceforge

Re: [PATCHES] SQL: table function support

2008-06-09 Thread Alvaro Herrera
Tom Lane escribió: (It's also worth asking where the import is coming from. Who implements the spec syntax anyway? DB2 maybe, but when was the last time we heard from anyone trying to migrate from DB2 to PG?) Sourceforge? -- Alvaro Herrerahttp

Re: [PATCHES] GIN improvements

2008-06-08 Thread Alvaro Herrera
, a flag in shared memory?), or just stash the info that the index needs to be processed in pgstats and have autovac examine it. -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. -- Sent via pgsql-patches mailing list

Re: [PATCHES] GIN improvements

2008-06-08 Thread Alvaro Herrera
the use of the FASTUPDATE parameter? Is there a case when a user is interested in turning it off? -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org

Re: [PATCHES] [HACKERS] TRUNCATE TABLE with IDENTITY

2008-06-07 Thread Alvaro Herrera
Neil's complaint, and add a TODO item to reimplement RESTART IDENTITY transactionally. I think the TODO item did not make it, but the docs do seem updated. -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7

Re: [PATCHES] partial header cleanup

2008-06-01 Thread Alvaro Herrera
). I am not sure what kind of fallout that causes. Maybe that would help you too. We need to come up with a good name for that file however ... bufmgrpage.h seems ugly. -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom

Re: [PATCHES] \d+ should display the storage options for columns

2008-05-23 Thread Alvaro Herrera
Gregory Stark wrote: Alvaro Herrera [EMAIL PROTECTED] writes: This seems to be against an older version of psql ... with the printTable API stuff, we reworked this -- in particular the mbvalidate() call that's only on WIN32 is gone (actually it's the lack of it that's gone.) Sorry

Re: [PATCHES] Extending grant insert on tables to sequences

2008-05-23 Thread Alvaro Herrera
because of a typo... Re-attaching right patch and fix documentation to indicate the new behaviour... Please add the patch to the commitfest page, http://wiki.postgresql.org/wiki/CommitFest:July -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication

Re: [PATCHES] \d+ should display the storage options for columns

2008-05-22 Thread Alvaro Herrera
of it that's gone.) -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql

Re: [PATCHES] Patch for psql 8.0, 8.1 and 8.2 backwards compatibility

2008-05-20 Thread Alvaro Herrera
problem. To me it is a step forward regardless, as it fixes \d which is pretty crucial even when just popping to an old server to check on something before an upgrade. Guillaume Lelarge just submitted a patch for this. Did you check it out? It's on the July commitfest page. -- Alvaro Herrera

Re: [PATCHES] libpq object hooks

2008-05-16 Thread Alvaro Herrera
think this is OK for this commitfest. (Besides, it seems we're almost there on this patch.) -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make

Re: [PATCHES] Patch to change psql default banner v6

2008-05-15 Thread Alvaro Herrera
it's good enough. -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql

Re: [PATCHES] Patch to change psql default banner v6

2008-05-15 Thread Alvaro Herrera
I'm OK with thisG but please move the printSSLInfo() call just before echoing the help line. -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org

Re: [PATCHES] Patch to change psql default banner v6

2008-05-15 Thread Alvaro Herrera
does not support this command. It would be already a huge improvement. Probably the biggest change would be to support versions that did not have schemas, but I think it would be OK to punt on that. We already stopped supporting 7.2 anyway. -- Alvaro Herrerahttp

Re: [PATCHES] Patch to change psql default banner v6

2008-05-14 Thread Alvaro Herrera
the startup info is not very helpful. -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your subscription: http

Re: [PATCHES] Patch to change psql default banner v6

2008-05-14 Thread Alvaro Herrera
.) Remember, the people who is going to type 'help' is not the 10-year-Pg- experience types. It's the newbies. -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support -- Sent via pgsql-patches mailing list

Re: [PATCHES] Patch to change psql default banner v6

2008-05-14 Thread Alvaro Herrera
://archives.postgresql.org/message-id/1200851790.19135.68.camel%40greg-laptop -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes

Re: [PATCHES] libpq Win32 Mutex performance patch

2008-05-13 Thread Alvaro Herrera
Andrew Chernow wrote: Tom Lane wrote: Silently not locking is surely not very safe. Here is the dump code version of the patch. If anyone wants the return value idea, let me know. So is this a patch we want applied? -- Alvaro Herrerahttp

Re: [PATCHES] libpq Win32 Mutex performance patch

2008-05-13 Thread Alvaro Herrera
Magnus Hagander wrote: Alvaro Herrera wrote: Andrew Chernow wrote: Tom Lane wrote: Silently not locking is surely not very safe. Here is the dump code version of the patch. If anyone wants the return value idea, let me know. So is this a patch we want applied

Re: [PATCHES] [GENERAL] Making sure \timing is on

2008-05-13 Thread Alvaro Herrera
last state and unaligned. Which makes it a misnomer. Or maybe the thing to do is leave them damn well alone and just fix \timing. -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. -- Sent via pgsql-patches mailing list

Re: [PATCHES] libpq object hooks

2008-05-13 Thread Alvaro Herrera
is truly successful we can always improve it later -- it's not an exported detail of the API after all.) -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org

Re: [PATCHES] Snapshot management, final

2008-05-12 Thread Alvaro Herrera
the problem. We can revisit this problem later if it's ever an issue. Many thanks for the extensive help. -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support -- Sent via pgsql-patches mailing list (pgsql

Re: [PATCHES] printTable API (was: Show INHERIT in \du)

2008-05-12 Thread Alvaro Herrera
don't recognize the relkind. Thanks for the patch. -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your subscription: http

Re: [PATCHES] Snapshot management, final

2008-05-11 Thread Alvaro Herrera
; Thanks again for the review. -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your subscription: http

Re: [PATCHES] Snapshot management, final

2008-05-11 Thread Alvaro Herrera
Tom Lane wrote: Alvaro Herrera [EMAIL PROTECTED] writes: Tom Lane wrote: Shouldn't UnregisterSnapshot insist that s_level be equal to current xact nest level? It can't check that; consider begin; savepoint foo; declare cur cursor for select (1), (2), (3); savepoint bar

Re: [PATCHES] Snapshot management, final

2008-05-10 Thread Alvaro Herrera
some clean up. This is material for a new patch however.) -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support snapshot-9.patch.gz Description: Binary data -- Sent via pgsql-patches mailing list

Re: [PATCHES] [NOVICE] encoding problems

2008-05-09 Thread Alvaro Herrera
branches unless we get lots of complaints, and we haven't in this case. complaints++ -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes

Re: [PATCHES] [NOVICE] encoding problems

2008-05-07 Thread Alvaro Herrera
from the start of the current column, it will align correctly regardless of the previous columns. -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support -- Sent via pgsql-patches mailing list (pgsql

Re: [PATCHES] [NOVICE] encoding problems

2008-05-07 Thread Alvaro Herrera
Bruce Momjian wrote: Alvaro Herrera wrote: If you start counting every line from the start of the current column, it will align correctly regardless of the previous columns. At this stage you don't know the width of previous columns because you don't know if a very wide value is coming

Re: [PATCHES] [NOVICE] encoding problems

2008-05-07 Thread Alvaro Herrera
Bruce Momjian wrote: Alvaro Herrera wrote: Surely psql computes the width of all cells before printing anything. It does, but if you have a value that has a tab, how do you know what tab stop you are on because you don't know the final width of the previous columns at that time, so

Re: [PATCHES] Snapshot management, final

2008-05-07 Thread Alvaro Herrera
Tom Lane wrote: I looked over this patch and I think it still needs work. Thanks for the thorough review. I'll be working on these problems soon. -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7

Re: [PATCHES] printTable API (was: Show INHERIT in \du)

2008-05-07 Thread Alvaro Herrera
Brendan Jurd escribió: On Thu, Apr 17, 2008 at 7:27 AM, Alvaro Herrera wrote: Thanks. I looked the patch over and did some minor changes. Modified version attached. Cool, I had a look through your changes and they all seemed fine to me. In particular, moving the header comments

Re: [PATCHES] [HACKERS] bug in numeric_power() function

2008-05-07 Thread Alvaro Herrera
/wiki/Exponentiation#Powers_of_zero 0^123.3 is 0, not 1. -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your

Re: [PATCHES] [HACKERS] bug in numeric_power() function

2008-05-07 Thread Alvaro Herrera
Bruce Momjian wrote: Ah, got it, and I updated the patch to remove the commment about discrete. The page also says that 0^x is undefined when x is negative, not sure about that one but I don't see it in your patch. -- Alvaro Herrerahttp://www.CommandPrompt.com

Re: [PATCHES] configure option for XLOG_BLCKSZ

2008-05-05 Thread Alvaro Herrera
because he was missing a Makefile. I built one for him, but last time I looked he hadn't uploaded anything. -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org

Re: [PATCHES] pg_postmaster_reload_time() patch

2008-05-02 Thread Alvaro Herrera
George Gensure escribió: So if nobody's got any further objections, could this patch be applied? It's in the queue: http://wiki.postgresql.org/wiki/CommitFest:May -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc

Re: [PATCHES] Exposing keywords to clients

2008-05-02 Thread Alvaro Herrera
the categories - obviously they need to be non-translatable (for client software to interpret), but human readable is also nice. I'm happy to hear alternate suggestions. Perhaps use a separate string for machine parse (say R, T, C, U), and let the string be translatable. -- Alvaro Herrera

Re: [PATCHES] pg_postmaster_reload_time() patch

2008-04-30 Thread Alvaro Herrera
on both the EXEC_BACKEND case and the regular one. -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your subscription: http

Re: [PATCHES] Documentation: ALTER ROLE - no password

2008-04-30 Thread Alvaro Herrera
Andreas 'ads' Scherbaum wrote: Hello, i've seen the question how to remove a password now several times in the last weeks. Attached is a small patch which add a new example for the ALTER ROLE documentation. Applied, thanks. -- Alvaro Herrerahttp

Re: [PATCHES] [HACKERS] Proposed patch - psql wraps at window width

2008-04-30 Thread Alvaro Herrera
Gregory Stark wrote: Alvaro Herrera [EMAIL PROTECTED] writes: I think that could be fixed easily by having the syntax be something like \pset format aligned:80 \pset format aligned:autowrap I suppose. It seems kind of inconvenient though, what advantage does it have? Over what? I

Re: [PATCHES] [HACKERS] Proposed patch - psql wraps at window width

2008-04-29 Thread Alvaro Herrera
is aligned, with a target width of 80 characters. Uh, well, we can do that, though looking at the psql code \pset only wants two arguments. I think that could be fixed easily by having the syntax be something like \pset format aligned:80 \pset format aligned:autowrap etc. -- Alvaro Herrera

Re: [PATCHES] generate_subscripts

2008-04-28 Thread Alvaro Herrera
Pavel Stehule escribió: This patch contains generate_subscripts functions, that generate series of array's subscripts of some dimension: Committed, thanks. -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. -- Sent

Re: [PATCHES] Removing typename from A_Const (was: Empty arrays with ARRAY[])

2008-04-28 Thread Alvaro Herrera
within a TypeCast. Nonetheless, there was an overall net reduction of 34 lines of code, so I think this was a win. Do say ... why don't we do away with A_Const altogether and just replace it with Value? After this patch, I don't see what's the difference. -- Alvaro Herrera

Re: [HACKERS] [PATCHES] Removing typename from A_Const (was: Empty arrays with ARRAY[])

2008-04-28 Thread Alvaro Herrera
Tom Lane escribió: Alvaro Herrera [EMAIL PROTECTED] writes: Brendan Jurd escribi�: Here's my attempt to remove the typename field from A_Const. There were a few places (notably flatten_set_variable_args() in guc.c, and typenameTypeMod() in parse_type.c) where the code expected to see

Re: [HACKERS] [PATCHES] Removing typename from A_Const (was: Empty arrays with ARRAY[])

2008-04-28 Thread Alvaro Herrera
Tom Lane escribió: Alvaro Herrera [EMAIL PROTECTED] writes: Tom Lane escribió: They're logically different things, and after I get done putting a parse location field into A_Const, they'll still be physically different too. Aha. Are you working from Brendan's patch? I was going

Re: [HACKERS] [PATCHES] Removing typename from A_Const (was: Empty arrays with ARRAY[])

2008-04-28 Thread Alvaro Herrera
Alvaro Herrera escribió: Tom Lane escribió: Alvaro Herrera [EMAIL PROTECTED] writes: Tom Lane escribió: They're logically different things, and after I get done putting a parse location field into A_Const, they'll still be physically different too. Aha. Are you working from

Re: [HACKERS] [PATCHES] Removing typename from A_Const (was: Empty arrays with ARRAY[])

2008-04-28 Thread Alvaro Herrera
Tom Lane escribió: Alvaro Herrera [EMAIL PROTECTED] writes: I came up with the attached patch. I wasn't envisioning anything anywhere near this invasive. We only need locations on constants in a few contexts, I think. Aha. OK, I'll commit the original patch and let you deal with the rest

Re: [PATCHES] lc_time and localized dates

2008-04-24 Thread Alvaro Herrera
commitfest. -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your subscription: http://www.postgresql.org

Re: [PATCHES] 64-bit CommandIds

2008-04-24 Thread Alvaro Herrera
CommandIds : to 64-bit. This is for enabling long transactions that really do that : much non-read-only work in one transaction. Question for Hans-Juergen and Zoltan: have you tested 8.3 and do you still see the need for this? -- Alvaro Herrerahttp

Re: [PATCHES] Snapshot management, final

2008-04-23 Thread Alvaro Herrera
Simon Riggs wrote: On Tue, 2008-04-22 at 18:13 -0400, Alvaro Herrera wrote: Simon Riggs wrote: OK, so it can;t be copied to a longer lived memory context? If you need that ability, please explain. No, I wish to prevent that, not enable it. I see. Sure, we don't have that problem

Re: [PATCHES] Snapshot management, final

2008-04-23 Thread Alvaro Herrera
to bed that SnapshotContext serves no useful purpose -- we can just remove it and store snaps in TopTransactionContext. -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support -- Sent via pgsql-patches

Re: [PATCHES] Snapshot management, final

2008-04-23 Thread Alvaro Herrera
because we want to free snapshots in a fell swoop at transaction abort. TopTransactionContext would be OK, as I just said in the parallel subthread. -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support

Re: [PATCHES] temporal version of generate_series()

2008-04-23 Thread Alvaro Herrera
H.Harada escribió: # This is my first time to send a patch. If I did something wrong, I appreciate your pointing me out. Brace positioning is off w.r.t. our conventions -- please fix that and resubmit. I have added this patch to the May commitfest. -- Alvaro Herrera

Re: [PATCHES] Improve shutdown during online backup, take 4

2008-04-23 Thread Alvaro Herrera
wondering if in PM_WAIT_BACKUP mode we should accept new connections from superusers only. -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes

Re: [PATCHES] Snapshot management, final

2008-04-23 Thread Alvaro Herrera
Alvaro Herrera wrote: FWIW I noticed yesterday after going to bed that SnapshotContext serves no useful purpose -- we can just remove it and store snaps in TopTransactionContext. ... which is what the attached patch does. -- Alvaro Herrerahttp

Re: [PATCHES] Removing NONSEG mode

2008-04-22 Thread Alvaro Herrera
. -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-patches

[PATCHES] Snapshot management, final

2008-04-22 Thread Alvaro Herrera
now explicitely Pop the ActiveSnapshot set by PortalRunUtility before calling CommitTransactionCommand. -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. snapshot-6.patch.bz2 Description: Binary data -- Sent via pgsql

Re: [PATCHES] Snapshot management, final

2008-04-22 Thread Alvaro Herrera
Simon Riggs wrote: On Tue, 2008-04-22 at 15:49 -0400, Alvaro Herrera wrote: - Three CopySnapshot call sites remain outside snapmgr.c: DoCopy() on copy.c, ExplainOnePlan() on explain.c and _SPI_execute_plan() on spi.c. They are there because they grab the current ActiveSnapshot, modify

Re: [PATCHES] Snapshot management, final

2008-04-22 Thread Alvaro Herrera
need that ability, please explain. -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your subscription: http

Re: [PATCHES] Snapshot management, final

2008-04-22 Thread Alvaro Herrera
Tom Lane wrote: Alvaro Herrera [EMAIL PROTECTED] writes: CopySnapshot always copies snapshots to SnapshotContext, which is a context that lives until transaction end. There's no mechanism for copying a snapshot into another context, because I don't see the need. The only reason we

Re: [PATCHES] Proposed patch - psql wraps at window width

2008-04-21 Thread Alvaro Herrera
. They are different and they should be displayed differently. -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your

Re: [PATCHES] Proposed patch - psql wraps at window width

2008-04-21 Thread Alvaro Herrera
Alvaro Herrera wrote: Bruce Momjian wrote: ! fputs(string_done ? : ; , fout); ! } } I think it's a bad idea to use the same : separator in the two

Re: [PATCHES] Testing pg_terminate_backend()

2008-04-21 Thread Alvaro Herrera
Magnus Hagander wrote: It's been running fine now for a number of hours, with output that looks similar to the stuff you posted. I'll leave it running.. Perhaps it would be a good idea to leave it running on code with some bugs on it, just to check if the problems show up. -- Alvaro Herrera

Re: [PATCHES] float4/float8/int64 passed by value with tsearch fixup

2008-04-19 Thread Alvaro Herrera
the change I introduced in the previous revision needs to be #ifdef'd out? -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your

Re: [PATCHES] Coding standards

2008-04-18 Thread Alvaro Herrera
Bryce Nesbitt wrote: Alvaro Herrera wrote: People [are] complaining here that we don't teach people here anyway, so hopefully my comments were still useful :-) Yes they are useful. As a new patcher, where should I look for coding standards? How about a little FAQ at the top

Re: [PATCHES] float4/float8/int64 passed by value with tsearch fixup

2008-04-18 Thread Alvaro Herrera
of float32, and thus the last usage of float32 gone, I am now wondering if it would be a good idea to remove the float32 and float32data definitions in c.h. Thanks to Zoltan for the patch. -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting

Re: [PATCHES] float4/float8/int64 passed by value with tsearch fixup

2008-04-18 Thread Alvaro Herrera
Alvaro Herrera wrote: With contrib/seg also adjusted to use float4 instead of float32, and thus the last usage of float32 gone, I am now wondering if it would be a good idea to remove the float32 and float32data definitions in c.h. Ok, the buildfarm is going yellow over this change

Re: [PATCHES] float4/float8/int64 passed by value with tsearch fixup

2008-04-18 Thread Alvaro Herrera
Tom Lane wrote: Alvaro Herrera [EMAIL PROTECTED] writes: I assume this is just some dumb portability mistake on my part ... or perhaps the fact that the functions are still using v0 fmgr convention? Since they're v0, they'd have to explicitly know about the pass-by-ref status of float4

Re: [PATCHES] float4/float8/int64 passed by value with tsearch fixup

2008-04-18 Thread Alvaro Herrera
prepared to do. I have asked the Cybertec guys for a patch. Since it's basically a copy of the float8 change, it should be easy to do. -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support -- Sent via

Re: [PATCHES] Testing pg_terminate_backend()

2008-04-18 Thread Alvaro Herrera
, a random integer between 0 and 32767 is generated. The sequence of random numbers may be initialized by assigning a value to RANDOM. If RANDOM is unset, it loses its special properties, even if it is subsequently reset. -- Alvaro

Re: [PATCHES] float4/float8/int64 passed by value with tsearchfixup

2008-04-18 Thread Alvaro Herrera
| 8.98215e-038 | 8.98215e-038 | | (144 rows) -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make

Re: [PATCHES] float4/float8/int64 passed by value with tsearchfixup

2008-04-18 Thread Alvaro Herrera
was that?). So there's definitely a platform dependency involved and not just you-missed-a-pointer-someplace. Huh, this was with the code with v0 conventions, right? I committed the change to v1 conventions a while ago. -- Alvaro Herrerahttp://www.CommandPrompt.com

Re: [PATCHES] Proposed patch - psql wraps at window width

2008-04-17 Thread Alvaro Herrera
close to | to be easily recognized. (Did you update your patch to use :. I didn't see ! in your patch.) I think we should use a different separator when there is an actual newline in the data. Currently we have a : there, so using a : here is probably not the best idea. -- Alvaro Herrera

Re: [PATCHES] Proposed patch - psql wraps at window width

2008-04-17 Thread Alvaro Herrera
. when alignment is not 'r'). I'm not seeing any checks for multibytes in there, but perhaps I'm missing it. * } else is forbidden too. Use two separate lines. -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. -- Sent via

Re: [PATCHES] Proposed patch - psql wraps at window width

2008-04-17 Thread Alvaro Herrera
:-) -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-patches

Re: [PATCHES] datum passed to macro which expects a pointer

2008-04-17 Thread Alvaro Herrera
Gavin Sherry wrote: Hi all, Attached are more fixes. Applied, thanks. -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org

  1   2   3   4   5   6   7   8   >