Re: [PATCHES] still alive?

2008-10-01 Thread Bruce Momjian
Peter Eisentraut wrote: Simon Riggs wrote: On Thu, 2008-09-11 at 15:39 +0300, Peter Eisentraut wrote: Bruce Momjian wrote: Abhijit Menon-Sen wrote: I thought -patches was supposed to die. What happened? I was wondering the same thing. Peter? Hmm, let's try this: Anyone who thinks

Re: [PATCHES] still alive?

2008-10-01 Thread Bruce Momjian
Marc, care to do the honors? --- Peter Eisentraut wrote: Simon Riggs wrote: On Thu, 2008-09-11 at 15:39 +0300, Peter Eisentraut wrote: Bruce Momjian wrote: Abhijit Menon-Sen wrote: I thought -patches was supposed

Re: [PATCHES] hash index improving v3

2008-09-24 Thread Bruce Momjian
this is really worth arguing about, much less exposing a separate parameter for. regards, tom lane -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-patches -- Bruce

Re: [PATCHES] still alive?

2008-09-06 Thread Bruce Momjian
Abhijit Menon-Sen wrote: I thought -patches was supposed to die. What happened? I was wondering the same thing. Peter? -- Bruce Momjian [EMAIL PROTECTED]http://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard drive, Christ

Re: [PATCHES] Add missing descriptions for aggregates, functions and conversions

2008-08-23 Thread Bruce Momjian
Bernd [ Attachment, skipping... ] -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-patches -- Bruce Momjian [EMAIL PROTECTED]http://momjian.us EnterpriseDB

[PATCHES] Re: [HACKERS] Solaris ident authentication using unix domain sockets

2008-08-22 Thread Bruce Momjian
any progress on an updated patch? -- Bruce Momjian [EMAIL PROTECTED]http://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard drive, Christ can be your backup. + -- Sent via pgsql-patches mailing list (pgsql-patches

Re: [PATCHES] pgbench minor fixes

2008-08-22 Thread Bruce Momjian
to your subscription: http://www.postgresql.org/mailpref/pgsql-patches -- Bruce Momjian [EMAIL PROTECTED]http://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard drive, Christ can be your backup. + -- Sent via pgsql-patches mailing

Re: [PATCHES] [HACKERS] Userset logging

2008-08-22 Thread Bruce Momjian
all the other logging functions? Patch enclosed. Patch applied, docs updated. -- Bruce Momjian [EMAIL PROTECTED]http://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard drive, Christ can be your backup. + -- Sent via pgsql

Re: [PATCHES] review: table function support

2008-08-22 Thread Bruce Momjian
content with the patch. applyed Regards and thank you very much Pavel -- marko [ Attachment, skipping... ] -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-patches -- Bruce

Re: [PATCHES] doc patch - archive/restore_command on windows

2008-07-18 Thread Bruce Momjian
) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-patches -- Bruce Momjian [EMAIL PROTECTED]http://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard drive, Christ can be your backup. + -- Sent via pgsql

Re: [PATCHES] doc patch - archive/restore_command on windows

2008-07-18 Thread Bruce Momjian
/listitem Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-patches -- Bruce Momjian [EMAIL PROTECTED]http

Re: [PATCHES] array_fill function

2008-07-15 Thread Bruce Momjian
[ Attachment, skipping... ] -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-patches -- Bruce Momjian [EMAIL PROTECTED]http://momjian.us EnterpriseDB

Re: [PATCHES] \d+ should display the storage options for columns

2008-07-14 Thread Bruce Momjian
Alvaro Herrera wrote: Bruce Momjian wrote: Update patch applied; I also adjusted some translation function calls. The new output of psql \d+ is: test= \d+ test Table public.test Column | Type | Modifiers | Storage | Description

Re: [PATCHES] [HACKERS] odd output in restore mode

2008-07-01 Thread Bruce Momjian
, based on these observations I think we need to learn more about the issues before making any changes to our code. -- Bruce Momjian [EMAIL PROTECTED]http://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard drive, Christ can

Re: [PATCHES] [HACKERS] TRUNCATE TABLE with IDENTITY

2008-07-01 Thread Bruce Momjian
-- Bruce Momjian [EMAIL PROTECTED]http://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard drive, Christ can be your backup. + -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your

Re: [PATCHES] LOCK_DEBUG documentation

2008-07-01 Thread Bruce Momjian
. -- Bruce Momjian [EMAIL PROTECTED]http://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard drive, Christ can be your backup. + -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your subscription: http

Re: [PATCHES] [NOVICE] encoding problems

2008-06-30 Thread Bruce Momjian
Cliff Nieuwenhuis wrote: On Fri, 9 May 2008 08:38:01 -0400 Alvaro Herrera [EMAIL PROTECTED] wrote: Bruce Momjian escribi?: Guillaume Smet wrote: On Thu, May 8, 2008 at 9:11 PM, Bruce Momjian [EMAIL PROTECTED] wrote: As I mentioned it before, is there any chance for this fix

Re: [PATCHES] Patch to change psql default banner v6

2008-06-30 Thread Bruce Momjian
that command line connection does. I'm volunteering to make them use the same methods :) David, I have fixed this problem with the attached, applied patch. Thanks for the observation. (The patch also removes a duplicate definition of parse_version().) -- Bruce Momjian [EMAIL PROTECTED

Re: [PATCHES] Explain XML patch

2008-06-27 Thread Bruce Momjian
on the need for documentation? As in documentation patches are *required* if your patch adds or changes user-visible behavior? Sure, but I do documentation updates for non-English speakers occasionally. -- Bruce Momjian [EMAIL PROTECTED]http://momjian.us EnterpriseDB

Re: [PATCHES] Fix pg_ctl restart bug

2008-06-26 Thread Bruce Momjian
Alvaro Herrera wrote: Bruce Momjian wrote: Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: However, as of 2004-10-15, this has not worked. :-( The attached patch is the one that caused the bug --- on non-Unix systems, SYSTEMQUOTE is , meaning zero-length string. I

Re: [PATCHES] Fix pg_ctl restart bug

2008-06-26 Thread Bruce Momjian
Bruce Momjian wrote: , meaning zero-length string. I should have seen the bug when I applied the contributed patch in 2004. So, shouldn't this fix be back-patched? Well, no one has actually complained about the breakage, and it has been a few years. Also

Re: [PATCHES] Fix pg_ctl restart bug

2008-06-26 Thread Bruce Momjian
Bruce Momjian wrote: I am attaching a minimal patch that will fix the bug in back branches. Keep in mind that a patched pg_ctl will not be able to restart a backend that was not patched. I think this patch will work for unpatched backends as well. I am still uncertain if it should

Re: [PATCHES] Fix pg_ctl restart bug

2008-06-26 Thread Bruce Momjian
Alvaro Herrera wrote: Bruce Momjian wrote: Alvaro Herrera wrote: Why do we need someone to complain? We know the bug is there. Has the code changed a lot in that area? Do we have the policy of backpatching every fix? I thought it was only the major bugs we fixed in back

Re: [PATCHES] [Fwd: Re: [HACKERS] pg_dump additional options for performance]

2008-06-26 Thread Bruce Momjian
Added to July patch queue. Thanks. --- Simon Riggs wrote: Re-sending post as discussed with Bruce... On Sun, 2008-03-23 at 12:45 -0300, Alvaro Herrera wrote: Bruce Momjian wrote: Added to TODO

[PATCHES] Removal of the patches email list

2008-06-26 Thread Bruce Momjian
only the hackers list. This will require email server changes and web site updates, and some people who are only subscribed to patches have to figure out if they want to subscribe to hackers. I have CC'ed hackers, patches, and www because this does affect all those lists. -- Bruce Momjian [EMAIL

Re: [PATCHES] Fix pg_ctl restart bug

2008-06-26 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: Alvaro Herrera wrote: I've always assumed that I'm supposed to backpatch the bugs I fix in HEAD, however far is reasonable. I thought we only backatched major bugs to prevent possible instability when fixing minor bugs

[PATCHES] Re: [BUGS] BUG #4128: The postmaster.opts.default file is begin ignored

2008-06-25 Thread Bruce Momjian
that you get the same options after a restart. No, it's the postmaster.opts.default file that I'm complaining about, not the postmaster.opts file. The attached applied patch removes the use of the postmaster.opts.default file by pg_ctl. -- Bruce Momjian [EMAIL PROTECTED]http

[PATCHES] Fix pg_ctl restart bug

2008-06-25 Thread Bruce Momjian
. The second attached applied patch fixes the problem. -- Bruce Momjian [EMAIL PROTECTED]http://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard drive, Christ can be your backup. + Index: src/backend/postmaster/postmaster.c

Re: [PATCHES] Fix pg_ctl restart bug

2008-06-25 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: However, as of 2004-10-15, this has not worked. :-( The attached patch is the one that caused the bug --- on non-Unix systems, SYSTEMQUOTE is , meaning zero-length string. I should have seen the bug when I applied the contributed

Re: [PATCHES] [HACKERS] Patch for Prevent pg_dump/pg_restore from being affected by statement_timeout

2008-06-24 Thread Bruce Momjian
Alex Hunsaker wrote: On Mon, Jun 23, 2008 at 4:51 PM, Bruce Momjian [EMAIL PROTECTED] wrote: I would like to get do this without adding a new --use-statement-timeout flag. Is anyone going to want to honor statement_timeout during pg_dump/pg_restore? I thought we were just going to disable

Re: [PATCHES] [HACKERS] Patch for Prevent pg_dump/pg_restore from being affected by statement_timeout

2008-06-24 Thread Bruce Momjian
Joshua D. Drake wrote: Alex Hunsaker wrote: On Mon, Jun 23, 2008 at 4:51 PM, Bruce Momjian [EMAIL PROTECTED] wrote: I would like to get do this without adding a new --use-statement-timeout flag. Is anyone going to want to honor statement_timeout during pg_dump/pg_restore? I thought we

Re: [PATCHES] Simplify formatting.c

2008-06-23 Thread Bruce Momjian
Bruce Momjian wrote: I am starting to think that the simplest case is to keep the single-copy version in there for single-byte encodings and not worry about the overhead of the multi-byte case. My new idea is if we pass the length to str_initcap, we can eliminate the string copy from

Re: [PATCHES] Simplify formatting.c

2008-06-23 Thread Bruce Momjian
. pg_locale.c? BTW, formatting.c and oracle_compat.c already include pg_locale.h. I researched this idea but is seems pg_locale.c contains only locale-specific stuff, while these functions have locale and non-locale versions; I ended up moving the common stuff into formatting.c. -- Bruce Momjian [EMAIL

Re: [PATCHES] [HACKERS] Patch for Prevent pg_dump/pg_restore from being affected by statement_timeout

2008-06-23 Thread Bruce Momjian
-statement-timeout flag. Is anyone going to want to honor statement_timeout during pg_dump/pg_restore? I thought we were just going to disable it. -- Bruce Momjian [EMAIL PROTECTED]http://momjian.us EnterpriseDB http://enterprisedb.com + If your life

Re: [PATCHES] [HACKERS] Patch for Prevent pg_dump/pg_restore from being affected by statement_timeout

2008-06-23 Thread Bruce Momjian
daveg wrote: On Mon, Jun 23, 2008 at 06:51:28PM -0400, Bruce Momjian wrote: Alex Hunsaker wrote: On Wed, Apr 16, 2008 at 4:54 PM, Alvaro Herrera [EMAIL PROTECTED] wrote: Joshua D. Drake escribi?: That is an interesting idea. Something like: pg_restore -E SET

Re: [PATCHES] Simplify formatting.c

2008-06-22 Thread Bruce Momjian
Bruce Momjian wrote: Actually it seems like the hard part is not so much the input representation as the output representation --- what should the base-level initcap routine return, to be reasonably efficient for both cases? I hadn't gotten to trying it out yet, but I can see the output

Re: [PATCHES] Simplify formatting.c

2008-06-21 Thread Bruce Momjian
Bruce Momjian wrote: Bruce Momjian wrote: Alvaro Herrera wrote: Bruce Momjian wrote: I moved str_initcap() over into oracle_compat.c and then had initcap() convert to/from TEXT to call it. The code is a little weird because str_initcap() needs to convert to text to use

Re: [PATCHES] Simplify formatting.c

2008-06-21 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: The third step is for oracle_compat.c::initcap() to use formatting.c::str_initcap(). You can see the result; patch attached (not applied). This greatly reduces the size of initcap(), with the downside that we are making two

Re: [PATCHES] Simplify formatting.c

2008-06-21 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: Tom Lane wrote: I'd say not. Can't we do some more refactoring and avoid so many useless conversions? Seems like str_initcap is the wrong primitive API --- the work ought to be done by a function that takes a char pointer

Re: [PATCHES] Simplify formatting.c

2008-06-18 Thread Bruce Momjian
Bruce Momjian wrote: Alvaro Herrera wrote: Bruce Momjian wrote: I moved str_initcap() over into oracle_compat.c and then had initcap() convert to/from TEXT to call it. The code is a little weird because str_initcap() needs to convert to text to use texttowcs(), so in multibyte

Re: [PATCHES] Simplify formatting.c

2008-06-17 Thread Bruce Momjian
Alvaro Herrera wrote: Bruce Momjian wrote: I moved str_initcap() over into oracle_compat.c and then had initcap() convert to/from TEXT to call it. The code is a little weird because str_initcap() needs to convert to text to use texttowcs(), so in multibyte encodings initcap converts

Re: [PATCHES] Simplify formatting.c

2008-06-13 Thread Bruce Momjian
, then to text to call texttowcs(). I didn't see a cleaner way to do this. -- Bruce Momjian [EMAIL PROTECTED]http://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard drive, Christ can be your backup. + Index: src/backend/utils/adt

Re: [PATCHES] [HACKERS] Upcoming back-branch update releases

2008-05-29 Thread Bruce Momjian
see it on pgsql-commiters. No. I have not backpatched it because Tom found a problem with my applied patch and did a second patch. I am attaching both patches. The second one is Tom's and I don't understand it well enough to backpatch it. -- Bruce Momjian [EMAIL PROTECTED]http

[PATCHES] Simplify formatting.c

2008-05-19 Thread Bruce Momjian
Now that upper/lower/initcase do not modify the passed string, I have simplified formatting.c with the attached patch. -- Bruce Momjian [EMAIL PROTECTED]http://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard drive, Christ can

Re: [PATCHES] [HACKERS] use of pager on Windows psql

2008-05-18 Thread Bruce Momjian
did the isatty() addition fix this? Was the pager being used on Win32 for the regression tests and somehow eating a line or something? -- Bruce Momjian [EMAIL PROTECTED]http://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard

Re: [PATCHES] [COMMITTERS] pgsql: Don't call rm with empty file list.

2008-05-17 Thread Bruce Momjian
the attached patch to fix it, but your example on the line above was very helpful. -- Bruce Momjian [EMAIL PROTECTED]http://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard drive, Christ can be your backup. + Index: src/nls

Re: [PATCHES] [HACKERS] use of pager on Windows psql

2008-05-17 Thread Bruce Momjian
to remove the Win32 test in both places. I was wrong about \g filename changing stdout, I think. It keeps stdout but uses a different output stream. I am just unsure, given all the features of psql, wether it could change stdin/stdout while running in some way. -- Bruce Momjian [EMAIL PROTECTED

Re: [PATCHES] lc_time and localized dates

2008-05-17 Thread Bruce Momjian
] --- Euler Taveira de Oliveira wrote: Bruce Momjian wrote: Euler, have you updated this patch yet? Here is an updated patch. It follows the Oracle behaviour and uses a cache mechanism to avoid calling setlocale() all the time. I unified the localized_* and str_

Re: [PATCHES] libpq thread-locking

2008-05-16 Thread Bruce Momjian
Magnus Hagander wrote: Bruce Momjian wrote: Bruce Momjian wrote: Magnus Hagander wrote: Attached patch adds some error checking to the thread locking stuff in libpq. Previously, if thread locking failed for some reason, we would just fall through and do things without locking

Re: [PATCHES] Fix for psql pager computations

2008-05-16 Thread Bruce Momjian
Bruce Momjian wrote: The attached patch causes psql to use the pager if newlines or 'format=wrapped' has caused a single row to span more than one line and the output is then too long for the screen. It also uses the pager if psql thinks the data will wrap off the edge of the screen

Re: [PATCHES] Patch to change psql default banner v6

2008-05-16 Thread Bruce Momjian
Bruce Momjian wrote: OK, here is the mega-print: $ psql test psql (8.4devel, server 8.4devel) WARNING: psql version 8.4, server version 8.4. Some psql features might not work. WARNING: Console code page (44) differs from Windows code page (55

Re: [PATCHES] Patch to change psql default banner v6

2008-05-15 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: Ah, OK. I had forgotten. Here is the new output: $ sql test psql (8.4devel) Type help for help. test= help You are being unreasonably cryptic here. What happens when there is optional output --- ie

Re: [PATCHES] Patch to change psql default banner v6

2008-05-15 Thread Bruce Momjian
commit the thing. Your patch is getting the same review any other patch would have. If you want someone else to apply it I will stop working on it. -- Bruce Momjian [EMAIL PROTECTED]http://momjian.us EnterpriseDB http://enterprisedb.com + If your life

Re: [PATCHES] Patch to change psql default banner v6

2008-05-15 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: Oh, good point. Let me look at that. Thanks. You prefer: $ sql test psql (8.4devel) Type help for help. test= help Well, the question is still where is the optional info going to go? I think what I'd

Re: [PATCHES] Patch to change psql default banner v6

2008-05-15 Thread Bruce Momjian
banner. -- Bruce Momjian [EMAIL PROTECTED]http://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard drive, Christ can be your backup. + -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your

Re: [PATCHES] Patch to change psql default banner v6

2008-05-15 Thread Bruce Momjian
not work. Type help for help. test= By indenting those messages the 'help' message still stands out. Adjustments? -- Bruce Momjian [EMAIL PROTECTED]http://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard drive

Re: [PATCHES] Patch to change psql default banner v6

2008-05-15 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: With major version mismatches it looks like this: $ psql test psql (8.4devel) SSL connection (cipher: 2343, bits: 512) WARNING: Console code page (323) differs from Windows code page (2323

Re: [PATCHES] Patch to change psql default banner v6

2008-05-15 Thread Bruce Momjian
. If this option is used, none of this happens. This is useful with the -c option. Within psql you can also set the QUIET variable to achieve the same effect. You could then use \echo in .psqlrc to make your own banner. -- Bruce Momjian [EMAIL PROTECTED

Re: [PATCHES] libpq object hooks

2008-05-14 Thread Bruce Momjian
but not document them. This way, we can modify or remove the API as needed in the future. As libpqtypes matures and we are sure what the API should be, we can document it as stable and permanent. -- Bruce Momjian [EMAIL PROTECTED]http://momjian.us EnterpriseDB

[PATCHES] Fix for psql pager computations

2008-05-14 Thread Bruce Momjian
. -- Bruce Momjian [EMAIL PROTECTED]http://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard drive, Christ can be your backup. + Index: doc/src/sgml/ref/psql-ref.sgml

Re: [PATCHES] Patch to change psql default banner v6

2008-05-14 Thread Bruce Momjian
put the version number in parentheses so it wouldn't be as prominent. Updated patch attached. -- Bruce Momjian [EMAIL PROTECTED]http://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard drive, Christ can be your backup. + Index

Re: [PATCHES] Patch to change psql default banner v6

2008-05-14 Thread Bruce Momjian
is applied I will update psql banner examples in our documentation. -- Bruce Momjian [EMAIL PROTECTED]http://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard drive, Christ can be your backup. + -- Sent via pgsql-patches mailing

Re: [PATCHES] Patch to change psql default banner v6

2008-05-14 Thread Bruce Momjian
Alvaro Herrera wrote: Bruce Momjian wrote: If you type 'help' it just repeats the startup banner suggestion: test= help You are using psql, the command-line interface to PostgreSQL. Type \? for help. I think we wanted to have more information in 'help', not less

Re: [PATCHES] Patch to change psql default banner v6

2008-05-14 Thread Bruce Momjian
Alvaro Herrera wrote: Bruce Momjian wrote: I know we decided not to do that, but I am trying to figure out what the goal if 'help' is? To display the most frequently-used help commands? Aren't they at the top of \?. The purpose of 'help' is to provide useful help. If it only says

Re: [PATCHES] Patch to change psql default banner v6

2008-05-14 Thread Bruce Momjian
Alvaro Herrera wrote: Bruce Momjian wrote: My question is whether we agreed that suggesting help as the best way to get help was what we agreed upon? If we did, I forgot. I thought the 'help' ideas was just for people who forgot the help commands. Please review the previous

Re: [PATCHES] Patch to change psql default banner v6

2008-05-14 Thread Bruce Momjian
Joshua D. Drake wrote: Bruce Momjian wrote: Alvaro Herrera wrote: Bruce Momjian wrote: My question is whether we agreed that suggesting help as the best way to get help was what we agreed upon? If we did, I forgot. I thought the 'help' ideas was just for people who forgot the help

Re: [PATCHES] Patch to change psql default banner v6

2008-05-14 Thread Bruce Momjian
Joshua D. Drake wrote: Bruce Momjian wrote: test= \? General \copyright show PostgreSQL usage and distribution terms \g [FILE] or ; send query buffer to server (and results to file or |pipe) \h [NAME] help on syntax of SQL commands

Re: [PATCHES] Replace offnum++ by OffsetNumberNext

2008-05-13 Thread Bruce Momjian
)); -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-patches -- Bruce Momjian [EMAIL PROTECTED]http://momjian.us EnterpriseDB http://enterprisedb.com

Re: [PATCHES] libpq object hooks

2008-05-13 Thread Bruce Momjian
on this. -- Bruce Momjian [EMAIL PROTECTED]http://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard drive, Christ can be your backup. + -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your

Re: [HACKERS] [PATCHES] [NOVICE] encoding problems

2008-05-09 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: Guillaume Smet wrote: I understand your point of view but I really think it's more a regression fix than a behavior change. If I can get other hackers to say we should backpatch we can consider it. Well, 8.3 is already

Re: [PATCHES] Replace offnum++ by OffsetNumberNext

2008-05-09 Thread Bruce Momjian
the argument. These macros look pointless * but they help us disambiguate the different manipulations on * OffsetNumbers (e.g., sometimes we subtract one from an * OffsetNumber to move back, and sometimes we do so to form a * real C array index). -- Bruce Momjian [EMAIL

Re: [PATCHES] [PATCH] sh: Add support Renesas SuperH

2008-05-09 Thread Bruce Momjian
subscription: http://www.postgresql.org/mailpref/pgsql-patches -- Bruce Momjian [EMAIL PROTECTED]http://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard drive, Christ can be your backup. + -- Sent via pgsql-patches mailing list (pgsql

Re: [PATCHES] Database owner installable modules patch

2008-05-09 Thread Bruce Momjian
[ Attachment, skipping... ] -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-patches -- Bruce Momjian [EMAIL PROTECTED]http://momjian.us EnterpriseDB

Re: [PATCHES] libpq thread-locking

2008-05-08 Thread Bruce Momjian
) -- Bruce Momjian [EMAIL PROTECTED]http://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard drive, Christ can be your backup. + -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your

Re: [PATCHES] libpq thread-locking

2008-05-08 Thread Bruce Momjian
Bruce Momjian wrote: Magnus Hagander wrote: Attached patch adds some error checking to the thread locking stuff in libpq. Previously, if thread locking failed for some reason, we would just fall through and do things without locking. This patch makes us abort() instead. It's

Re: [PATCHES] [NOVICE] encoding problems

2008-05-08 Thread Bruce Momjian
Applied. --- Bruce Momjian wrote: Alvaro Herrera wrote: Bruce Momjian wrote: Alvaro Herrera wrote: Surely psql computes the width of all cells before printing anything. It does, but if you have a value

Re: [PATCHES] [HACKERS] bug in numeric_power() function

2008-05-08 Thread Bruce Momjian
Applied. --- Bruce Momjian wrote: Alvaro Herrera wrote: Bruce Momjian wrote: Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: I have developed the attached patch which fixes 0 ^ 123.3. Did you

Re: [PATCHES] [NOVICE] encoding problems

2008-05-08 Thread Bruce Momjian
Guillaume Smet wrote: On Thu, May 8, 2008 at 9:11 PM, Bruce Momjian [EMAIL PROTECTED] wrote: Applied. As I mentioned it before, is there any chance for this fix to be backported to 8.3 branch? IMHO it's a usability regression. No, we don't change behaviors in back branches unless we get

Re: [PATCHES] [NOVICE] encoding problems

2008-05-08 Thread Bruce Momjian
Guillaume Smet wrote: On Fri, May 9, 2008 at 4:38 AM, Bruce Momjian [EMAIL PROTECTED] wrote: No, we don't change behaviors in back branches unless we get lots of complaints, and we haven't in this case. I suspect it's annoying for a lot of people, just not annoying enough to make them

Re: [PATCHES] [NOVICE] encoding problems

2008-05-07 Thread Bruce Momjian
is that we are never sure of the display width of tab because we don't know what tab stop we are at. With '\x09' we knew exactly how wide it was. -- Bruce Momjian [EMAIL PROTECTED]http://momjian.us EnterpriseDB http://enterprisedb.com + If your life

Re: [PATCHES] [NOVICE] encoding problems

2008-05-07 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: I have implemented the following patch which outputs tab as a tab. It also assumes a tab has a width of 4, which is its average width: That pretty much completely sucks; it will undo all the hard work we've put into nice formatting

Re: [PATCHES] [NOVICE] encoding problems

2008-05-07 Thread Bruce Momjian
Alvaro Herrera wrote: Bruce Momjian wrote: Even if we knew the column position at output time, when we are doing aligned column width computations, we don't know the width of the previous columns so we would have no way to know how far the tab would extend in the current column

Re: [PATCHES] [NOVICE] encoding problems

2008-05-07 Thread Bruce Momjian
Alvaro Herrera wrote: Bruce Momjian wrote: Alvaro Herrera wrote: If you start counting every line from the start of the current column, it will align correctly regardless of the previous columns. At this stage you don't know the width of previous columns because you don't know

Re: [PATCHES] [NOVICE] encoding problems

2008-05-07 Thread Bruce Momjian
Alvaro Herrera wrote: Bruce Momjian wrote: Alvaro Herrera wrote: Surely psql computes the width of all cells before printing anything. It does, but if you have a value that has a tab, how do you know what tab stop you are on because you don't know the final width of the previous

Re: [PATCHES] [HACKERS] bug in numeric_power() function

2008-05-07 Thread Bruce Momjian
? -- 1 (1 row) test= select 0 ^ 0.0; ?column? -- 1 (1 row) test= select 0 ^ 3.4; ?column? -- 1 (1 row) -- Bruce Momjian

Re: [PATCHES] [NOVICE] encoding problems

2008-05-07 Thread Bruce Momjian
Alvaro Herrera wrote: Bruce Momjian wrote: Alvaro Herrera wrote: Surely psql computes the width of all cells before printing anything. It does, but if you have a value that has a tab, how do you know what tab stop you are on because you don't know the final width of the previous

Re: [PATCHES] [GENERAL] pgbench not setting scale size correctly?

2008-05-07 Thread Bruce Momjian
on the database is after all the other parsing because the connection has to be brought up first. Yeah. But couldn't we have that part issue a warning if -s had been set on the command line? Patch attached that issues a warning. -- Bruce Momjian [EMAIL PROTECTED]http://momjian.us

Re: [PATCHES] [HACKERS] bug in numeric_power() function

2008-05-07 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: I have developed the attached patch which fixes 0 ^ 123.3. Did you actually read the wikipedia entry you cited? Yes: The evaluation of 0^0 presents a problem, because different mathematical reasoning leads to different results

Re: [PATCHES] [HACKERS] bug in numeric_power() function

2008-05-07 Thread Bruce Momjian
Alvaro Herrera wrote: Bruce Momjian wrote: Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: I have developed the attached patch which fixes 0 ^ 123.3. Did you actually read the wikipedia entry you cited? But that's about 0^0, not about 0^123.3. See this other subsection

Re: [PATCHES] [HACKERS] bug in numeric_power() function

2008-05-07 Thread Bruce Momjian
Alvaro Herrera wrote: Bruce Momjian wrote: Ah, got it, and I updated the patch to remove the commment about discrete. The page also says that 0^x is undefined when x is negative, not sure about that one but I don't see it in your patch. That one was already handled: test

Re: [PATCHES] [HACKERS] [GENERAL] psql \pset pager

2008-05-06 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: Tom Lane wrote: If we're going to change it, we should make it match GUC's parse_bool, which has had some actual thought put into it. Good idea. Do I copy the C code into /psql or somehow share the function? Just copy

Re: [PATCHES] [BUGS] BUG #3975: tsearch2 index should not bomb out of 1Mb limit

2008-05-06 Thread Bruce Momjian
--- Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: Tom Lane wrote: I don't think that follows. A tsearch index is lossy anyway, so there's Uh, the index is lossy but I thought it was lossy in a way that just required additional heap accesses

Re: [HACKERS] Re: [PATCHES] a tsearch2 (8.2.4) dictionary that only filters out stopwords

2008-05-06 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: Added to TODO: * Allow text search dictionary to filter out only stop words http://archives.postgresql.org/pgsql-patches/2007-11/msg00081.php That's a poor description. I thought the TODO was something more like allow

Re: [PATCHES] [HACKERS] Proposed patch - psql wraps at window width

2008-04-29 Thread Bruce Momjian
Bryce Nesbitt wrote: Bruce Momjian wrote: I have updated the documentation for this patch. I consider it ready to apply. I think it is as close to a middle ground as we are going to get. Further adjustment will have to happen when we have more reports from the field. I heard a pretty

Re: [PATCHES] [HACKERS] Proposed patch - psql wraps at window width

2008-04-28 Thread Bruce Momjian
. --- Bruce Momjian wrote: I have moved this discussion to hackers in hopes of getting more feedback, and moved the patch to a static URL: ftp://momjian.us/pub/postgresql/mypatches/wrap This patch adds a new '\pset format wrapped' mode that wraps long values to fit the table

Re: [PATCHES] 64-bit CommandIds

2008-04-24 Thread Bruce Momjian
?n B?sz?rm?nyi Cybertec Sch?nig Sch?nig GmbH http://www.postgresql.at/ -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your Subscription: http://mail.postgresql.org/mj/mj_wwwusr?domain=postgresql.orgextra=pgsql-patches -- Bruce Momjian

Re: [PATCHES] Sun Studio on Linux spinlock patch

2008-04-24 Thread Bruce Momjian
subscription: http://www.postgresql.org/mailpref/pgsql-patches -- Bruce Momjian [EMAIL PROTECTED]http://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard drive, Christ can be your backup. + -- Sent via pgsql-patches mailing list

Re: [PATCHES] 64-bit CommandIds

2008-04-24 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: So, is this an option we want for configure? I think the case for it got a whole lot weaker in 8.3, with lazy consumption of CIDs. If someone had tables big enough to make the 32-bit-CID limit still be a problem despite that fix, I'd

Re: [PATCHES] Patch to change psql default banner v6

2008-04-23 Thread Bruce Momjian
)); + fprintf(output, _( \\g or ;execute query\n\n)); If you want I can look at reorganizing the \? help. I have a larger reorganization mind. -- Bruce Momjian [EMAIL PROTECTED]http://momjian.us EnterpriseDB http://enterprisedb.com

Re: [PATCHES] Proposed patch - psql wraps at window width

2008-04-21 Thread Bruce Momjian
this warning compiling: print.c:784: warning: pointer targets in passing argument 1 of ?mb_strlen_max_width? differ in signedness And I did have trouble applying the patch -- I had to manually give it the filename, and tell it to reverse the patch. OK, fixed. -- Bruce Momjian [EMAIL

  1   2   3   4   5   6   7   8   9   10   >