Hi all,
Attached are more fixes.
Thanks,
Gavin, with Feng Tian
Index: src/backend/access/common/heaptuple.c
===
RCS file: /Users/swm/pgsql-cvs/pgsql/src/backend/access/common/heaptuple.c,v
retrieving revision 1.120
diff -c -p -r1.12
On Sun, Apr 13, 2008 at 01:42:02AM +0100, Gregory Stark wrote:
> "Gavin Sherry" <[EMAIL PROTECTED]> writes:
>
> > On Sat, Apr 12, 2008 at 07:07:48PM -0400, Tom Lane wrote:
> >> Gavin Sherry <[EMAIL PROTECTED]> writes:
> >> > I wish. It was ac
On Sat, Apr 12, 2008 at 07:07:48PM -0400, Tom Lane wrote:
> Gavin Sherry <[EMAIL PROTECTED]> writes:
> > I wish. It was actually thrown up when we (Greenplum) changed the macros
> > to be inline functions as part of changing Datum to be 8 bytes.
>
> Hmmm ... Datum has
On Sat, Apr 12, 2008 at 06:02:39PM -0400, Tom Lane wrote:
> Gavin Sherry <[EMAIL PROTECTED]> writes:
> > This may seem a little pedantic but I noticed a few places where we pass
> > a datum to a macro which treats the datum as a pointer. This works now
> > but might
This may seem a little pedantic but I noticed a few places where we pass
a datum to a macro which treats the datum as a pointer. This works now
but might not in the future (if, say, Datum were to be 8 bytes).
Thanks,
Gavin
Index: src/backend/utils/adt/varlena.c
===
On Tue, Feb 26, 2008 at 02:43:51PM +, Simon Riggs wrote:
> Following patch implements a simple mechanism to keep a buffer pinned
> while we are bulk loading.
>
CK Tan and I worked on something similar but the problem we discovered
was self locking. Consider a primary key: we insert a tuple in
On Mon, 12 Mar 2007, Heikki Linnakangas wrote:
> Here's a patch to change the amgetmulti API so that it's called only
> once per scan, and the indexam adds *all* matching tuples at once to a
> caller-supplied TIDBitmap. Per Tom's proposal in July 2006:
> http://archives.postgresql.org/pgsql-hacker
Teodor,
On Mon, 12 Mar 2007, Teodor Sigaev wrote:
> I don't very like GiST changes: gistgetbitmap will lock/unlock page for every
> tuple. It seems to me taht is better to change gistnext function to use some
> sort callback, for example. Or have static array for tids in gistgetbitmap...
Good p
Hi all,
I've updated the bitmap index patch. It can be found here:
http://www.alcove.com.au/~swm/bitmap-2007-03-12.diff
This fixes some bugs introduced in the last patch, catches up to HEAD and
tidies up the executor code. I want to do a little more tidying, such as
reverting the name changes we
On Wed, 28 Feb 2007, John Bartlett wrote:
> Hi,
>
> A list of ctids is stored in the file.
I would have thought these would be stored in memory. If the set got
large, you'd use a temporary file the way other systems which overflow to
disk do?
>
> The file is used to store the ctids during an upd
On Thu, 25 Jan 2007, Tom Lane wrote:
> Gavin Sherry <[EMAIL PROTECTED]> writes:
> > I was talking to AndrewSN on irc about this. He proposed that we supply
> > two versions (yes I hear the collective groan) of the SQL functions: a
> > fast one (SnapshotNow) and an accu
On Wed, 24 Jan 2007, Tom Lane wrote:
> Andrew Dunstan <[EMAIL PROTECTED]> writes:
> > FAST PostgreSQL wrote:
> >> Please find attached the patch with modifications
>
> > are you proposing to implement the other functions in this TODO item
> > (pg_get_acldef(), pg_get_typedefault(), pg_get_attrdef(
On Thu, 25 Jan 2007, Tom Lane wrote:
> Bruce Momjian <[EMAIL PROTECTED]> writes:
> > Tom Lane wrote:
> >> ... convincing use-case that will justify the maintenance load we
> >> are setting up for ourselves. "Somebody might want this" is not
> >> adequate.
>
> > I realize it is problem to have the
I accidentally forgot to copy pgsql-patches earlier...
On Fri, 19 Jan 2007, Tom Lane wrote:
> Gavin Sherry <[EMAIL PROTECTED]> writes:
> > Also, some of the equivalence class support code is O(n^2).
>
> Yeah, at least :-(. But I find it hard to conceive of real-world
On Tue, 9 Jan 2007, Bruce Momjian wrote:
> Gavin Sherry wrote:
> > On Tue, 9 Jan 2007, L Bayuk wrote:
> >
> > > The attached patch against PostgreSQL-8.2.1 was discussed on [INTERFACES].
> > > It fixes bcc32.mak makefiles for the Borland BCC compiler to build libp
On Tue, 9 Jan 2007, L Bayuk wrote:
> The attached patch against PostgreSQL-8.2.1 was discussed on [INTERFACES].
> It fixes bcc32.mak makefiles for the Borland BCC compiler to build libpq
> and psql*. There are also changes to some header files to hide some things
> BCC doesn't like.
>
> *Note: psq
On Sun, 7 Jan 2007, Tom Lane wrote:
> Peter Eisentraut <[EMAIL PROTECTED]> writes:
> > Tom Lane wrote:
> >> Perhaps even more to the point, what makes you think that someone
> >> will notice the warning? If the docs build is one step in an
> >> automated build process, this seems unlikely.
>
> >
On Wed, 27 Dec 2006, Heikki Linnakangas wrote:
> Gavin Sherry wrote:
> > There are still some things Jie and I have not gotten to yet:
> > ...
> > o Test WAL replay more thoroughly.
>
> Found one WAL related bug:
>
> postgres=# CREATE TABLE test (i int);
> C
Hi all,
I was fidding around in the backend and defined SHOW_MEMORY_STATS. With
this defined, we refer to the variable ShowStats which no longer exists
AFAICT (when did it?).
Patch simply removed the reference.
Thanks,
GavinIndex: src/backend/tcop/postgres.c
On Tue, 5 Dec 2006, Heikki Linnakangas wrote:
> Gavin Sherry wrote:
> > o Improving VACUUM support -- currently, VACUUM FULL means REINDEX for
> > bitmaps. Heikki Linnakangas offered to work on this. Heikki, are you
> > still interested?
>
> BTW vacuuming
On Mon, 4 Dec 2006, Heikki Linnakangas wrote:
> > o Test WAL replay more thoroughly.
>
> I've had that problem too with a lot of things I've hacked. I've used a
> shell script that does the operation under test, runs a select, kills
> and restarts postmaster, and reruns the select. If the select a
On Mon, 4 Dec 2006, Simon Riggs wrote:
> On Tue, 2006-12-05 at 00:18 +1100, Gavin Sherry wrote:
>
> > o Determine if we need to provide anything for rm_startup, rm_cleanup,
> > rm_safe_restartpoint RmgrData function pointers.
>
> safe_restartpoint gives true/false base
On Tue, 5 Dec 2006, Gavin Sherry wrote:
> On Thu, 30 Nov 2006, Tom Lane wrote:
>
> > Gavin Sherry <[EMAIL PROTECTED]> writes:
> > > I wonder if we should check if the role exists for the other
> > > authentication methods too? get_role_line() should be v
On Mon, 18 Sep 2006, Jie Zhang wrote:
> Hi all,
>
> It seems that my previous email to pgsql-hackers about the latest bitmap
> index patch did not go through. Please find the latest patch in the
> attachment. Any suggestions and comments are appreciated.
>
> This patch is generated against the Pos
On Fri, 4 Aug 2006, Michael Glaesemann wrote:
> On Aug 3, 2006, at 23:58 , Tom Lane wrote:
>
>
> > Should we give VALUES its own reference page? That doesn't quite
> > seem helpful either.
> >
>
> I think we should go for a separate reference page, as VALUES appears
> to be expanding quite a bit.
On Thu, 3 Aug 2006, Tom Lane wrote:
> Gavin Sherry <[EMAIL PROTECTED]> writes:
> > Docs and regression tests attached.
>
> I've applied the regression tests (with a few additions), but I'm
> feeling dissatisfied with this approach to documenting VALUES.
> It
Docs and regression tests attached.
One slightly annoying thing is this:
---
regression=# declare foo cursor with hold for VALUES(1,2), (3, 4);
DECLARE CURSOR
regression=# declare foo2 cursor with hold for (VALUES(1,2), (3, 4)) as
foo(i, j);
ERROR: syntax error at or near "as"
LINE 1: ...e foo2
On Tue, 1 Aug 2006, Joe Conway wrote:
> Gavin Sherry wrote:
> > Is this intentional:
> >
> > template1=# values(1), (2);
> > column1
> > -
> >1
> >2
> > (2 rows)
> >
> > This is legal because of:
> >
>
Tom,
Is this intentional:
template1=# values(1), (2);
column1
-
1
2
(2 rows)
This is legal because of:
simple_select:
/* ... */
| values_clause { $$ = $2; }
Also, I am working out some docs and regression tests.
Gavin
--
I sent the following through earlier but I think the attachment was too
large (thought that was limit was greatly increased?).
You can download the patch here:
http://www.alcove.com.au/~swm/bitmap-2.diff
Thanks,
Gavin
--
Hi all,
Attached is an update to the patch implementing
On Sun, 30 Jul 2006, Alvaro Herrera wrote:
> Gavin Sherry wrote:
> > The docs say:
> >
> > "When a transaction is read-only, the following SQL commands are
> > disallowed: INSERT, UPDATE, DELETE, and COPY TO"
> >
> > Actually, COPY FRO
The docs say:
"When a transaction is read-only, the following SQL commands are
disallowed: INSERT, UPDATE, DELETE, and COPY TO"
Actually, COPY FROM is the command we disallow. This must have been
overlooked when the read-only error was fixed in the COPY code.
Pointed out by Arul Shaji at Fujitsu
On Wed, 28 Sep 2005, Tom Lane wrote:
> I wrote:
> > The only other thing that's been discussed is the SQL2003 syntax
> > NEXT VALUE FOR sequencename
> > but this is in fact just syntactic sugar for something functionally
> > equivalent to nextval('sequencename'::regclass).
>
> I have to take t
Attached is a patch adding regression tests for this code.
Thanks,
Gavin
On Tue, 23 Aug 2005, Bruce Momjian wrote:
>
> Thanks, modified patch applied by Tom, with the addition of a USER
> triggers only mode.
>
> ---
>
> Sat
On Thu, 11 Aug 2005, Andrew Dunstan wrote:
>
>
> Gavin Sherry wrote:
>
> >>Or more than one hardware architecture (which you didn't even say what
> >>you tested...)
> >>
> >>
> >
> >Well, he tested on SunOS (!) and Linux -- I
On Thu, 11 Aug 2005, Tom Lane wrote:
> Gavin Sherry <[EMAIL PROTECTED]> writes:
> > On Thu, 11 Aug 2005, Qingqing Zhou wrote:
> >> It is said that the BufferBlockPointers is used to speedup the
> >> BufferGetBlock() macro. I compared three ways of getting block po
On Thu, 11 Aug 2005, Qingqing Zhou wrote:
> It is said that the BufferBlockPointers is used to speedup the
> BufferGetBlock() macro. I compared three ways of getting block pointers.
> I.e., existing method (arrary method), calculating block pointer by adding
> base addr and offset*blockid method (
On Wed, 27 Jul 2005, Tom Lane wrote:
> Gavin Sherry <[EMAIL PROTECTED]> writes:
> > I ran across this yesterday on HEAD:
>
> > template1=# grant select on foo, foo to swm;
> > ERROR: tuple already updated by self
>
> Seems to fail similarly in every version
Hi all,
This patch removes dead code from redo_dbase(). The code processes
CREATE/DROP DATABASE recovery records which are of types
XLOG_DBASE_CREATE_OLD and XLOG_DBASE_DROP_OLD. We do not create such
records.
I've removed XLOG_DBASE_CREATE_OLD and XLOG_DBASE_DROP_OLD from the header
as well but
On Fri, 1 Jul 2005, Satoshi Nagayasu wrote:
> Hi,
>
> Gavin Sherry wrote:
> > Hmmm.. just thinking about it for a second. I wonder if we should also
> > support:
> >
> > ALTER TABLE DISABLE TRIGGERS
>
> I found some RDBMSes are supporting 'DISABLE TR
On Fri, 1 Jul 2005, Satoshi Nagayasu wrote:
> Hi all,
>
> Here is a first patch to allow these commands.
>
> > ALTER TABLE ENABLE TRIGGER
> > ALTER TABLE DISABLE TRIGGER
>
Hmmm.. just thinking about it for a second. I wonder if we should also
support:
ALTER TABLE DISABLE TRIGGERS
which woul
On Fri, 1 Jul 2005, Satoshi Nagayasu wrote:
> Hi all,
>
> Here is a first patch to allow these commands.
>
> > ALTER TABLE ENABLE TRIGGER
> > ALTER TABLE DISABLE TRIGGER
There are three other areas which are worth looking at:
a) We may defer the execution of some triggers to the end of the
t
On Sat, 4 Jun 2005, Bruce Momjian wrote:
>
> I am thinking some day we will need:
>
> ALTER SCHEMA ... SET NEW TABLESPACE
>
> and
>
> ALTER SCHEMA ... SET CURRENT TABLESPACE
>
> to specify if existing objects are moved, but at this point we aren't
> going to get the later in 8.1, so I
Diff to the HTML version attached.
I'm assuming that you have a script to dump the text version, so I haven't
sent a diff against the text version. Note that I have made a few more
changes since the last diff.
Thanks,
Gavin--- doc/src/FAQ/FAQ_DEV.html
+++ doc/src/FAQ/FAQ_DEV.html
@@ -1,9 +1,9 @@
in doc/src/FAQ/.
>
> -------
>
> Gavin Sherry wrote:
> > Hi all,
> >
> > An initial look at bring the developer's FAQ up to date and reworking some
> > text to make it more useful.
> >
> > Thanks
Hi all,
Attached is a patch which checks early on in pg_start_back() that
archive_command is defined and if not generates an error. This seemed like
a reason foot gun prevention measure.
Gavin# Old manifest: 2910f7d05f74e086c097595fe8cc78ad728474e4
# New manifest: 1b0c1a705781c50c81f1e0a3e6c5e89b
Hi all,
An initial look at bring the developer's FAQ up to date and reworking some
text to make it more useful.
Thanks,
Gavin# Old manifest: 2910f7d05f74e086c097595fe8cc78ad728474e4
# New manifest: f4a4fb1871edfc75efcfa80ade602e36463909f0
# Summary of changes:
#
# patch doc/FAQ_DEV
#from
Robert,
I think there are some mistakes with your addition. Here's a reworked
paragraph:
---
This is a list of items which have been put to or discussed by
contributors to the project. Many items have been discussed extensively on
the mailing lists, the archives of which can be found here:
http:/
Just some docs enhancements based on feedback I received from a few recent
talks on PITR.
Thanks,
Gavin--- doc/src/sgml/backup.sgml
+++ doc/src/sgml/backup.sgml
@@ -379,7 +379,7 @@
- On-line backup and point-in-time recovery
+ On-line backup and point-in-time recovery (PITR)
o
On Wed, 3 Nov 2004, Bruce Momjian wrote:
> Tom Lane wrote:
> > Bruce Momjian <[EMAIL PROTECTED]> writes:
> > >> I think Tom's fix adequately addresses the security concerns. Exactly
> > >> what is wrong with writing to the current working directory?
> >
> > > Because it could be run from a directo
On Thu, 23 Sep 2004, Tom Lane wrote:
> Neil Conway <[EMAIL PROTECTED]> writes:
> > On Wed, 2004-09-22 at 23:00, Alvaro Herrera wrote:
> >> Could that include supporting SELECT INTO as well as both types of
> >> CREATE TABLE AS?
>
> > Right; my thinking is to have the parser construct SELECT INTO
On Mon, 30 Aug 2004, Andreas Pflug wrote:
> Gavin Sherry wrote:
>
> >>The attached patch contributes:
> >>
> >>- database_size(name)
> >>- relation_size(text)
> >
> >
> > I sent in a dbsize patch to make these functions tablespace aware.
On Sun, 29 Aug 2004, Andreas Pflug wrote:
> The current implementation of dbsize doesn't handle tables in
> tablespaces correctly, and is quite restricted on objects covered (only
> tables and databases, but not tablespaces and indexes).
>
> The attached patch contributes:
>
> - database_size(name
On Fri, 20 Aug 2004, Tom Lane wrote:
> Bruce Momjian <[EMAIL PROTECTED]> writes:
> > No, but it is a missing capability many will complain about. I can
> > easily remove it. I saw no one comment when I added it to the patches
> > queue.
>
> I hadn't seen you add it to the patches queue ...
>
> I
This patch implements ALTER SCHEMA ... SET TABLESPACE.
This changes the default schema tablespace but does not attempted to move
objects within the schema to the new tablespace.
Docs, regression test and tab-completion included.
There were a few places which conflicted with my alter index patch
Oops.
Too much with the ol' cut and paste.
I'm happy to send an updated patch but perhaps the committer, assuming the
patch is accepted, would be kind enough to update for me.
Thanks for reviewing.
Gavin
On Fri, 13 Aug 2004, Stefan Kaltenbrunner wrote:
> Gavin Sherry wrote:
This patch has a fix for a 'thought-o' in the docs.
Gavin
Index: doc/src/sgml/ref/alter_index.sgml
===
RCS file: /usr/local/cvsroot/pgsql-server/doc/src/sgml/ref/alter_index.sgml,v
retrieving revision 1.1
diff -2 -c -r1.1 alter_index.
Attached is a patch implementing ALTER INDEX [ RENAME | OWNER TO |
SET TABLESPACE ]
I haven't included any regression tests because most of the code should be
well tested by the existing alter table tests.
Thanks,
GavinIndex: doc/src/sgml/ref/alter_index.sgml
===
On Thu, 12 Aug 2004, Bruce Momjian wrote:
>
> Did this get resolved?
>
> ---
>
> Gavin Sherry wrote:
> > Attached is a minor patch to make BEFORE DELETE triggers honour tgenabled
> > properly.
Attached is a patch resolving the issue raised here:
http://groups.google.com.au/groups?q=tablespaces+group:comp.databases.postgresql.hackers&hl=en&lr=&ie=UTF-8&group=comp.databases.postgresql.hackers&scoring=d&selm=Pine.LNX.4.58.0407281411470.17889%40linuxworld.com.au&rnum=4
When I was testing t
On Sat, 7 Aug 2004, Tom Lane wrote:
> Gavin Sherry <[EMAIL PROTECTED]> writes:
> > Attached in the usual format this time.
>
> AFAICS this patch makes exactly zero change in behavior. What was
> the point again?
With BEFORE DELETE triggers, if the trigger returns NULL,
Oops.
Attached in the usual format this time.
Gavin
On Fri, 6 Aug 2004, Bruce Momjian wrote:
>
> Can I get a context diff please?
>
> ---
>
> Gavin Sherry wrote:
> > Attached is a minor patch to mak
Included is an example of using savepoints in a non-trivial example.
Giving examples in the SQL command reference is hard because we don't have
conditionals at the SQL level.
Tom mentioned nested transactions being mentioned in places but I couldn't
find them (with grep). Suggestions?
GavinIndex
Attached.
GavinIndex: contrib/dbsize/dbsize.c
===
RCS file: /usr/local/cvsroot/pgsql-server/contrib/dbsize/dbsize.c,v
retrieving revision 1.10
diff -2 -c -r1.10 dbsize.c
*** contrib/dbsize/dbsize.c 23 Feb 2004 23:03:10 -
Attached is a minor patch to make BEFORE DELETE triggers honour tgenabled
properly.
I know that we cannot, currently, use this feature through a DDL command
but just in case someone is updating the catalogs to do it and since it is
necessary in order to implement disabling of triggers, I thought I
On Wed, 21 Jul 2004, Christopher Kings-Lynne wrote:
> > No, it doesn't. I can look into that if you like. The patch was
> > entirely to satisfy a need some of our customers have. The -T switch
> > does fill a real need for our customers; our product has a couple of tables
> > that aren't critic
On Mon, 12 Jul 2004, Bruce Momjian wrote:
> Bruce Momjian wrote:
> >
> > Patch applied. Thanks.
> >
> > I removed the display of tablespaces for sequences and toast tables:
> >
> > test=> \d test
> > Table "public.test"
> > Column | Type | Modifiers
> > +-
On Mon, 12 Jul 2004, Christopher Kings-Lynne wrote:
> > I had forgotten that the original patch allowed that. Personally I'd
> > vote for taking it out, for the above-stated reasons --- any objections?
>
> I vote for taking it out.
Pull it. I added it intentionally but now I'm questioning my re
On Tue, 6 Jul 2004, Bruce Momjian wrote:
> Tom Lane wrote:
> > Andreas Pflug <[EMAIL PROTECTED]> writes:
> > > Joe Conway wrote:
> > >> 2) This allocation size was a bit ambigous and I think based on a once
> > >> longer tablespace directory name:
> >
> > > This size calculation originated (copy/p
Small addition.Index: doc/src/sgml/ref/create_function.sgml
===
RCS file: /usr/local/cvsroot/pgsql-server/doc/src/sgml/ref/create_function.sgml,v
retrieving revision 1.57
diff -2 -c -r1.57 create_function.sgml
*** doc/src/sgml/ref/crea
Tablespace examples for CREATE TABLE/INDEX/SCHEMA/DATABASE as well as some
other examples for CREATE DATABASE.
Gavin
tablespace_examples.diff.gz
Description: GNU Zip compressed data
---(end of broadcast)---
TIP 2: you can get off all lists at once
On Thu, 1 Jul 2004, Gavin Sherry wrote:
> Hi all,
>
> Attached is an updated ALTER TABLE ... SET TABLESPACE patch.
>
> It uses the block by block copy mechanism proposed by Tom and handles i)
> ALTER TABLE and ii) Copying of TOAST tables and the TOAST
> table's in
Hi all,
Attached is an updated ALTER TABLE ... SET TABLESPACE patch.
It uses the block by block copy mechanism proposed by Tom and handles i)
ALTER TABLE and ii) Copying of TOAST tables and the TOAST
table's index.
It doesn't handle copying of system tables (pg_largeobject) and, in the
int
On Fri, 25 Jun 2004, Tom Lane wrote:
> Gavin Sherry <[EMAIL PROTECTED]> writes:
> > Attached.
>
> Couple of problems with this:
>
> 1. Don't #ifndef WIN32 it. In the first place, we might have tablespace
> support on Windows later, and in the second place, e
Attached.
There is no other way at the moment to get the tablespace name of an
object in psql.
We get information for tables, index, sequences and toast tables.
We should probably do this for schemas too...
GavinIndex: src/bin/psql/common.h
==
Exuberant ctags adds data at the beginning of the tags file. It also sorts
the tags file by default. This means, if we sort the file generated by
Exuberant ctags, it doesn't work in VIM and possibly other editors.
I didn't notice this until recently because I was using my own script. Its
possible
On Sun, 20 Jun 2004, Simon Riggs wrote:
> On Thu, 2004-05-27 at 07:59, Gavin Sherry wrote:
> > Attached is my latest patch implementing tablespaces. This has all the
> > functionality I was planning for 7.5.
> >
> > Most of the information about the patch is
Attached is a patch implementing this functionality.
I've modified make_new_heap() as well as swap_relfilenodes() to not assume
that tablespaces remain the same from old to new heap. I thought it better
to go down this road than introduce a lot of duplicate code.
Thanks
Gavin
altertable.diff.gz
Attached.
Thanks,
Gavin
tablespace-docs.diff.gz
Description: GNU Zip compressed data
---(end of broadcast)---
TIP 6: Have you searched our list archives?
http://archives.postgresql.org
On Sat, 19 Jun 2004, Andreas Pflug wrote:
[snip]
> >I don't think we should try and show all objects for a tablespace in
> >information_schema.
> >
> Agreed, information_schema is database specific. I was thinking about a
> pg_tablespace_contents(..) function anyway.
>
> >Being able to list all o
On Fri, 18 Jun 2004, Andreas Pflug wrote:
> Gavin Sherry wrote:
>
> >On Fri, 18 Jun 2004, Bruce Momjian wrote:
> >
> >[snip]
> >
> >
> >
> >>>TODO. You sound like a man who's expecting a
> >>>several-generations-polished f
On Fri, 18 Jun 2004, Bruce Momjian wrote:
[snip]
> > TODO. You sound like a man who's expecting a
> > several-generations-polished facility when we only just committed
> > the first version today. I do not feel a need to have any of these
> > features in 7.5 ...
>
> I just need to know what to
On Fri, 18 Jun 2004, Tom Lane wrote:
> Bruce Momjian <[EMAIL PROTECTED]> writes:
> > Tom Lane wrote:
> >>> Are we ripping out our initlocation code at the same time?
> >>
> >> Not done yet, but it's dead and should be removed as soon as a
> >> decent respect for the deceased permits ;-)
>
> > You
On Fri, 18 Jun 2004, Tom Lane wrote:
> Bruce Momjian <[EMAIL PROTECTED]> writes:
> > OK, I have reviewed the patch. I think Tom is doing the same, but I
> > want to report the things I found.
>
> I just came up for air after about two solid days of working on this
> patch ... had not seen your me
Hi Tom,
On Wed, 16 Jun 2004, Tom Lane wrote:
> I'm starting to review this patch, and almost immediately came across
> what seemed a spectacularly bad idea:
>
> *** src/backend/storage/buffer/bufmgr.c8 May 2004 19:09:25 -1.165
> --- src/backend/storage/buffer/bufmgr.c26 May 2004 0
Attached is an updated patch, fixing a compile error which my compiler
didn't seem to detect/suffer from and incorporating fixes to problems
raised by Neil.
Thanks,
Gavin
tablespace-20.diff.gz
Description: GNU Zip compressed data
---(end of broadcast)---
Hi all,
Attached is my latest patch implementing tablespaces. This has all the
functionality I was planning for 7.5.
Most of the information about the patch is contained in the
patch/documentation, previous submissions and the archives.
Testing, review, comments would be greatly appreciated.
Ga
On Tue, 10 Feb 2004, Peter Eisentraut wrote:
> Gavin Sherry wrote:
> > This just clears up one aspect of variable handling in psql.
> > [ "variable names are case-sensitive" ]
>
> I honestly wonder why this is suddenly of so much interest. I hope no
> one is g
This just clears up one aspect of variable handling in psql.
GavinIndex: doc/src/sgml/ref/psql-ref.sgml
===
RCS file: /usr/local/cvsroot/pgsql-server/doc/src/sgml/ref/psql-ref.sgml,v
retrieving revision 1.104
diff -2 -c -r1.104 psql-r
Attached is a patch adding a few examples for PREPARE/EXECUTE
Gavin
Index: doc/src/sgml/ref/execute.sgml
===
RCS file: /usr/local/cvsroot/pgsql-server/doc/src/sgml/ref/execute.sgml,v
retrieving revision 1.7
diff -2 -c -r1.7 execute.sg
The attached patch clarifies (or, rather, makes explicit) to readers how
to handle memory management for char pointers returned by libpq functions.
Although the sections on PQfinish(), PQclear() and PQfreemem() give an
indication that all pointers returned by functions point to memory
allocated in
On Wed, 3 Dec 2003, Christopher Kings-Lynne wrote:
>
> > + SELECT 'epoch'::timestamp + '1070430858 seconds'::interval;
> > + Result: 2003-12-03
> > 05:54:18
> >
>
> You could also go:
>
> SELECT '1070430858'::abstime;
>
> But your way is probably a bit more stable...dunno...
template1=# SELEC
On Thu, 31 Jul 2003, Tom Lane wrote:
> Gavin Sherry <[EMAIL PROTECTED]> writes:
> > What are your feelings about numeric argument vs. int4/int8 arguments?
>
> Actually I think it'd be fine to take int8. We'd not be able to cope
> with any larger input a
On Thu, 31 Jul 2003, Tom Lane wrote:
> Gavin Sherry <[EMAIL PROTECTED]> writes:
> > 2) since we're accepting numeric arguments, the patch tests for floats. If
> > a numeric is passed with non-zero decimal portion, an error is raised
> > since (from memory) the
Attached is a patch implementing factorial(), returning numeric. Points to
note:
1) arttype is numeric. I thought this was the best way of allowing
arbitarily large factorials, even though factorial(2^63) is a large
number. Happy to change to integers if this is overkill.
2) since we're accepting
Attached is a patch implementing updatable cursors in HEAD. Regression
test and documentation are included.
Updateable cursors are used as follows:
begin;
declare foo cursor for select * from bar for update;
fetch foo;
update bar set abc='def' where current of foo;
fetch foo;
delete from bar wher
96 matches
Mail list logo