Re: [PATCHES] Transaction Guarantee, updated version

2007-07-13 Thread Simon Riggs
Quick progress report: On Thu, 2007-06-21 at 16:05 -0400, Tom Lane wrote: Simon Riggs [EMAIL PROTECTED] writes: Completed all of the agreed changes for TG: All comments changed, plus some refactoring of code. Can we fix it to be a read test instead of a write test, that is, if we know WAL

Re: [PATCHES] Transaction Guarantee, updated version

2007-06-22 Thread Simon Riggs
On Thu, 2007-06-21 at 16:05 -0400, Tom Lane wrote: Simon Riggs [EMAIL PROTECTED] writes: Completed all of the agreed changes for TG: I've just realized that there's a fatal problem with this design. We've now got tqual.c setting page LSN when it holds only share lock on the buffer. That

Re: [PATCHES] Transaction Guarantee, updated version

2007-06-22 Thread Simon Riggs
On Fri, 2007-06-22 at 10:22 -0400, Tom Lane wrote: 4. If WAL has not been flushed far enough to be certain that the target transaction's commit is synced, then defer setting the hint bit. This does not require any new per-transaction state, we can just measure it on the basis of the lsn

Re: [PATCHES] Transaction Guarantee, updated version

2007-06-21 Thread Tom Lane
Simon Riggs [EMAIL PROTECTED] writes: Completed all of the agreed changes for TG: I've just realized that there's a fatal problem with this design. We've now got tqual.c setting page LSN when it holds only share lock on the buffer. That will absolutely not work, eg two backends might

[PATCHES] Transaction Guarantee, updated version

2007-06-16 Thread Simon Riggs
Completed all of the agreed changes for TG: - WAL writer now runs always, wal_writer_delay = 50ms (default) - when transaction_guarantee = off we record the latest LSN - when we set xact hint bits we look at the latest LSN - added database-level stats to show guaranteed commits - fsync parameter