Re: [PATCHES] Move cursor support for pl/pgsql

2007-03-02 Thread Tom Lane
Magnus Hagander [EMAIL PROTECTED] writes:
 I took a stab at implementing MOVE support for cursors in PL/pgsql,
 because I wanted it for a project. Attached patch *seems* to work. But..
 Given that this is my first venture into touching bison/flex files, I
 may be completely off-target in how it's done.

I disapprove of hard-wiring the fetch count as an integer constant;
there's no good reason not to treat it as an expression.  So you should
drop the T_NUMBER thing.

regards, tom lane

---(end of broadcast)---
TIP 9: In versions below 8.0, the planner will ignore your desire to
   choose an index scan if your joining column's datatypes do not
   match


Re: [PATCHES] Move cursor support for pl/pgsql

2007-03-02 Thread Magnus Hagander
Tom Lane wrote:
 Magnus Hagander [EMAIL PROTECTED] writes:
 I took a stab at implementing MOVE support for cursors in PL/pgsql,
 because I wanted it for a project. Attached patch *seems* to work. But..
 Given that this is my first venture into touching bison/flex files, I
 may be completely off-target in how it's done.
 
 I disapprove of hard-wiring the fetch count as an integer constant;
 there's no good reason not to treat it as an expression.  So you should
 drop the T_NUMBER thing.

Will do, thanks for commenting. I'm also going to merge it with Pavels
work that I had completely missed earlier.

//Magnus

---(end of broadcast)---
TIP 9: In versions below 8.0, the planner will ignore your desire to
   choose an index scan if your joining column's datatypes do not
   match