Re: [PATCHES] Rename latestCompletedXid to latestCommittedXid
Florian G. Pflug [EMAIL PROTECTED] writes: Per my post to the hackers list, here is a patch that renamed latestCompletedXid to latestCommittedXid, and updates it only on commits. This is wrong --- it will break early detection of aborted subtransactions. regards, tom lane ---(end of broadcast)--- TIP 4: Have you searched our list archives? http://archives.postgresql.org
Re: [PATCHES] Rename latestCompletedXid to latestCommittedXid
Tom Lane wrote: Florian G. Pflug [EMAIL PROTECTED] writes: Per my post to the hackers list, here is a patch that renamed latestCompletedXid to latestCommittedXid, and updates it only on commits. This is wrong --- it will break early detection of aborted subtransactions. I don't see how - TransactionIdIsInProgress doesn't even touch latestCompletedXid. And I didn't mess with XidCacheRemoveRunningXids, other than removing the latestCompletedXid updating. Am I missing something? greetings, Florian Pflug ---(end of broadcast)--- TIP 1: if posting/reading through Usenet, please send an appropriate subscribe-nomail command to [EMAIL PROTECTED] so that your message can get through to the mailing list cleanly
Re: [PATCHES] Rename latestCompletedXid to latestCommittedXid
Florian G. Pflug [EMAIL PROTECTED] writes: Tom Lane wrote: This is wrong --- it will break early detection of aborted subtransactions. I don't see how - TransactionIdIsInProgress doesn't even touch latestCompletedXid. Nah, I take that back --- I was worried that XidInMVCCSnapshot might say it was still running when it wasn't, but we never apply XidInMVCCSnapshot to XIDs that we haven't already determined to be committed, so it doesn't matter. It's still a bad idea though. Let me go respond to your -hackers post (which arrived here after the other one). regards, tom lane ---(end of broadcast)--- TIP 3: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faq
