Re: [PATCHES] mingw regression test fixes
Claudio Natoli wrote: Peter, did you mean $host_platform by any chance... as originally submitted? I see no use of $build_platform anywhere, and as committed this plain fails. I meant that $build_platform would be better than `uname`, not that my word is to be taken blindly without testing. But... I don't see why there is any need for discussion over this. There are 3 cases statements preceding this one, all of which use $host_platform. The one immediately preceding it does the very same thing for DIFFFLAGS! ... that is a very good argument for $host_platform as originally proposed. ---(end of broadcast)--- TIP 2: you can get off all lists at once with the unregister command (send unregister YourEmailAddressHere to [EMAIL PROTECTED])
Re: [PATCHES] mingw regression test fixes
Peter Eisentraut wrote: Claudio Natoli wrote: Peter, did you mean $host_platform by any chance... as originally submitted? I see no use of $build_platform anywhere, and as committed this plain fails. I meant that $build_platform would be better than `uname`, not that my word is to be taken blindly without testing. But... I don't see why there is any need for discussion over this. There are 3 cases statements preceding this one, all of which use $host_platform. The one immediately preceding it does the very same thing for DIFFFLAGS! ... that is a very good argument for $host_platform as originally proposed. OK, new code, back to original. :-) case $host_platform in *-*-mingw32*) PWDFLAGS=-W;; *) PWDFLAGS=;; esac -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup.| Newtown Square, Pennsylvania 19073 ---(end of broadcast)--- TIP 1: subscribe and unsubscribe commands go to [EMAIL PROTECTED]
Re: [PATCHES] mingw regression test fixes
OK, I have made this adjustment. Thanks. --- Andrew Dunstan wrote: Claudio Natoli said: For application to HEAD. As Andrew Dunstan appears to have cracked the regression test buffering nut, this patch makes sure that: * correct platform specific regression files are used under ming * pwd prints out a usable win32 pathname Claudio, I'm assuming that you have checked that this works, as it is slightly different from what I did. Strictly speaking, the pwd flags test should probably depend in the test platform rather than the target platform. Something like: case `uname` in MINGW32*) PWDFLAGS=-W;; *) PWDFLAGS=;; esac I made that adjustment to what I was doing late in the day, but didn't have time to do a revised patch before I had to do other things. cheers andrew ---(end of broadcast)--- TIP 7: don't forget to increase your free space map settings -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup.| Newtown Square, Pennsylvania 19073 ---(end of broadcast)--- TIP 6: Have you searched our list archives? http://archives.postgresql.org
Re: [PATCHES] mingw regression test fixes
Claudio Natoli said: For application to HEAD. As Andrew Dunstan appears to have cracked the regression test buffering nut, this patch makes sure that: * correct platform specific regression files are used under ming * pwd prints out a usable win32 pathname Claudio, I'm assuming that you have checked that this works, as it is slightly different from what I did. Strictly speaking, the pwd flags test should probably depend in the test platform rather than the target platform. Something like: case `uname` in MINGW32*) PWDFLAGS=-W;; *) PWDFLAGS=;; esac I made that adjustment to what I was doing late in the day, but didn't have time to do a revised patch before I had to do other things. cheers andrew ---(end of broadcast)--- TIP 7: don't forget to increase your free space map settings
