Re: Values list-of-targetlists patch for comments (was Re: [PATCHES] [HACKERS] 8.2 features?)

2006-08-01 Thread Tom Lane
Gavin Sherry [EMAIL PROTECTED] writes: Is this intentional: template1=# values(1), (2); column1 - 1 2 (2 rows) You bet. VALUES is parallel to SELECT in the SQL grammar, so AFAICS it should be legal anywhere you can write SELECT. The basic productions in the spec's

Re: Values list-of-targetlists patch for comments (was Re: [PATCHES] [HACKERS] 8.2 features?)

2006-07-24 Thread Tom Lane
Joe Conway [EMAIL PROTECTED] writes: Good feedback -- thanks! But without the RTE, how would VALUES in the FROM clause work? Is it different from INSERT? I'm just imagining a Values node in the jointree and nothing in the rangetable. If I'm reading the spec correctly, VALUES is exactly

Values list-of-targetlists patch for comments (was Re: [PATCHES] [HACKERS] 8.2 features?)

2006-07-23 Thread Joe Conway
Tom Lane wrote: Joe Conway [EMAIL PROTECTED] writes: I'm liking this too. But when you say jointree node, are you saying to model the new node type after NestLoop/MergeJoin/HashJoin nodes? These are referred to as join nodes in ExecInitNode. Or as you mentioned a couple of times, should this