Re: [Fwd: [PATCHES] Make psql use all pretty print options]

2003-12-01 Thread Bruce Momjian
Patch applied. Thanks. The CHECK part of this patch was already applied to 7.4. --- Christopher Kings-Lynne wrote: Resubmission of patch (for 7.4). I fixed the problems I was having what I chatted to you Bruce, I've

Re: [Fwd: [PATCHES] Make psql use all pretty print options]

2003-11-30 Thread Bruce Momjian
Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches I will try to apply it within the next 48 hours. --- Christopher Kings-Lynne wrote:

Re: [Fwd: [PATCHES] Make psql use all pretty print options]

2003-10-14 Thread Tom Lane
Christopher Kings-Lynne [EMAIL PROTECTED] writes: Resubmission of patch (for 7.4). While I agree with the objection that we shouldn't break the strings freeze for this, I do think it might be a good idea to apply the change that prints CHECK constraints using pg_get_constraintdef() rather than

Re: [Fwd: [PATCHES] Make psql use all pretty print options]

2003-10-10 Thread Alvaro Herrera
On Fri, Oct 10, 2003 at 12:42:50PM +0800, Christopher Kings-Lynne wrote: OK, for reviewers. Note the index predicate and the check constraint in particular. It seems to have the nice property of allowing output to be copy-n-pasted without further modification. -- Alvaro Herrera

Re: [Fwd: [PATCHES] Make psql use all pretty print options]

2003-10-10 Thread Bruce Momjian
Christopher Kings-Lynne wrote: It looks like the patch changes translated strings which isn't supposed to happen. It can of course still be accepted, that's not my call. Yes, actually it does now that I look at it. However, I submitted this patch weeks ago. If it's not accepted for the

Re: [Fwd: [PATCHES] Make psql use all pretty print options]

2003-10-10 Thread Bruce Momjian
This has been saved for the 7.5 release: http:/momjian.postgresql.org/cgi-bin/pgpatches2 --- Christopher Kings-Lynne wrote: Resubmission of patch (for 7.4). I fixed the problems I was having what I chatted to

Re: [Fwd: [PATCHES] Make psql use all pretty print options]

2003-10-09 Thread Bruce Momjian
Uh, I can't apply this to 7.4 unless you can get others to agree it should be added. Sorry. I am including the patch in this email in case people want to review it. --- Christopher Kings-Lynne wrote: Resubmission of

Re: [Fwd: [PATCHES] Make psql use all pretty print options]

2003-10-09 Thread Dennis Bjorklund
On Thu, 9 Oct 2003, Bruce Momjian wrote: Uh, I can't apply this to 7.4 unless you can get others to agree it should be added. Sorry. It looks like the patch changes translated strings which isn't supposed to happen. It can of course still be accepted, that's not my call. ps. Unified diffs

Re: [Fwd: [PATCHES] Make psql use all pretty print options]

2003-10-09 Thread Christopher Kings-Lynne
It looks like the patch changes translated strings which isn't supposed to happen. It can of course still be accepted, that's not my call. Yes, actually it does now that I look at it. However, I submitted this patch weeks ago. If it's not accepted for the time being due to freeze, then that's