Re: [PATCHES] [BUGS] casting strings to multidimensional arrays yields strange

2004-08-04 Thread Joe Conway
Tom Lane wrote: Joe Conway <[EMAIL PROTECTED]> writes: While looking at it the last day or so, I started to think it might be better to use bison to parse array literals -- or is that a bad idea? Offhand it doesn't seem like a super-appropriate tool. Once you get past the lexical details like quo

Re: [PATCHES] [BUGS] casting strings to multidimensional arrays yields strange results

2004-08-04 Thread Tom Lane
Joe Conway <[EMAIL PROTECTED]> writes: > While looking at it the last day or so, I started to think it might be > better to use bison to parse array literals -- or is that a bad idea? Offhand it doesn't seem like a super-appropriate tool. Once you get past the lexical details like quoting, the s

Re: [PATCHES] [BUGS] casting strings to multidimensional arrays yields strange

2004-08-04 Thread Joe Conway
Tom Lane wrote: I had pretty much come to the conclusion that the array_in code should be thrown away and rewritten from the ground up --- whoever wrote it originally had no calling as a programmer :-(. I didn't look at the details of your patch, but I have little faith in half measures in this ar

Re: [PATCHES] [BUGS] casting strings to multidimensional arrays yields strange results

2004-08-04 Thread Tom Lane
Joe Conway <[EMAIL PROTECTED]> writes: > OK, this is done, but there is still an ugly bug in there (i.e. was > there prior to my just committed changes and still exists) somewhere > that I noticed while modifying domain.sql. Namely, if you forget to put > a delimiter inbetween subarrays in a mul

Re: [PATCHES] [BUGS] casting strings to multidimensional arrays yields strange

2004-08-04 Thread Joe Conway
Tom Lane wrote: Joe Conway <[EMAIL PROTECTED]> writes: If there are no objections, I'll adjust the appropriate regression script/expected files and commit tonight. And of course I'll follow up with documentation updates too. BTW, I believe the plan is to wrap 8.0beta1 tomorrow, so please do get t

Re: [PATCHES] [BUGS] casting strings to multidimensional arrays yields strange results

2004-08-04 Thread Tom Lane
Joe Conway <[EMAIL PROTECTED]> writes: > If there are no objections, I'll adjust the appropriate regression > script/expected files and commit tonight. And of course I'll follow up > with documentation updates too. BTW, I believe the plan is to wrap 8.0beta1 tomorrow, so please do get this in to

Re: [PATCHES] [BUGS] casting strings to multidimensional arrays yields strange results

2004-08-04 Thread Tom Lane
Joe Conway <[EMAIL PROTECTED]> writes: > Negative lower bound indicies now work also, and array_out will always > output explicit dimensions for an array with any dimension having a > lower bound of other than one. Seems reasonable to me. > Any thoughts on whether or not to apply this to 7.4?

Re: [PATCHES] [BUGS] casting strings to multidimensional arrays yields strange

2004-08-04 Thread Joe Conway
Tom Lane wrote: [ cc'ing pghackers in case anyone wants to object ] Joe Conway <[EMAIL PROTECTED]> writes: I think that even once we support NULL array elements, they should be explicitly requested -- i.e. throwing an error on non-rectangular input is still the right thing to do. I haven't sugges