Re: [PATCHES] [HACKERS] Adding a --quiet option to initdb

2006-01-25 Thread Tom Lane
Devrim GUNDUZ [EMAIL PROTECTED] writes:
 Attached is a patch which adds --quiet and --q option to initdb.

Why is this a good idea?

regards, tom lane

---(end of broadcast)---
TIP 5: don't forget to increase your free space map settings


Re: [PATCHES] [HACKERS] Adding a --quiet option to initdb

2006-01-25 Thread Devrim GUNDUZ
Hi,

On Wed, 2006-01-25 at 11:28 -0500, Tom Lane wrote:
 Devrim GUNDUZ [EMAIL PROTECTED] writes:
  Attached is a patch which adds --quiet and --q option to initdb.
 
 Why is this a good idea?

I was playing with 8.2 RPM init script and thought that instead of
directing the output to /dev/null, it would be better to use a command
line option for that. Also, we are designing a new installer project and
--quiet might help us.

I would rise this idea in -hackers before providing a patch, but since
this is my first patch, I thought it would be a good exercise for me.

Regards,
-- 
The PostgreSQL Company - Command Prompt, Inc. 1.503.667.4564
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
Managed Services, Shared and Dedicated Hosting
Co-Authors: plPHP, plPerlNG - http://www.commandprompt.com/



---(end of broadcast)---
TIP 6: explain analyze is your friend


Re: [PATCHES] [HACKERS] Adding a --quiet option to initdb

2006-01-25 Thread Bruce Momjian
Devrim GUNDUZ wrote:
 Hi,
 
 On Wed, 2006-01-25 at 11:28 -0500, Tom Lane wrote:
  Devrim GUNDUZ [EMAIL PROTECTED] writes:
   Attached is a patch which adds --quiet and --q option to initdb.
  
  Why is this a good idea?
 
 I was playing with 8.2 RPM init script and thought that instead of
 directing the output to /dev/null, it would be better to use a command
 line option for that. Also, we are designing a new installer project and
 --quiet might help us.
 
 I would rise this idea in -hackers before providing a patch, but since
 this is my first patch, I thought it would be a good exercise for me.

OK, as long as you understand that the patch should not be applied.  It
might be valuable from only one person is not enough.

-- 
  Bruce Momjian|  http://candle.pha.pa.us
  pgman@candle.pha.pa.us   |  (610) 359-1001
  +  If your life is a hard drive, |  13 Roberts Road
  +  Christ can be your backup.|  Newtown Square, Pennsylvania 19073

---(end of broadcast)---
TIP 2: Don't 'kill -9' the postmaster


Re: [PATCHES] [HACKERS] Adding a --quiet option to initdb

2006-01-25 Thread Greg Stark
Bruce Momjian pgman@candle.pha.pa.us writes:

 Devrim GUNDUZ wrote:
  Hi,
  
  On Wed, 2006-01-25 at 11:28 -0500, Tom Lane wrote:
   Devrim GUNDUZ [EMAIL PROTECTED] writes:
Attached is a patch which adds --quiet and --q option to initdb.
   
   Why is this a good idea?
  
  I was playing with 8.2 RPM init script and thought that instead of
  directing the output to /dev/null, it would be better to use a command
  line option for that. Also, we are designing a new installer project and
  --quiet might help us.
 
 OK, as long as you understand that the patch should not be applied.  It
 might be valuable from only one person is not enough.

I always wondered why the Redhat init scripts thought it was a clever idea to
redirect the output to /dev/null. It seems like a pessimal user interface
choice. Every time I have to work with a Redhat machine where Postgres isn't
starting up the first thing I have to do is edit the init script so I can what
the problem is.

-- 
greg


---(end of broadcast)---
TIP 3: Have you checked our extensive FAQ?

   http://www.postgresql.org/docs/faq


Re: [PATCHES] [HACKERS] Adding a --quiet option to initdb

2006-01-25 Thread Tom Lane
Greg Stark [EMAIL PROTECTED] writes:
 I always wondered why the Redhat init scripts thought it was a clever idea to
 redirect the output to /dev/null. It seems like a pessimal user interface
 choice. Every time I have to work with a Redhat machine where Postgres isn't
 starting up the first thing I have to do is edit the init script so I can what
 the problem is.

Yeah, that's finally fixed in the latest versions.  The problem was that
sending the postmaster log into a file wasn't a good long-term idea
because of the lack of any way to rotate the log.  Current RPMs set up
redirect_stderr with some reasonable rotation options instead.

regards, tom lane

---(end of broadcast)---
TIP 6: explain analyze is your friend