Re: [PATCHES] Better formatting of functions in pg_dump

2008-07-01 Thread Heikki Linnakangas
Tom Lane wrote: "Greg Sabino Mullane" <[EMAIL PROTECTED]> writes: Why the random switching between newline-before and newline-after styles? Please be consistent. I thought they were all "after". On second glance, they still seem all after? Oh, my mistake, I had failed to see that the patch

Re: [PATCHES] Better formatting of functions in pg_dump

2008-06-13 Thread Tom Lane
"Greg Sabino Mullane" <[EMAIL PROTECTED]> writes: >> Why the random switching between newline-before and newline-after >> styles? Please be consistent. > I thought they were all "after". On second glance, they still seem > all after? Oh, my mistake, I had failed to see that the patch was getting

Re: [PATCHES] Better formatting of functions in pg_dump

2008-06-12 Thread Greg Sabino Mullane
-BEGIN PGP SIGNED MESSAGE- Hash: RIPEMD160 >> Attached patch puts the "metadata" about a function, especially the >> language name, at the top of the CREATE FUNCTION statement, above the >> possibly long, multi-line function definition. > Why the random switching between newline-before

Re: [PATCHES] Better formatting of functions in pg_dump

2008-06-12 Thread Tom Lane
Greg Sabino Mullane <[EMAIL PROTECTED]> writes: > Attached patch puts the "metadata" about a function, especially the > language name, at the top of the CREATE FUNCTION statement, above the > possibly long, multi-line function definition. Why the random switching between newline-before and newline

[PATCHES] Better formatting of functions in pg_dump

2008-06-12 Thread Greg Sabino Mullane
Attached patch puts the "metadata" about a function, especially the language name, at the top of the CREATE FUNCTION statement, above the possibly long, multi-line function definition. -- Greg Sabino Mullane Index: pg_dump.c === RCS