Re: [PATCHES] COPY CSV header line feature

2005-05-06 Thread Bruce Momjian
Applied. --- pgman wrote: > > Here is an updated version of this patch, with documentation changes. > > I have already updated the gram.y comment you suggested. > >

Re: [PATCHES] COPY CSV header line feature

2005-05-05 Thread Bruce Momjian
Here is an updated version of this patch, with documentation changes. I have already updated the gram.y comment you suggested. --- Andrew Dunstan wrote: > > ammended patch attached. sorry for the oversight. I agree with To

Re: [PATCHES] COPY CSV header line feature

2005-03-16 Thread Andrew Dunstan
ammended patch attached. sorry for the oversight. I agree with Tom's remark - it's far too easy to miss this. cheers andrew Alvaro Herrera wrote: >On Tue, Mar 15, 2005 at 08:55:36PM -0600, Andrew Dunstan wrote: > > >>Alvaro Herrera said: >> >> >>>On Sun, Mar 13, 2005 at 06:32:20PM -0500,

Re: [PATCHES] COPY CSV header line feature

2005-03-15 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > I think you should add the new reserved keyword to the > unreserved_keywords list or some other. *Every* keyword needs to be in one of those lists. I'd like to have some sort of automatic enforcement of this, because forgetting to add a new keyword to

Re: [PATCHES] COPY CSV header line feature

2005-03-15 Thread Alvaro Herrera
On Tue, Mar 15, 2005 at 08:55:36PM -0600, Andrew Dunstan wrote: > Alvaro Herrera said: > > On Sun, Mar 13, 2005 at 06:32:20PM -0500, Andrew Dunstan wrote: > > > >> The attached patch implements the previously discussed header line > >> feature for CSV mode COPY. It is triggered by the keyword HEADE

Re: [PATCHES] COPY CSV header line feature

2005-03-15 Thread Andrew Dunstan
Alvaro Herrera said: > On Sun, Mar 13, 2005 at 06:32:20PM -0500, Andrew Dunstan wrote: > >> The attached patch implements the previously discussed header line >> feature for CSV mode COPY. It is triggered by the keyword HEADER >> (blame Bruce - he chose it ;-) ). > > I think you should add the new

Re: [PATCHES] COPY CSV header line feature

2005-03-15 Thread Alvaro Herrera
On Sun, Mar 13, 2005 at 06:32:20PM -0500, Andrew Dunstan wrote: > The attached patch implements the previously discussed header line > feature for CSV mode COPY. It is triggered by the keyword HEADER (blame > Bruce - he chose it ;-) ). I think you should add the new reserved keyword to the unrese

[PATCHES] COPY CSV header line feature

2005-03-13 Thread Andrew Dunstan
The attached patch implements the previously discussed header line feature for CSV mode COPY. It is triggered by the keyword HEADER (blame Bruce - he chose it ;-) ). On input this feature causes the first line to be ignored; on output it generates a line of column names. This will make playing w