Re: [PATCHES] Constraint Exclusion (Partitioning) - Initial Review requested

2005-07-02 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > On Sat, Jul 02, 2005 at 03:56:48PM -0400, Bruce Momjian wrote: >> I am surprised no one else has commented on it, which I think means your >> code is ready for the queue. Do you want to adjust it based on this >> feedback or should I apply and you can a

Re: [PATCHES] Constraint Exclusion (Partitioning) - Initial Review requested

2005-07-02 Thread Alvaro Herrera
On Sat, Jul 02, 2005 at 03:56:48PM -0400, Bruce Momjian wrote: > Simon Riggs wrote: > > > > I enclose a fully working implementation of Constraint Exclusion, a very > > basic form of Partitioning. Initial review is requested, to allow us all > > to assess what further work is required on this pri

Re: [PATCHES] Constraint Exclusion (Partitioning) - Initial Review requested

2005-07-02 Thread Bruce Momjian
Seems you have managed to combine inheritance, check constraints, and partial index into table paritioning. It is nice it requires no new syntax. Here is an example from your tests: DROP TABLE pm cascade; CREATE TABLE pm ( dkey INT NOT NULL );

Re: [PATCHES] Constraint Exclusion (Partitioning) - Initial Review requested

2005-06-30 Thread Bruce Momjian
Simon Riggs wrote: > On Mon, 2005-06-27 at 01:41 +0100, Simon Riggs wrote: > > I enclose a fully working implementation of Constraint Exclusion, a very > > basic form of Partitioning. Initial review is requested, to allow us all > > to assess what further work is required on this prior to Beta free