Re: [PATCHES] Enable integer datetimes by default
Added to TODO: * Have configure choose integer datetimes by default http://archives.postgresql.org/pgsql-patches/2007-05/msg00046.php --- Tom Lane wrote: Neil Conway [EMAIL PROTECTED] writes: On Sun, 2007-06-05 at 00:20 -0400, Andrew Dunstan wrote: I object to the short notice. I think we need to give people a chance to adjust their configs Sure, I can wait a few days (although if we're going to do this for 8.3, we should do it promptly). On reflection, it might actually be wiser to delay making this change until the beginning of the 8.4 cycle... +1 ... this had not been previously discussed for 8.3 and so it's arguably too late in the cycle. regards, tom lane ---(end of broadcast)--- TIP 2: Don't 'kill -9' the postmaster -- Bruce Momjian [EMAIL PROTECTED] http://momjian.us EnterpriseDB http://www.enterprisedb.com + If your life is a hard drive, Christ can be your backup. + ---(end of broadcast)--- TIP 7: You can help support the PostgreSQL project by donating at http://www.postgresql.org/about/donate
Re: [PATCHES] Enable integer datetimes by default
On Sun, 2007-06-05 at 00:20 -0400, Andrew Dunstan wrote: I object to the short notice. I think we need to give people a chance to adjust their configs Sure, I can wait a few days (although if we're going to do this for 8.3, we should do it promptly). On reflection, it might actually be wiser to delay making this change until the beginning of the 8.4 cycle... -Neil ---(end of broadcast)--- TIP 6: explain analyze is your friend
Re: [PATCHES] Enable integer datetimes by default
Peter Eisentraut wrote: Andrew Dunstan wrote: I think we need to give people a chance to adjust their configs, especially on the buildfarm, where those who have currently simply removed the --enable-integer-datetimes setting will need to adjust their configs. Why? They have previously been testing the default and now they would be testing a different default. It is not the default for the buildfarm - the default config has --enable-integer-datetimes. I would rather people have a chance to adjust their configs so they keep testing the same config set, regardless of whether or not it's the default. cheers andrew ---(end of broadcast)--- TIP 5: don't forget to increase your free space map settings
Re: [PATCHES] Enable integer datetimes by default
Neil Conway wrote: On reflection, it might actually be wiser to delay making this change until the beginning of the 8.4 cycle... I think that's probably true, but I can live with it either way as long as there's enough notice. cheers andrew ---(end of broadcast)--- TIP 7: You can help support the PostgreSQL project by donating at http://www.postgresql.org/about/donate
[PATCHES] Enable integer datetimes by default
Attached is a patch that enables integer datetimes by default, per
recent discussion on -hackers. It makes --enable-integer-datetimes the
default, and documents the --disable-integer-datetimes configure
option as a means to get the previous default behavior.
Barring any objections, I'll apply this to HEAD tomorrow.
-Neil
Index: configure
===
RCS file: /home/neilc/postgres/cvs_root/pgsql/configure,v
retrieving revision 1.547
diff -c -p -r1.547 configure
*** configure 4 May 2007 15:20:50 - 1.547
--- configure 6 May 2007 03:10:08 -
*** if test -n $ac_init_help; then
*** 859,865
Optional Features:
--disable-FEATURE do not include FEATURE (same as --enable-FEATURE=no)
--enable-FEATURE[=ARG] include FEATURE [ARG=yes]
! --enable-integer-datetimes enable 64-bit integer date/time support
--enable-nls[=LANGUAGES] enable Native Language Support
--disable-shareddo not build shared libraries
--disable-rpath do not embed shared library search path in executables
--- 859,865
Optional Features:
--disable-FEATURE do not include FEATURE (same as --enable-FEATURE=no)
--enable-FEATURE[=ARG] include FEATURE [ARG=yes]
! --disable-integer-datetimes disable 64-bit integer date/time support
--enable-nls[=LANGUAGES] enable Native Language Support
--disable-shareddo not build shared libraries
--disable-rpath do not embed shared library search path in executables
*** fi;
*** 1699,1705
#
! # 64-bit integer date/time storage (--enable-integer-datetimes)
#
echo $as_me:$LINENO: checking whether to build with 64-bit integer date/time support 5
echo $ECHO_N checking whether to build with 64-bit integer date/time support... $ECHO_C 6
--- 1699,1705
#
! # 64-bit integer date/time storage: enabled by default.
#
echo $as_me:$LINENO: checking whether to build with 64-bit integer date/time support 5
echo $ECHO_N checking whether to build with 64-bit integer date/time support... $ECHO_C 6
*** echo $as_me: error: no argument expecte
*** 1729,1735
esac
else
! enable_integer_datetimes=no
fi;
--- 1729,1739
esac
else
! enable_integer_datetimes=yes
!
! cat confdefs.h \_ACEOF
! #define USE_INTEGER_DATETIMES 1
! _ACEOF
fi;
*** fi
*** 22277,22282
--- 22281,22306
+ # If the user did not disable integer datetimes, check that
+ # there is a working 64-bit integral type to use.
+ if test x$USE_INTEGER_DATETIMES = xyes
+test x$HAVE_LONG_INT_64 = xno
+test x$HAVE_LONG_LONG_INT_64 = xno
+test x$HAVE_INT64 = xno ; then
+ { { echo $as_me:$LINENO: error:
+ Integer-based datetime support requires a 64-bit integer type,
+ but no such type could be found. The --disable-integer-datetimes
+ configure option can be used to disable integer-based storage
+ of datetime values. 5
+ echo $as_me: error:
+ Integer-based datetime support requires a 64-bit integer type,
+ but no such type could be found. The --disable-integer-datetimes
+ configure option can be used to disable integer-based storage
+ of datetime values. 2;}
+{ (exit 1); exit 1; }; }
+ fi
+
+
if test $PORTNAME != win32
then
echo $as_me:$LINENO: checking for POSIX signal interface 5
Index: configure.in
===
RCS file: /home/neilc/postgres/cvs_root/pgsql/configure.in,v
retrieving revision 1.514
diff -c -p -r1.514 configure.in
*** configure.in 4 May 2007 15:20:52 - 1.514
--- configure.in 6 May 2007 03:08:04 -
*** PGAC_ARG_REQ(with, libs, [ --with-
*** 137,146
#
! # 64-bit integer date/time storage (--enable-integer-datetimes)
#
AC_MSG_CHECKING([whether to build with 64-bit integer date/time support])
! PGAC_ARG_BOOL(enable, integer-datetimes, no, [ --enable-integer-datetimes enable 64-bit integer date/time support],
[AC_DEFINE([USE_INTEGER_DATETIMES], 1,
[Define to 1 if you want 64-bit integer timestamp and interval support. (--enable-integer-datetimes)])])
AC_MSG_RESULT([$enable_integer_datetimes])
--- 137,146
#
! # 64-bit integer date/time storage: enabled by default.
#
AC_MSG_CHECKING([whether to build with 64-bit integer date/time support])
! PGAC_ARG_BOOL(enable, integer-datetimes, yes, [ --disable-integer-datetimes disable 64-bit integer date/time support],
[AC_DEFINE([USE_INTEGER_DATETIMES], 1,
[Define to 1 if you want 64-bit integer timestamp and interval support. (--enable-integer-datetimes)])])
AC_MSG_RESULT([$enable_integer_datetimes])
*** AC_CHECK_TYPES([int8, uint8, int64, uint
*** 1362,1367
--- 1362,1381
AC_CHECK_TYPES(sig_atomic_t, [], [], [#include signal.h])
+ # If the user did not disable integer
Re: [PATCHES] Enable integer datetimes by default
On May 5, 2007, at 22:28 , Neil Conway wrote: Attached is a patch that enables integer datetimes by default, per recent discussion on -hackers. It makes --enable-integer- datetimes the default, and documents the --disable-integer-datetimes configure option as a means to get the previous default behavior. Would it make more sense to have phrase it in the positive sense? i.e., --enable-floating-point-datetimes? I guess that's a bit longer, but it says what you're doing, rather than what you're *not* doing. Michael Glaesemann grzm seespotcode net ---(end of broadcast)--- TIP 3: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faq
Re: [PATCHES] Enable integer datetimes by default
On Sat, 2007-05-05 at 22:49 -0500, Michael Glaesemann wrote: Would it make more sense to have phrase it in the positive sense? i.e., --enable-floating-point-datetimes? I guess that's a bit longer, but it says what you're doing, rather than what you're *not* doing. I think the primary reason people will want to use FP-based datetimes is because they can't use integer-based datetimes for compatibility reasons (e.g. no OS support for 64-bit integers, or they need to remain compatible with old applications). The situation is analogous to --without-spinlocks: we could call that --enable-slow-locking or something, but that would sound like we're enabling an additional feature. It would also mean there would be an implicit relationship between --enable-integer-datetimes and --enable-fp-datetimes (at most one can be true). IMHO it would be simpler to just keep a single boolean variable (integer datetimes enabled or not). -Neil ---(end of broadcast)--- TIP 6: explain analyze is your friend
Re: [PATCHES] Enable integer datetimes by default
Neil Conway wrote: Attached is a patch that enables integer datetimes by default, per recent discussion on -hackers. It makes --enable-integer-datetimes the default, and documents the --disable-integer-datetimes configure option as a means to get the previous default behavior. Barring any objections, I'll apply this to HEAD tomorrow. I object to the short notice. I think we need to give people a chance to adjust their configs, especially on the buildfarm, where those who have currently simply removed the --enable-integer-datetimes setting will need to adjust their configs. Once there is agreement I think we should at the very least give those people a few days to adjust. cheers andrew ---(end of broadcast)--- TIP 7: You can help support the PostgreSQL project by donating at http://www.postgresql.org/about/donate
