Re: [PATCHES] Explain XML patch v2

2008-07-05 Thread Simon Riggs
On Fri, 2008-07-04 at 19:38 +0100, Dave Page wrote: On Fri, Jul 4, 2008 at 5:20 PM, Simon Riggs [EMAIL PROTECTED] wrote: * If the patch was implemented as an ExplainOneQuery_hook we would be able to use this with 8.3 also, which might be interesting. So there's no real need for this to

Re: [PATCHES] Explain XML patch v2

2008-07-05 Thread Dave Page
On Sat, Jul 5, 2008 at 10:41 AM, Simon Riggs [EMAIL PROTECTED] wrote: It can be optional since plugins can add parameters also. GUCs I assume you mean, not grammar. Unless I'm misreading the code though, if the plugin is there it will always run instead of the regular explain code, so

Re: [PATCHES] Explain XML patch v2

2008-07-05 Thread Simon Riggs
On Sat, 2008-07-05 at 16:00 +0100, Dave Page wrote: On Sat, Jul 5, 2008 at 10:41 AM, Simon Riggs [EMAIL PROTECTED] wrote: It can be optional since plugins can add parameters also. GUCs I assume you mean, not grammar. Unless I'm misreading the code though, if the plugin is there it will

Re: [PATCHES] Explain XML patch v2

2008-07-04 Thread Tom Raney
Quoting daveg [EMAIL PROTECTED]: On Wed, Jul 02, 2008 at 09:01:18AM -0700, David Fetter wrote: On Wed, Jul 02, 2008 at 05:57:29PM +0200, Peter Eisentraut wrote: It would also be interesting if EXPLAIN could optionally be a function that returns a datum of type XML, to allow further

Re: [PATCHES] Explain XML patch v2

2008-07-04 Thread Peter Eisentraut
Am Freitag, 4. Juli 2008 schrieb Tom Raney: Regarding the XML datum, in order to support that, will all users need   to compile with libxml?  Are there any lighter weight solutions to   serialize other than libxml? You can create XML without libxml. -- Sent via pgsql-patches mailing list

Re: [HACKERS] [PATCHES] Explain XML patch v2

2008-07-04 Thread Tom Lane
Peter Eisentraut [EMAIL PROTECTED] writes: Am Freitag, 4. Juli 2008 schrieb Tom Raney: Regarding the XML datum, in order to support that, will all users need   to compile with libxml?  Are there any lighter weight solutions to   serialize other than libxml? You can create XML without libxml.

Re: [PATCHES] Explain XML patch v2

2008-07-04 Thread Simon Riggs
On Tue, 2008-07-01 at 21:48 -0700, Tom Raney wrote: This is an update to my EXPLAIN XML patch submitted a few days ago. This is an important patch and you've done well to get it this far. I have much detailed feedback, but these are just emergent requests, now I can see and understand what

Re: [PATCHES] Explain XML patch v2

2008-07-04 Thread Dave Page
On Fri, Jul 4, 2008 at 5:20 PM, Simon Riggs [EMAIL PROTECTED] wrote: * If the patch was implemented as an ExplainOneQuery_hook we would be able to use this with 8.3 also, which might be interesting. So there's no real need for this to be a patch on core. Would that mean that instead of being

Re: [PATCHES] Explain XML patch v2

2008-07-02 Thread Gregory Stark
Tom Raney [EMAIL PROTECTED] writes: This is an update to my EXPLAIN XML patch submitted a few days ago. I've added a documentation patch and modified some of the code per comments by Gregory Stark. You should update the wiki at http://wiki.postgresql.org/wiki/CommitFest:2008-07 so any

Re: [PATCHES] Explain XML patch v2

2008-07-02 Thread Peter Eisentraut
Am Mittwoch, 2. Juli 2008 schrieb Tom Raney: This is an update to my EXPLAIN XML patch submitted a few days ago. Could you explain how you came up with the XML schema design? I suppose you just made something up that went along with the existing XML output. I would like to see more

Re: [PATCHES] Explain XML patch v2

2008-07-02 Thread Dave Page
On Wed, Jul 2, 2008 at 4:57 PM, Peter Eisentraut [EMAIL PROTECTED] wrote: Am Mittwoch, 2. Juli 2008 schrieb Tom Raney: This is an update to my EXPLAIN XML patch submitted a few days ago. Could you explain how you came up with the XML schema design? I suppose you just made something up that

Re: [PATCHES] Explain XML patch v2

2008-07-02 Thread daveg
On Wed, Jul 02, 2008 at 09:01:18AM -0700, David Fetter wrote: On Wed, Jul 02, 2008 at 05:57:29PM +0200, Peter Eisentraut wrote: It would also be interesting if EXPLAIN could optionally be a function that returns a datum of type XML, to allow further processing. It would be better to have

Re: [PATCHES] Explain XML patch v2

2008-07-02 Thread Tom Raney
Peter Eisentraut wrote: Am Mittwoch, 2. Juli 2008 schrieb Tom Raney: This is an update to my EXPLAIN XML patch submitted a few days ago. Could you explain how you came up with the XML schema design? I suppose you just made something up that went along with the existing XML output.

[PATCHES] Explain XML patch v2

2008-07-01 Thread Tom Raney
This is an update to my EXPLAIN XML patch submitted a few days ago. I've added a documentation patch and modified some of the code per comments by Gregory Stark. Because the main consumer of output generated by this patch will presumably be a machine, I didn't clutter up the documentation