Re: [PATCHES] Fast CLUSTER

2007-03-28 Thread Tom Lane
Simon Riggs [EMAIL PROTECTED] writes: [ make CLUSTER skip WAL when possible ] Applied with some editorialization. regards, tom lane ---(end of broadcast)--- TIP 5: don't forget to increase your free space map settings

Re: [PATCHES] Fast CLUSTER

2007-03-27 Thread Simon Riggs
On Thu, 2007-02-22 at 22:49 +, Simon Riggs wrote: On Tue, 2007-02-20 at 14:38 -0300, Alvaro Herrera wrote: Cool. I noticed that the SGML seems broken here: Corrected. You need to close the listitem and para opened in the COPY mention. + + static void +

Re: [PATCHES] Fast CLUSTER

2007-03-27 Thread Bruce Momjian
Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches It will be applied as soon as one of the PostgreSQL committers reviews and approves it. ---

Re: [PATCHES] Fast CLUSTER

2007-03-27 Thread Bruce Momjian
Simon Riggs wrote: On Thu, 2007-02-22 at 22:49 +, Simon Riggs wrote: On Tue, 2007-02-20 at 14:38 -0300, Alvaro Herrera wrote: Cool. I noticed that the SGML seems broken here: Corrected. You need to close the listitem and para opened in the COPY mention. + +

Re: [PATCHES] Fast CLUSTER

2007-03-27 Thread Simon Riggs
On Tue, 2007-03-27 at 10:28 -0400, Bruce Momjian wrote: Simon Riggs wrote: On Thu, 2007-02-22 at 22:49 +, Simon Riggs wrote: Could we add this to the unapplied patches queue? It seems to have been missed off the list. Thanks. Done. Many thanks -- Simon Riggs

Re: [PATCHES] Fast CLUSTER

2007-02-22 Thread Simon Riggs
On Tue, 2007-02-20 at 14:38 -0300, Alvaro Herrera wrote: Cool. I noticed that the SGML seems broken here: Corrected. You need to close the listitem and para opened in the COPY mention. + + static void + heap_sync_relation(Relation rel) + { + if (!rel-rd_istemp) No comment

Re: [PATCHES] Fast CLUSTER

2007-02-20 Thread Alvaro Herrera
Simon Riggs wrote: I've used the heap_sync() API call to improve performance of CLUSTER by avoiding WAL when archive_command is not set. Cool. I noticed that the SGML seems broken here: --- 908,925 will perform more slowly when varnamearchive_command/varname is set, as a

[PATCHES] Fast CLUSTER

2007-02-07 Thread Simon Riggs
I've used the heap_sync() API call to improve performance of CLUSTER by avoiding WAL when archive_command is not set. I've refactored the heap_sync() call very slightly, to hide some of the complexity that was previously exposed to COPY. It now syncs a TOAST relation automatically if one exists