Re: [PATCHES] Fix for VACUUM in psql autocommit off

2004-09-21 Thread Michael Paesold
Tom Lane wrote: It is now fixed in the attached patch. Applied with some additional cleanup (the code wasn't multibyte-aware, and so could get fooled in some Far Eastern encodings). Looking at your cleanup is a good for learning more about C. :-) But I have one another question, you

Re: [PATCHES] Fix for VACUUM in psql autocommit off

2004-09-20 Thread Michael Paesold
Tom Lane wrote: It is now fixed in the attached patch. Applied with some additional cleanup (the code wasn't multibyte-aware, and so could get fooled in some Far Eastern encodings). I am very pleased to hear. This was my first patch submitted. :-) Best Regards, Michael Paesold

Re: [PATCHES] Fix for VACUUM in psql autocommit off

2004-09-19 Thread Tom Lane
Michael Paesold [EMAIL PROTECTED] writes: In current cvs (as in version 7.4.5), VACUUM does not work at all in autocommit=off mode. That is, because psql does not know that VACUUM cannot be performed inside an transaction. I consider this a bug and suggest the attached fix. If we're going to

Re: [PATCHES] Fix for VACUUM in psql autocommit off

2004-09-19 Thread Michael Paesold
Tom Lane wrote: If we're going to do that, we should also include the other statements that disallow execution in a transaction, and we should rename is_transact_command to something more appropriate (not to mention fix its comments). A quick grep shows PreventTransactionChain((void *)