Re: [PATCHES] On-disk bitmap index implementation

2006-12-27 Thread Heikki Linnakangas
Gavin Sherry wrote: There are still some things Jie and I have not gotten to yet: ... o Test WAL replay more thoroughly. Found one WAL related bug: postgres=# CREATE TABLE test (i int); CREATE TABLE postgres=# INSERT INTO test SELECT a FROM generate_series(1,10) a; INSERT 0 10 postgres=#

Re: [PATCHES] On-disk bitmap index implementation

2006-12-27 Thread Gavin Sherry
On Wed, 27 Dec 2006, Heikki Linnakangas wrote: Gavin Sherry wrote: There are still some things Jie and I have not gotten to yet: ... o Test WAL replay more thoroughly. Found one WAL related bug: postgres=# CREATE TABLE test (i int); CREATE TABLE postgres=# INSERT INTO test SELECT a

Re: [PATCHES] On-disk bitmap index implementation

2006-12-05 Thread Heikki Linnakangas
Gavin Sherry wrote: o Improving VACUUM support -- currently, VACUUM FULL means REINDEX for bitmaps. Heikki Linnakangas offered to work on this. Heikki, are you still interested? BTW vacuuming seems quite broken as it is: [EMAIL PROTECTED]:~/pgsql.bitmap$ ~/pgsql.bitmap/bin/psql -a

Re: [PATCHES] On-disk bitmap index implementation

2006-12-05 Thread Gavin Sherry
On Tue, 5 Dec 2006, Heikki Linnakangas wrote: Gavin Sherry wrote: o Improving VACUUM support -- currently, VACUUM FULL means REINDEX for bitmaps. Heikki Linnakangas offered to work on this. Heikki, are you still interested? BTW vacuuming seems quite broken as it is: [EMAIL

Re: [PATCHES] On-disk bitmap index implementation

2006-12-04 Thread Simon Riggs
On Tue, 2006-12-05 at 00:18 +1100, Gavin Sherry wrote: o Determine if we need to provide anything for rm_startup, rm_cleanup, rm_safe_restartpoint RmgrData function pointers. safe_restartpoint gives true/false based upon whether there are multi-record WAL states that have only been partially

Re: [PATCHES] On-disk bitmap index implementation

2006-12-04 Thread Heikki Linnakangas
Gavin Sherry wrote: Hi all, Attached is a patch implementing bitmap indexes. It includes major enhancements on the patch submitted during feature freeze for 8.2 here[1]. In particular: much better integration with the existing bitmap scan code with the internals of the bitmap streaming pushed

Re: [PATCHES] On-disk bitmap index implementation

2006-12-04 Thread Heikki Linnakangas
Heikki Linnakangas wrote: We need to give the indexam API some further thought. As you know, I've been working on the Grouped Index Tuples stuff, which also requires changes to the API to get full benefit. There's a bunch of functionality I'd like to see: * Support for streamed bitmaps, like

Re: [PATCHES] On-disk bitmap index implementation

2006-12-04 Thread Gavin Sherry
On Mon, 4 Dec 2006, Simon Riggs wrote: On Tue, 2006-12-05 at 00:18 +1100, Gavin Sherry wrote: o Determine if we need to provide anything for rm_startup, rm_cleanup, rm_safe_restartpoint RmgrData function pointers. safe_restartpoint gives true/false based upon whether there are

Re: [PATCHES] On-disk bitmap index implementation

2006-12-04 Thread Gavin Sherry
On Mon, 4 Dec 2006, Heikki Linnakangas wrote: o Test WAL replay more thoroughly. I've had that problem too with a lot of things I've hacked. I've used a shell script that does the operation under test, runs a select, kills and restarts postmaster, and reruns the select. If the select after