Re: [PATCHES] PITR Archival

2004-06-25 Thread Simon Riggs
On Tue, 2004-06-15 at 16:34, Simon Riggs wrote: > I enclose a working set of context diff patches and new files to make > PITR archiving work, as of cvstip (NOW). As of now, this patch is invalidated by recent changes. Don't try to run it, it doesn't even start. There's good news coming later in

Re: [PATCHES] PITR Archival

2004-06-15 Thread Bruce Momjian
Simon Riggs wrote: > Also note: archive_mode is not designed to be turned on/off frequently. > It is possible to confuse it if you turn it on, then restart with it > off, then turn it on again. That is likely to create a "hole" in the > archive history of xlogs and you will not be able to recover c

Re: [PATCHES] PITR Archival

2004-06-15 Thread Bruce Momjian
Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches I will try to apply it once it is reviewed. --- Simon Riggs wrote: > I enclose a working set o

Re: [PATCHES] PITR Archival

2004-06-15 Thread Alvaro Herrera
On Tue, Jun 15, 2004 at 04:34:30PM +0100, Simon Riggs wrote: > I have a considerable amount still to learn about CVS, diff and patch, > so anybody wanting to spend 10-15 mins on the phone with me would > greatly enhance my chances of helping patch my patch, when the bugs roll > in. Can't help you

Re: [PATCHES] PITR Archival

2004-06-15 Thread Simon Riggs
On Tue, 2004-06-15 at 16:34, Simon Riggs wrote: > I enclose a working set of context diff patches and new files to make > PITR archiving work, as of cvstip (NOW). > > You'll see the new options in the postgresql.conf...though you may wish > to use archive_debug = true as well, when testing. > >

[PATCHES] PITR Archival

2004-06-15 Thread Simon Riggs
I enclose a working set of context diff patches and new files to make PITR archiving work, as of cvstip (NOW). You'll see the new options in the postgresql.conf...though you may wish to use archive_debug = true as well, when testing. There is one bug: shutdown doesn't work quite right. I haven't