Re: [PATCHES] Synchronous Commit Doc Patch

2007-07-16 Thread Bruce Momjian
bruce wrote: > > Uh, we need a context diff for this. Uh, never mind. The final version has a context diff. --- > > --- > > Simon Riggs wrote: > >

Re: [PATCHES] Synchronous Commit Doc Patch

2007-07-16 Thread Bruce Momjian
Uh, we need a context diff for this. --- Simon Riggs wrote: > On Fri, 2007-07-13 at 15:01 +0200, Reviewer wrote: > > > I just read your patch in order to understand a little bit what will > > happen in the next release. >

Re: [PATCHES] Synchronous Commit Doc Patch

2007-07-16 Thread Bruce Momjian
Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches It will be applied as soon as one of the PostgreSQL committers reviews and approves it. --- Si

Re: [PATCHES] Synchronous Commit Doc Patch

2007-07-16 Thread Bruce Momjian
Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches It will be applied as soon as one of the PostgreSQL committers reviews and approves it. --- Si

Re: [PATCHES] Synchronous Commit Doc Patch

2007-07-13 Thread Simon Riggs
On Fri, 2007-07-13 at 14:00 -0500, Jim C. Nasby wrote: > On Fri, Jul 13, 2007 at 07:11:54PM +0100, Simon Riggs wrote: > > On Fri, 2007-07-13 at 12:38 -0500, Jim C. Nasby wrote: > > > One question... can operations that shortcut the WAL by fsyncing direct > > > to disk also use async commit? I suspe

Re: [PATCHES] Synchronous Commit Doc Patch

2007-07-13 Thread Jim C. Nasby
On Fri, Jul 13, 2007 at 07:11:54PM +0100, Simon Riggs wrote: > On Fri, 2007-07-13 at 12:38 -0500, Jim C. Nasby wrote: > > One question... can operations that shortcut the WAL by fsyncing direct > > to disk also use async commit? I suspect the answer is an implicit "no" > > because the only examples

Re: [PATCHES] Synchronous Commit Doc Patch

2007-07-13 Thread Simon Riggs
On Fri, 2007-07-13 at 12:38 -0500, Jim C. Nasby wrote: > One question... can operations that shortcut the WAL by fsyncing direct > to disk also use async commit? I suspect the answer is an implicit "no" > because the only examples I can think of all involve DDL, but it's > probably worth spelling t

Re: [PATCHES] Synchronous Commit Doc Patch

2007-07-13 Thread Jim C. Nasby
One question... can operations that shortcut the WAL by fsyncing direct to disk also use async commit? I suspect the answer is an implicit "no" because the only examples I can think of all involve DDL, but it's probably worth spelling that out... -- Jim Nasby [

Re: [PATCHES] Synchronous Commit Doc Patch

2007-07-13 Thread Simon Riggs
On Fri, 2007-07-13 at 14:59 +0100, Simon Riggs wrote: > On Fri, 2007-07-13 at 15:01 +0200, Reviewer wrote: ...A few more minor changes... thanks very much. I'll wrap these into a final submission with the main patch. -- Simon Riggs EnterpriseDB http://www.enterprisedb.com ---

Re: [PATCHES] Synchronous Commit Doc Patch

2007-07-13 Thread Simon Riggs
On Fri, 2007-07-13 at 15:01 +0200, Reviewer wrote: > I just read your patch in order to understand a little bit what will > happen in the next release. Thanks for the review. v2 attached. > About the guc variable wal_writer_delay, you say at the end: > "This parameter can only > + be se

[PATCHES] Synchronous Commit Doc Patch

2007-07-13 Thread Simon Riggs
Doc patch only... To aid with the understanding of the synchronous commit technique, I've completed the docs prior to the completion of the final version of the patch. Any review comments, final doubts etc.., please say them now... Applies cleanly to CVS HEAD, sgml make OK. -- Simon Riggs