Re: [PATCHES] Win32 fix for pg_dumpall

2004-08-15 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > /* > > * We emulate fgets() behaviour. So if there is no newline > > * at the end, we add one... > > */ > > ! if (line[len-1

Re: [PATCHES] Win32 fix for pg_dumpall

2004-08-15 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > /* >* We emulate fgets() behaviour. So if there is no newline >* at the end, we add one... >*/ > ! if (line[len-1] != '\n') >

Re: [PATCHES] Win32 fix for pg_dumpall

2004-08-15 Thread Bruce Momjian
OK, I have cleaned up this code and clarified the comment. Attached and applied. --- Andrew Dunstan wrote: > > > Bruce Momjian wrote: > > > > > /* > >+ * Sometime the child

Re: [PATCHES] Win32 fix for pg_dumpall

2004-08-08 Thread Bruce Momjian
Andrew Dunstan wrote: > > > Bruce Momjian wrote: > > > > > /* > >+ * Sometime the child returns "\r\n", which doesn't match > >+ * our version string. The backend uses > >+ * setvbuf(stdout, NULL, _

Re: [PATCHES] Win32 fix for pg_dumpall

2004-08-08 Thread Andrew Dunstan
Bruce Momjian wrote: /* + * Sometime the child returns "\r\n", which doesn't match + * our version string. The backend uses + * setvbuf(stdout, NULL, _IONBF, 0), but pg_dump doesn't + * so we have to fix it here. + */ + if (strlen(line) >= 2 && + line[strlen(line)

[PATCHES] Win32 fix for pg_dumpall

2004-08-07 Thread Bruce Momjian
Here is fix for Win32 pg_dumpall that Claudio helped with. Attached and applied. -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup.