Re: [PATCHES] drop if exists - first piece

2005-11-19 Thread Andrew Dunstan
Tom Lane wrote: New test seems reasonable. done. A few other minor comments: * The NOTICEs should probably not carry an ERRCODE; usually you just want a notice to go out with the default not an error SQLSTATE. done. * The Assert(missing_ok)s are a waste of code space --- if

Re: [PATCHES] drop if exists - first piece

2005-11-18 Thread Tom Lane
Andrew Dunstan [EMAIL PROTECTED] writes: I will apply the attached patch tomorrow, barring objection. This covers drop if exists for the following objects: table view index sequence schema type domain conversion I have a simple test script as show below, but I am not sure where to put it