Re: [PATCHES] float4/float8/int64 passed by value with tsearchfixup

2008-04-21 Thread Bruce Momjian
Tom Lane wrote: > Gregory Stark <[EMAIL PROTECTED]> writes: > > So are you killing V0 for non-integral types? Because if not we should keep > > some sacrificial module to the regression tests to use to test for this > > problem. > > Well, we could potentially continue to have, say, the oldstyle >

Re: [PATCHES] float4/float8/int64 passed by value with tsearchfixup

2008-04-20 Thread Tom Lane
Gregory Stark <[EMAIL PROTECTED]> writes: > So are you killing V0 for non-integral types? Because if not we should keep > some sacrificial module to the regression tests to use to test for this > problem. Well, we could potentially continue to have, say, the oldstyle geo_distance function used whe

Re: [PATCHES] float4/float8/int64 passed by value with tsearchfixup

2008-04-20 Thread Zoltan Boszormenyi
Gregory Stark írta: "Tom Lane" <[EMAIL PROTECTED]> writes: BTW, I trolled the contrib files for other v0 functions taking or returning float4 or float8. I found seg_size (fixed it) and a whole bunch of functions in earthdistance. Those use float8 not float4, so they are not broken by this

Re: [PATCHES] float4/float8/int64 passed by value with tsearchfixup

2008-04-20 Thread Gregory Stark
"Tom Lane" <[EMAIL PROTECTED]> writes: > BTW, I trolled the contrib files for other v0 functions taking or > returning float4 or float8. I found seg_size (fixed it) and a whole > bunch of functions in earthdistance. Those use float8 not float4, > so they are not broken by this patch, but that mo

Re: [PATCHES] float4/float8/int64 passed by value with tsearchfixup

2008-04-20 Thread Gregory Stark
"Tom Lane" <[EMAIL PROTECTED]> writes: > Gregory Stark <[EMAIL PROTECTED]> writes: >>> Tom Lane wrote: Specifically, I think what you missed is that on some platforms C functions pass or return float values differently from similar-sized integer or pointer values (typically, the flo

Re: [PATCHES] float4/float8/int64 passed by value with tsearchfixup

2008-04-19 Thread Tom Lane
Tom Lane <[EMAIL PROTECTED]> writes: > BTW, I trolled the contrib files for other v0 functions taking or > returning float4 or float8. I found seg_size (fixed it) and a whole > bunch of functions in earthdistance. Hmm, actually most of the "bunch" are SQL functions, there's only one that needs fi

Re: [PATCHES] float4/float8/int64 passed by value with tsearchfixup

2008-04-19 Thread Tom Lane
BTW, I trolled the contrib files for other v0 functions taking or returning float4 or float8. I found seg_size (fixed it) and a whole bunch of functions in earthdistance. Those use float8 not float4, so they are not broken by this patch, but that module will have to be v1-ified before we can cons

Re: [PATCHES] float4/float8/int64 passed by value with tsearchfixup

2008-04-19 Thread Tom Lane
Gregory Stark <[EMAIL PROTECTED]> writes: >> Tom Lane wrote: >>> Specifically, I think what you missed is that on some platforms C >>> functions pass or return float values differently from similar-sized >>> integer or pointer values (typically, the float values get passed in >>> floating-point reg

Re: [PATCHES] float4/float8/int64 passed by value with tsearchfixup

2008-04-18 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> I was wondering about that too, once it became obvious that (almost?) >> everything was failing not just some platforms. However, this >> afternoon's CVS HEAD *does* pass the seg regression test for me on HPPA, >> and I presume it pas

Re: [PATCHES] float4/float8/int64 passed by value with tsearchfixup

2008-04-18 Thread Alvaro Herrera
Tom Lane wrote: > I was wondering about that too, once it became obvious that (almost?) > everything was failing not just some platforms. However, this > afternoon's CVS HEAD *does* pass the seg regression test for me on HPPA, > and I presume it passed on whatever Alvaro is using (btw, what was >

Re: [PATCHES] float4/float8/int64 passed by value with tsearchfixup

2008-04-18 Thread Alvaro Herrera
Tom Lane wrote: > Gregory Stark <[EMAIL PROTECTED]> writes: > >> Tom Lane wrote: > >>> Specifically, I think what you missed is that on some platforms C > >>> functions pass or return float values differently from similar-sized > >>> integer or pointer values (typically, the float values get passed

Re: [PATCHES] float4/float8/int64 passed by value with tsearchfixup

2008-04-18 Thread Tom Lane
Gregory Stark <[EMAIL PROTECTED]> writes: >> Tom Lane wrote: >>> Specifically, I think what you missed is that on some platforms C >>> functions pass or return float values differently from similar-sized >>> integer or pointer values (typically, the float values get passed in >>> floating-point reg

Re: [PATCHES] float4/float8/int64 passed by value with tsearchfixup

2008-04-18 Thread Gregory Stark
"Alvaro Herrera" <[EMAIL PROTECTED]> writes: > Tom Lane wrote: > >> Specifically, I think what you missed is that on some platforms C >> functions pass or return float values differently from similar-sized >> integer or pointer values (typically, the float values get passed in >> floating-point r