Re: [PATCHES] msvc const warnings

2007-07-25 Thread Magnus Hagander
On Tue, Jul 24, 2007 at 09:43:51PM +0200, Magnus Hagander wrote: Tom Lane wrote: Magnus Hagander [EMAIL PROTECTED] writes: Tom Lane wrote: Gregory Stark [EMAIL PROTECTED] writes: Can we just disable const checking for MSVCC in general without using the #pragmas? It clearly doesn't

[PATCHES] msvc const warnings

2007-07-24 Thread Magnus Hagander
MSVC generates a number of const warnings, that's been discussed before (http://archives.postgresql.org/pgsql-hackers/2007-01/msg01214.php). Attached patch adds a pragma to get rid of the warnings. Again, not sure if it's worth it? I think I need to #ifdef the pragma - gcc generates a warning if

Re: [PATCHES] msvc const warnings

2007-07-24 Thread Tom Lane
Gregory Stark [EMAIL PROTECTED] writes: Magnus Hagander [EMAIL PROTECTED] writes: Stefan mentioned that the warning may be one that shows up in a different compiler somewhere as well, thouh, which might indicate that we should fix the underlying issue? (Even if the code is correct, if it

Re: [PATCHES] msvc const warnings

2007-07-24 Thread Gregory Stark
Tom Lane [EMAIL PROTECTED] writes: Gregory Stark [EMAIL PROTECTED] writes: Magnus Hagander [EMAIL PROTECTED] writes: Stefan mentioned that the warning may be one that shows up in a different compiler somewhere as well, thouh, which might indicate that we should fix the underlying issue?

Re: [PATCHES] msvc const warnings

2007-07-24 Thread Tom Lane
Gregory Stark [EMAIL PROTECTED] writes: Can we just disable const checking for MSVCC in general without using the #pragmas? It clearly doesn't understand how const works making that warning from it useless. +1 ... any useful warning of this kind will be had from other compilers.

Re: [PATCHES] msvc const warnings

2007-07-24 Thread Peter Eisentraut
Am Dienstag, 24. Juli 2007 17:24 schrieb Gregory Stark: Can we just disable const checking for MSVCC in general without using the #pragmas? It clearly doesn't understand how const works making that warning from it useless. That was my thought. -- Peter Eisentraut

Re: [PATCHES] msvc const warnings

2007-07-24 Thread Magnus Hagander
Tom Lane wrote: Gregory Stark [EMAIL PROTECTED] writes: Can we just disable const checking for MSVCC in general without using the #pragmas? It clearly doesn't understand how const works making that warning from it useless. +1 ... any useful warning of this kind will be had from other

Re: [PATCHES] msvc const warnings

2007-07-24 Thread Tom Lane
Magnus Hagander [EMAIL PROTECTED] writes: Tom Lane wrote: Gregory Stark [EMAIL PROTECTED] writes: Can we just disable const checking for MSVCC in general without using the #pragmas? It clearly doesn't understand how const works making that warning from it useless. +1 ... any useful warning

Re: [PATCHES] msvc const warnings

2007-07-24 Thread Magnus Hagander
Tom Lane wrote: Magnus Hagander [EMAIL PROTECTED] writes: Tom Lane wrote: Gregory Stark [EMAIL PROTECTED] writes: Can we just disable const checking for MSVCC in general without using the #pragmas? It clearly doesn't understand how const works making that warning from it useless. +1 ... any